test/models/user_test.rb

   1 require "test_helper"
   2
   3 class UserTest < ActiveSupport::TestCase
   4   include Rails::Dom::Testing::Assertions::SelectorAssertions
   5
   6   def test_invalid_with_empty_attributes
   7     user = build(:user, :email => nil,
   8                         :pass_crypt => nil,
   9                         :display_name => nil,
  10                         :home_lat => nil,
  11                         :home_lon => nil,
  12                         :home_zoom => nil)
  13     assert_not user.valid?
  14     assert_predicate user.errors[:email], :any?
  15     assert_predicate user.errors[:pass_crypt], :any?
  16     assert_predicate user.errors[:display_name], :any?
  17     assert_predicate user.errors[:home_lat], :none?
  18     assert_predicate user.errors[:home_lon], :none?
  19     assert_predicate user.errors[:home_zoom], :none?
  20   end
  21
  22   def test_unique_email
  23     existing_user = create(:user)
  24     new_user = build(:user, :email => existing_user.email)
  25     assert_not new_user.save
  26     assert_includes new_user.errors[:email], "has already been taken"
  27   end
  28
  29   def test_unique_display_name
  30     existing_user = create(:user)
  31     new_user = build(:user, :display_name => existing_user.display_name)
  32     assert_not new_user.save
  33     assert_includes new_user.errors[:display_name], "has already been taken"
  34   end
  35
  36   def test_email_valid
  37     ok = %w[a@s.com test@shaunmcdonald.me.uk hello_local@ping-d.ng
  38             test_local@openstreetmap.org test-local@example.com]
  39     bad = %w[hi ht@ n@ @.com help@.me.uk help"hi.me.uk も対@応します
  40              輕觸搖晃的遊戲@ah.com も対応します@s.name]
  41
  42     ok.each do |name|
  43       user = build(:user)
  44       user.email = name
  45       assert user.valid?(:save), "#{name} isn't valid when it should be"
  46     end
  47
  48     bad.each do |name|
  49       user = build(:user)
  50       user.email = name
  51       assert user.invalid?(:save), "#{name} is valid when it shouldn't be"
  52     end
  53   end
  54
  55   def test_display_name_length
  56     user = build(:user)
  57     user.display_name = "123"
  58     assert_predicate user, :valid?, "should allow 3 char name name"
  59     user.display_name = "12"
  60     assert_not user.valid?, "should not allow 2 char name"
  61     user.display_name = ""
  62     assert_not user.valid?, "should not allow blank/0 char name"
  63     user.display_name = nil
  64     assert_not user.valid?, "should not allow nil value"
  65   end
  66
  67   def test_display_name_valid
  68     # Due to sanitisation in the view some of these that you might not
  69     # expect are allowed
  70     # However, would they affect the xml planet dumps?
  71     ok = ["Name", "'me", "he\"", "<hr>", "*ho", "\"help\"@",
  72           "vergrößern", "ルシステムにも対応します", "輕觸搖晃的遊戲", "space space"]
  73     # These need to be 3 chars in length, otherwise the length test above
  74     # should be used.
  75     bad = ["<hr/>", "test@example.com", "s/f", "aa/", "aa;", "aa.",
  76            "aa,", "aa?", "/;.,?", "も対応します/", "#ping",
  77            "foo\x1fbar", "foo\x7fbar", "foo\ufffebar", "foo\uffffbar",
  78            "new", "terms", "save", "confirm", "confirm-email",
  79            "go_public", "reset-password", "forgot-password", "suspended",
  80            "trailing whitespace ", " leading whitespace"]
  81     ok.each do |display_name|
  82       user = build(:user)
  83       user.display_name = display_name
  84       assert_predicate user, :valid?, "#{display_name} is invalid, when it should be"
  85     end
  86
  87     bad.each do |display_name|
  88       user = build(:user)
  89       user.display_name = display_name
  90       assert_not user.valid?, "#{display_name} is valid when it shouldn't be"
  91     end
  92   end
  93
  94   def test_display_name_user_id_new
  95     existing_user = create(:user)
  96     user = build(:user)
  97
  98     user.display_name = "user_#{existing_user.id}"
  99     assert_not user.valid?, "user_<id> name is valid for existing user id when it shouldn't be"
 100
 101     user.display_name = "user_#{existing_user.id + 1}"
 102     assert_not user.valid?, "user_<id> name is valid for new user id when it shouldn't be"
 103   end
 104
 105   def test_display_name_user_id_rename
 106     existing_user = create(:user)
 107     user = create(:user)
 108
 109     user.display_name = "user_#{existing_user.id}"
 110     assert_not user.valid?, "user_<id> name is valid for existing user id when it shouldn't be"
 111
 112     user.display_name = "user_#{user.id}"
 113     assert_predicate user, :valid?, "user_<id> name is invalid for own id, when it should be"
 114   end
 115
 116   def test_friends_with
 117     alice = create(:user, :active)
 118     bob = create(:user, :active)
 119     charlie = create(:user, :active)
 120     create(:friendship, :befriender => alice, :befriendee => bob)
 121
 122     assert alice.friends_with?(bob)
 123     assert_not alice.friends_with?(charlie)
 124     assert_not bob.friends_with?(alice)
 125     assert_not bob.friends_with?(charlie)
 126     assert_not charlie.friends_with?(bob)
 127     assert_not charlie.friends_with?(alice)
 128   end
 129
 130   def test_users_nearby
 131     alice = create(:user, :active, :home_lat => 51.0, :home_lon => 1.0, :data_public => false)
 132     bob = create(:user, :active, :home_lat => 51.1, :home_lon => 1.0, :data_public => true)
 133     charlie = create(:user, :active, :home_lat => 51.1, :home_lon => 1.1, :data_public => true)
 134     david = create(:user, :active, :home_lat => 10.0, :home_lon => -123.0, :data_public => true)
 135     _edward = create(:user, :suspended, :home_lat => 10.0, :home_lon => -123.0, :data_public => true)
 136     south_pole_user = create(:user, :active, :home_lat => -90.0, :home_lon => 0.0, :data_public => true)
 137     vagrant_user = create(:user, :active, :home_lat => nil, :home_lon => nil, :data_public => true)
 138
 139     # bob and charlie are both near alice
 140     assert_equal [bob, charlie], alice.nearby
 141     # charlie and alice are both near bob, but alice has their data private
 142     assert_equal [charlie], bob.nearby
 143     # david has no user nearby, since edward is not active
 144     assert_empty david.nearby
 145     # south_pole_user has no user nearby, and doesn't throw exception
 146     assert_empty south_pole_user.nearby
 147     # vagrant_user has no home location
 148     assert_empty vagrant_user.nearby
 149   end
 150
 151   def test_friends
 152     norm = create(:user, :active)
 153     sec = create(:user, :active)
 154     create(:friendship, :befriender => norm, :befriendee => sec)
 155
 156     assert_equal [sec], norm.friends
 157     assert_equal 1, norm.friends.size
 158
 159     assert_empty sec.friends
 160     assert_equal 0, sec.friends.size
 161   end
 162
 163   def test_user_preferred_editor
 164     user = create(:user)
 165     assert_nil user.preferred_editor
 166     user.preferred_editor = "id"
 167     assert_equal "id", user.preferred_editor
 168     user.save!
 169
 170     user.preferred_editor = "invalid_editor"
 171     assert_raise(ActiveRecord::RecordInvalid) { user.save! }
 172   end
 173
 174   def test_visible
 175     pending = create(:user, :pending)
 176     active = create(:user, :active)
 177     confirmed = create(:user, :confirmed)
 178     suspended = create(:user, :suspended)
 179     deleted = create(:user, :deleted)
 180
 181     assert User.visible.find(pending.id)
 182     assert User.visible.find(active.id)
 183     assert User.visible.find(confirmed.id)
 184     assert_raise ActiveRecord::RecordNotFound do
 185       User.visible.find(suspended.id)
 186     end
 187     assert_raise ActiveRecord::RecordNotFound do
 188       User.visible.find(deleted.id)
 189     end
 190   end
 191
 192   def test_active
 193     pending = create(:user, :pending)
 194     active = create(:user, :active)
 195     confirmed = create(:user, :confirmed)
 196     suspended = create(:user, :suspended)
 197     deleted = create(:user, :deleted)
 198
 199     assert User.active.find(active.id)
 200     assert User.active.find(confirmed.id)
 201     assert_raise ActiveRecord::RecordNotFound do
 202       User.active.find(pending.id)
 203     end
 204     assert_raise ActiveRecord::RecordNotFound do
 205       User.active.find(suspended.id)
 206     end
 207     assert_raise ActiveRecord::RecordNotFound do
 208       User.active.find(deleted.id)
 209     end
 210   end
 211
 212   def test_identifiable
 213     public_user = create(:user, :data_public => true)
 214     private_user = create(:user, :data_public => false)
 215
 216     assert User.identifiable.find(public_user.id)
 217     assert_raise ActiveRecord::RecordNotFound do
 218       User.identifiable.find(private_user.id)
 219     end
 220   end
 221
 222   def test_languages
 223     create(:language, :code => "en")
 224     create(:language, :code => "de")
 225     create(:language, :code => "sl")
 226
 227     user = create(:user, :languages => ["en"])
 228     assert_equal ["en"], user.languages
 229     user.languages = %w[de fr en]
 230     assert_equal %w[de fr en], user.languages
 231     user.languages = %w[fr de sl]
 232     assert_equal "de", user.preferred_language
 233     assert_equal %w[fr de sl], user.preferred_languages.map(&:to_s)
 234     user = create(:user, :languages => %w[en de])
 235     assert_equal %w[en de], user.languages
 236   end
 237
 238   def test_visible?
 239     assert_predicate build(:user, :pending), :visible?
 240     assert_predicate build(:user, :active), :visible?
 241     assert_predicate build(:user, :confirmed), :visible?
 242     assert_not build(:user, :suspended).visible?
 243     assert_not build(:user, :deleted).visible?
 244   end
 245
 246   def test_active?
 247     assert_not build(:user, :pending).active?
 248     assert_predicate build(:user, :active), :active?
 249     assert_predicate build(:user, :confirmed), :active?
 250     assert_not build(:user, :suspended).active?
 251     assert_not build(:user, :deleted).active?
 252   end
 253
 254   def test_moderator?
 255     assert_not create(:user).moderator?
 256     assert_predicate create(:moderator_user), :moderator?
 257   end
 258
 259   def test_administrator?
 260     assert_not create(:user).administrator?
 261     assert_predicate create(:administrator_user), :administrator?
 262   end
 263
 264   def test_role?
 265     assert_not create(:user).role?("administrator")
 266     assert_not create(:user).role?("moderator")
 267     assert create(:administrator_user).role?("administrator")
 268     assert create(:moderator_user).role?("moderator")
 269   end
 270
 271   def test_soft_destroy
 272     user = create(:user, :with_home_location, :description => "foo")
 273     user.soft_destroy
 274     assert_equal "user_#{user.id}", user.display_name
 275     assert_predicate user.description, :blank?
 276     assert_nil user.home_lat
 277     assert_nil user.home_lon
 278     assert_not user.avatar.attached?
 279     assert_equal "deleted", user.status
 280     assert_not user.visible?
 281     assert_not user.active?
 282   end
 283
 284   def test_soft_destroy_revokes_oauth1_tokens
 285     user = create(:user)
 286     access_token = create(:access_token, :user => user)
 287     assert_equal 1, user.oauth_tokens.authorized.count
 288
 289     user.soft_destroy
 290
 291     assert_equal 0, user.oauth_tokens.authorized.count
 292     access_token.reload
 293     assert_predicate access_token, :invalidated?
 294   end
 295
 296   def test_soft_destroy_revokes_oauth2_tokens
 297     user = create(:user)
 298     oauth_access_token = create(:oauth_access_token, :resource_owner_id => user.id)
 299     assert_equal 1, user.access_tokens.not_expired.count
 300
 301     user.soft_destroy
 302
 303     assert_equal 0, user.access_tokens.not_expired.count
 304     oauth_access_token.reload
 305     assert_predicate oauth_access_token, :revoked?
 306   end
 307
 308   def test_deletion_allowed_when_no_changesets
 309     with_user_account_deletion_delay(10000) do
 310       user = create(:user)
 311       assert_predicate user, :deletion_allowed?
 312     end
 313   end
 314
 315   def test_deletion_allowed_without_delay
 316     with_user_account_deletion_delay(nil) do
 317       user = create(:user)
 318       create(:changeset, :user => user)
 319       user.reload
 320       assert_predicate user, :deletion_allowed?
 321     end
 322   end
 323
 324   def test_deletion_allowed_past_delay
 325     with_user_account_deletion_delay(10) do
 326       user = create(:user)
 327       create(:changeset, :user => user, :created_at => Time.now.utc - 12.hours, :closed_at => Time.now.utc - 10.hours)
 328       user.reload
 329       assert_predicate user, :deletion_allowed?
 330     end
 331   end
 332
 333   def test_deletion_allowed_during_delay
 334     with_user_account_deletion_delay(10) do
 335       user = create(:user)
 336       create(:changeset, :user => user, :created_at => Time.now.utc - 11.hours, :closed_at => Time.now.utc - 9.hours)
 337       user.reload
 338       assert_not_predicate user, :deletion_allowed?
 339       assert_equal Time.now.utc + 1.hour, user.deletion_allowed_at
 340     end
 341   end
 342
 343   def test_deletion_allowed_past_zero_delay
 344     with_user_account_deletion_delay(0) do
 345       user = create(:user)
 346       create(:changeset, :user => user, :created_at => Time.now.utc, :closed_at => Time.now.utc + 1.hour)
 347       travel 90.minutes do
 348         user.reload
 349         assert_predicate user, :deletion_allowed?
 350       end
 351     end
 352   end
 353
 354   def test_deletion_allowed_during_zero_delay
 355     with_user_account_deletion_delay(0) do
 356       user = create(:user)
 357       create(:changeset, :user => user, :created_at => Time.now.utc, :closed_at => Time.now.utc + 1.hour)
 358       travel 30.minutes do
 359         user.reload
 360         assert_not_predicate user, :deletion_allowed?
 361         assert_equal Time.now.utc + 30.minutes, user.deletion_allowed_at
 362       end
 363     end
 364   end
 365 end