From: Tom Hughes <tom@compton.nu>
Date: Mon, 17 Jan 2022 11:01:07 +0000 (+0000)
Subject: Remove form_action restrictions for sessions#login
X-Git-Tag: live~1406
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/988d7cd90df00a8eabbc3cc40e1f3467a0b2dec0

Remove form_action restrictions for sessions#login

Login may redirect to ouath2_authorizations#create which may then
redirect to arbitrary schemes if the application is already authorized
so we need to allow login to redirect to any scheme.

Fixes #3424
---

diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb
index bb3854e69..5b46d67d0 100644
--- a/app/controllers/sessions_controller.rb
+++ b/app/controllers/sessions_controller.rb
@@ -12,9 +12,7 @@ class SessionsController < ApplicationController
   authorize_resource :class => false
 
   def new
-    append_content_security_policy_directives(
-      :form_action => %w[*]
-    )
+    override_content_security_policy_directives(:form_action => []) if Settings.csp_enforce || Settings.key?(:csp_report_url)
 
     session[:referer] = safe_referer(params[:referer]) if params[:referer]
   end