From 59280377bf40b900a2d340474dd94dcec5abea3f Mon Sep 17 00:00:00 2001 From: Matt Amos Date: Wed, 4 Apr 2012 17:22:33 +0100 Subject: [PATCH] Fixed redaction attribute on old nodes and ways, added same functionality to relations. --- app/models/old_node.rb | 2 +- app/models/old_relation.rb | 29 ++++++++++++++++++----------- app/models/old_way.rb | 2 +- 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/app/models/old_node.rb b/app/models/old_node.rb index 9e2c5a40e..3ded52382 100644 --- a/app/models/old_node.rb +++ b/app/models/old_node.rb @@ -68,7 +68,7 @@ class OldNode < ActiveRecord::Base el1['timestamp'] = self.timestamp.xmlschema el1['version'] = self.version.to_s if self.redacted? - el1['redacted'] = self.redaction.title + el1['redacted'] = self.redaction.id.to_s end return el1 end diff --git a/app/models/old_relation.rb b/app/models/old_relation.rb index 20651f622..34d76ff9c 100644 --- a/app/models/old_relation.rb +++ b/app/models/old_relation.rb @@ -105,20 +105,27 @@ class OldRelation < ActiveRecord::Base el1['version'] = self.version.to_s el1['changeset'] = self.changeset_id.to_s - self.old_members.each do |member| - e = XML::Node.new 'member' - e['type'] = member.member_type.to_s.downcase - e['ref'] = member.member_id.to_s # "id" is considered uncool here as it should be unique in XML - e['role'] = member.member_role.to_s - el1 << e + if self.redacted? + el1['redacted'] = self.redaction.id.to_s end + + unless self.redacted? and (@user.nil? or not @user.moderator?) + self.old_members.each do |member| + e = XML::Node.new 'member' + e['type'] = member.member_type.to_s.downcase + e['ref'] = member.member_id.to_s # "id" is considered uncool here as it should be unique in XML + e['role'] = member.member_role.to_s + el1 << e + end - self.old_tags.each do |tag| - e = XML::Node.new 'tag' - e['k'] = tag.k - e['v'] = tag.v - el1 << e + self.old_tags.each do |tag| + e = XML::Node.new 'tag' + e['k'] = tag.k + e['v'] = tag.v + el1 << e + end end + return el1 end diff --git a/app/models/old_way.rb b/app/models/old_way.rb index ec4bb5136..e99f6cf28 100644 --- a/app/models/old_way.rb +++ b/app/models/old_way.rb @@ -105,7 +105,7 @@ class OldWay < ActiveRecord::Base el1['changeset'] = self.changeset.id.to_s if self.redacted? - el1['redacted'] = self.redaction.title + el1['redacted'] = self.redaction.id.to_s end unless self.redacted? and (@user.nil? or not @user.moderator?) -- 2.45.1