Fix style issues found by new rubocop version

[chef.git] / cookbooks / nominatim / recipes / default.rb

diff --git a/cookbooks/nominatim/recipes/default.rb b/cookbooks/nominatim/recipes/default.rb
index 3490d91e1c5fdc46dcc779958de457543f116ebe..e8ca87f9c242526ebadf0bf0138dc069f809dc3c 100644 (file)
--- a/cookbooks/nominatim/recipes/default.rb
+++ b/cookbooks/nominatim/recipes/default.rb
@@ -29,29 +29,22 @@ package "php-pear"
 package "php-apc"
 
 apache_module "rewrite"
-
-if node[:lsb][:release].to_f >= 14.04
-  apache_module "proxy"
-  apache_module "proxy_fcgi"
-else
-  apache_module "fastcgi-handler"
-end
+apache_module "proxy"
+apache_module "proxy_fcgi"
 
 home_directory = data_bag_item("accounts", "nominatim")["home"]
 source_directory = "#{home_directory}/nominatim"
 email_errors = data_bag_item("accounts", "lonvia")["email"]
 
 database_cluster = node[:nominatim][:database][:cluster]
-database_version = database_cluster.sub(/\/.*/, "")
+database_version = database_cluster.sub(%r{/.*}, "")
 database_name = node[:nominatim][:database][:dbname]
 
 postgis_version = node[:nominatim][:database][:postgis]
 
 service "php5-fpm" do
-  if node[:lsb][:release].to_f >= 14.04
-    provider Chef::Provider::Service::Upstart
-  end
-  action [ :enable, :start ]
+  provider Chef::Provider::Service::Upstart
+  action [:enable, :start]
   supports :status => true, :restart => true, :reload => true
 end
 
@@ -62,10 +55,10 @@ apache_site "nominatim.openstreetmap.org" do
 end
 
 apache_site "default" do
-  action [ :disable ]
+  action [:disable]
 end
 
-node[:nominatim][:fpm_pools].each do |name,data|
+node[:nominatim][:fpm_pools].each do |name, data|
   template "/etc/php5/fpm/pool.d/#{name}.conf" do
     source "fpm.conf.erb"
     owner "root"
@@ -118,7 +111,6 @@ template "/etc/logrotate.d/nominatim" do
   mode 0644
 end
 
-
 package "osmosis"
 package "gcc"
 package "proj-bin"
@@ -137,10 +129,14 @@ package "libproj-dev"
 package "libprotobuf-c0-dev"
 package "protobuf-c-compiler"
 package "python-psycopg2"
+package "libboost-dev"
+package "libboost-system-dev"
+package "libboost-filesystem-dev"
+package "libboost-thread-dev"
 
 execute "php-pear-db" do
   command "pear install DB"
-  not_if { File.exists?("/usr/share/php/DB") }
+  not_if { File.exist?("/usr/share/php/DB") }
 end
 
 execute "compile_nominatim" do
@@ -164,12 +160,11 @@ directory "#{source_directory}/log" do
   mode 0755
 end
 
-
 template "#{source_directory}/.git/hooks/post-merge" do
   source "update_source.erb"
-  owner  "nominatim"
-  group  "nominatim"
-  mode   0755
+  owner "nominatim"
+  group "nominatim"
+  mode 0755
   variables :source_directory => source_directory
 end
 
@@ -218,19 +213,18 @@ template "/etc/cron.d/nominatim" do
   variables :bin_directory => "#{source_directory}/utils", :mailto => email_errors
 end
 
-
 template "#{source_directory}/utils/nominatim-update" do
   source "updater.erb"
-  user   "nominatim"
-  group  "nominatim"
-  mode   0755
+  user "nominatim"
+  group "nominatim"
+  mode 0755
 end
 
 template "/etc/init.d/nominatim-update" do
   source "updater.init.erb"
-  user   "nominatim"
-  group  "nominatim"
-  mode   0755
+  user "nominatim"
+  group "nominatim"
+  mode 0755
   variables :source_directory => source_directory
 end
 
@@ -257,25 +251,25 @@ end
 remote_file "#{source_directory}/data/wikipedia_article.sql.bin" do
   action :create_if_missing
   source "http://www.nominatim.org/data/wikipedia_article.sql.bin"
-  owner  "nominatim"
-  group  "nominatim"
-  mode   0644
+  owner "nominatim"
+  group "nominatim"
+  mode 0644
 end
 
 remote_file "#{source_directory}/data/wikipedia_redirect.sql.bin" do
   action :create_if_missing
   source "http://www.nominatim.org/data/wikipedia_redirect.sql.bin"
-  owner  "nominatim"
-  group  "nominatim"
-  mode   0644
+  owner "nominatim"
+  group "nominatim"
+  mode 0644
 end
 
 remote_file "#{source_directory}/data/gb_postcode_data.sql.gz" do
   action :create_if_missing
   source "http://www.nominatim.org/data/gb_postcode_data.sql.gz"
-  owner  "nominatim"
-  group  "nominatim"
-  mode   0644
+  owner "nominatim"
+  group "nominatim"
+  mode 0644
 end
 
 template "/usr/local/bin/backup-nominatim" do
@@ -291,4 +285,3 @@ directory File.dirname(node[:nominatim][:flatnode_file]) do
   mode 0755
   recursive true
 end
-