Modernise some older systemd services

[chef.git] / cookbooks / squid / recipes / default.rb

diff --git a/cookbooks/squid/recipes/default.rb b/cookbooks/squid/recipes/default.rb
index d1b2f71f81f41d23c74d7972d9d77211f2afe540..731cbdd83c0f408a7e8f973528ad7a23ad6031b4 100644 (file)
--- a/cookbooks/squid/recipes/default.rb
+++ b/cookbooks/squid/recipes/default.rb
@@ -40,38 +40,40 @@ directory "/etc/squid/squid.conf.d" do
   mode 0o755
 end
 
-if node[:lsb][:release].to_f >= 15.10
-  systemd_service "squid" do
-    description "Squid caching proxy"
-    after ["network.target", "nss-lookup.target"]
-    limit_nofile 65536
-    environment "SQUID_ARGS" => "-D"
-    environment_file "/etc/default/squid"
-    exec_start_pre "/usr/sbin/squid $SQUID_ARGS -z"
-    exec_start "/usr/sbin/squid -N $SQUID_ARGS"
-    exec_reload "/usr/sbin/squid -k reconfigure"
-    exec_stop "/usr/sbin/squid -k shutdown"
-    restart "on-failure"
-    timeout_sec 0
-  end
+systemd_service "squid" do
+  description "Squid caching proxy"
+  after ["network.target", "nss-lookup.target"]
+  limit_nofile 65536
+  environment "SQUID_ARGS" => "-D"
+  environment_file "/etc/default/squid"
+  exec_start_pre "/usr/sbin/squid $SQUID_ARGS -z"
+  exec_start "/usr/sbin/squid -N $SQUID_ARGS"
+  exec_reload "/usr/sbin/squid -k reconfigure"
+  exec_stop "/usr/sbin/squid -k shutdown"
+  private_tmp true
+  private_devices true
+  protect_system "full"
+  protect_home true
+  no_new_privileges true
+  restart "on-failure"
+  timeout_sec 0
+end
 
-  service "squid" do
-    provider Chef::Provider::Service::Systemd
-    action [:enable, :start]
-    supports :status => true, :restart => true, :reload => true
-    subscribes :restart, "systemd_service[squid]"
-    subscribes :reload, "template[/etc/squid/squid.conf]"
-    subscribes :restart, "template[/etc/default/squid]"
-    subscribes :reload, "template[/etc/resolv.conf]"
-  end
-else
-  service "squid" do
-    provider Chef::Provider::Service::Upstart
-    action [:enable, :start]
-    supports :status => true, :restart => true, :reload => true
-    subscribes :reload, "template[/etc/squid/squid.conf]"
-    subscribes :restart, "template[/etc/default/squid]"
-    subscribes :reload, "template[/etc/resolv.conf]"
+service "squid" do
+  action [:enable, :start]
+  subscribes :restart, "systemd_service[squid]"
+  subscribes :reload, "template[/etc/squid/squid.conf]"
+  subscribes :restart, "template[/etc/default/squid]"
+  subscribes :reload, "template[/etc/resolv.conf]"
+end
+
+log "squid-restart" do
+  message "Restarting squid due to counter wraparound"
+  notifies :restart, "service[squid]"
+  only_if do
+    IO.popen(["squidclient", "--host=127.0.0.1", "--port=80", "mgr:counters"]) do |io|
+      io.each.grep(/^[a-z][a-z_.]+ = -[0-9]+$/).count > 0
+    end
   end
 end