X-Git-Url: https://git.openstreetmap.org/chef.git/blobdiff_plain/4d71f2663048f32430d74b4ce13ad42de80555bb..229bfd4d1ef647515f13b6e8e064a957881f2ca7:/cookbooks/dev/recipes/default.rb

diff --git a/cookbooks/dev/recipes/default.rb b/cookbooks/dev/recipes/default.rb
index d660718e6..62eac34c4 100644
--- a/cookbooks/dev/recipes/default.rb
+++ b/cookbooks/dev/recipes/default.rb
@@ -66,7 +66,7 @@ end
 
 service "php5-fpm" do
   provider Chef::Provider::Service::Upstart
-  action [ :enable, :start ]
+  action [:enable, :start]
   supports :status => true, :restart => true, :reload => true
 end
 
@@ -103,27 +103,28 @@ end
 search(:accounts, "*:*").each do |account|
   name = account["id"]
   details = node[:accounts][:users][name] || {}
-  port = 7000 + account["uid"].to_i
 
-  if ["user","administrator"].include?(details[:status])
-    user_home = details[:home] || account["home"] || "#{node[:accounts][:home]}/#{name.to_s}"
+  next unless %w(user administrator).include?(details[:status])
 
-    if File.directory?("#{user_home}/public_html")
-      template "/etc/php5/fpm/pool.d/#{name}.conf" do
-        source "fpm.conf.erb"
-        owner "root"
-        group "root"
-        mode 0644
-        variables :user => name, :port => port
-        notifies :reload, "service[php5-fpm]"
-      end
+  user_home = details[:home] || account["home"] || "#{node[:accounts][:home]}/#{name}"
 
-      apache_site "#{name}.dev.openstreetmap.org" do
-        template "apache.user.erb"
-        directory "#{user_home}/public_html"
-        variables :user => name, :port => port
-      end
-    end
+  next unless File.directory?("#{user_home}/public_html")
+
+  port = 7000 + account["uid"].to_i
+
+  template "/etc/php5/fpm/pool.d/#{name}.conf" do
+    source "fpm.conf.erb"
+    owner "root"
+    group "root"
+    mode 0644
+    variables :user => name, :port => port
+    notifies :reload, "service[php5-fpm]"
+  end
+
+  apache_site "#{name}.dev.openstreetmap.org" do
+    template "apache.user.erb"
+    directory "#{user_home}/public_html"
+    variables :user => name, :port => port
   end
 end
 
@@ -132,7 +133,8 @@ if node[:postgresql][:clusters][:"9.1/main"]
     cluster "9.3/main"
   end
 
-  node[:dev][:rails].each do |name,details|
+  node[:dev][:rails].each do |name, details|
+    ruby node[:passenger][:ruby_version]
     database_name = details[:database] || "apis_#{name}"
     site_name = "#{name}.apis.dev.openstreetmap.org"
     rails_directory = "/srv/#{name}.apis.dev.openstreetmap.org"
@@ -182,7 +184,7 @@ if node[:postgresql][:clusters][:"9.1/main"]
       end
     else
       apache_site site_name do
-        action [ :delete ]
+        action [:delete]
       end
 
       directory rails_directory do
@@ -220,7 +222,7 @@ if node[:postgresql][:clusters][:"9.1/main"]
     template "apache.apis.erb"
   end
 
-  node[:postgresql][:clusters].each do |name,details|
+  node[:postgresql][:clusters].each_key do |name|
     postgresql_munin name do
       cluster name
       database "ALL"