X-Git-Url: https://git.openstreetmap.org/chef.git/blobdiff_plain/73ec2dea6c1a07b08206ec37e588b8a6795e210b..bba9cc3fa8c80291c9db5188f19cd2030595007a:/hooks/pre-commit diff --git a/hooks/pre-commit b/hooks/pre-commit index 4e45ba7b5..60d665932 100755 --- a/hooks/pre-commit +++ b/hooks/pre-commit @@ -3,7 +3,7 @@ ok = true if IO.popen(["git", "ls-files", "--unmerged"]).read.empty? - need_stash = !IO.popen(%w(git diff)).read.empty? + need_stash = !IO.popen(%w[git diff]).read.empty? system("git", "stash", "save", "--keep-index", "--quiet") if need_stash @@ -12,14 +12,14 @@ if IO.popen(["git", "ls-files", "--unmerged"]).read.empty? end.compact ruby_files = files.select do |file| - file =~ /\.rb$/ || `file --brief --mime-type #{file}` == "text/x-ruby\n" + file =~ /\.rb$/ || (file !~ /\.erb$/ && %x(file --brief --mime-type #{file}) == "text/x-ruby\n") end ok &&= system("bundle", "exec", "rubocop", *ruby_files) unless ruby_files.empty? cookbooks = files.grep(%r{(cookbooks/[^/]+)/}) { Regexp.last_match(1) }.uniq - ok &&= system("bundle", "exec", "foodcritic", "-f", "any", *cookbooks) unless cookbooks.empty? + ok &&= system("bundle", "exec", "foodcritic", *cookbooks) unless cookbooks.empty? system("git", "stash", "pop", "--quiet") if need_stash else