X-Git-Url: https://git.openstreetmap.org/chef.git/blobdiff_plain/96170ed36bbce5a18d67fed0beeb23594809ac62..11478df7a2b9a4d4d95fe0eac06a09eddb83e5fc:/cookbooks/logstash/recipes/default.rb?ds=inline

diff --git a/cookbooks/logstash/recipes/default.rb b/cookbooks/logstash/recipes/default.rb
index 86711fb31..fd758d880 100644
--- a/cookbooks/logstash/recipes/default.rb
+++ b/cookbooks/logstash/recipes/default.rb
@@ -21,14 +21,16 @@ include_recipe "networking"
 
 keys = data_bag_item("logstash", "keys")
 
-package "default-jre-headless"
-package "logstash"
+package %w[
+  default-jre-headless
+  logstash
+]
 
 cookbook_file "/var/lib/logstash/lumberjack.crt" do
   source "lumberjack.crt"
   user "root"
   group "logstash"
-  mode 0644
+  mode 0o644
   notifies :restart, "service[logstash]"
 end
 
@@ -36,7 +38,7 @@ file "/var/lib/logstash/lumberjack.key" do
   content keys["lumberjack"].join("\n")
   user "root"
   group "logstash"
-  mode 0640
+  mode 0o640
   notifies :restart, "service[logstash]"
 end
 
@@ -44,12 +46,12 @@ template "/etc/logstash/conf.d/chef.conf" do
   source "logstash.conf.erb"
   user "root"
   group "root"
-  mode 0644
+  mode 0o644
   notifies :reload, "service[logstash]"
 end
 
 file "/etc/logrotate.d/logstash" do
-  mode 0644
+  mode 0o644
 end
 
 service "logstash" do
@@ -61,12 +63,12 @@ template "/etc/cron.daily/expire-logstash" do
   source "expire.erb"
   owner "root"
   group "root"
-  mode 0755
+  mode 0o755
 end
 
 forwarders = search(:node, "recipes:logstash\\:\\:forwarder") # ~FC010
 
-forwarders.each do |forwarder|
+forwarders.sort_by { |n| n[:fqdn] }.each do |forwarder|
   forwarder.interfaces(:role => :external) do |interface|
     firewall_rule "accept-lumberjack-#{forwarder}" do
       action :accept
@@ -82,7 +84,7 @@ end
 
 gateways = search(:node, "roles:gateway") # ~FC010
 
-gateways.each do |gateway|
+gateways.sort_by { |n| n[:fqdn] }.each do |gateway|
   gateway.interfaces(:role => :external) do |interface|
     firewall_rule "accept-lumberjack-#{gateway}" do
       action :accept