X-Git-Url: https://git.openstreetmap.org/chef.git/blobdiff_plain/c08dfe1bf43b2f97baeb0631323256b1a13e18bf..4c006d46acaae9dfa6d118b6367fe13dff5f53bd:/cookbooks/hardware/attributes/default.rb

diff --git a/cookbooks/hardware/attributes/default.rb b/cookbooks/hardware/attributes/default.rb
index 46b5893a8..fb19506f4 100644
--- a/cookbooks/hardware/attributes/default.rb
+++ b/cookbooks/hardware/attributes/default.rb
@@ -1,39 +1,45 @@
-default[:hardware][:modules] = [ "loop", "lp", "rtc" ]
+default[:hardware][:modules] = if node[:lsb][:release].to_f >= 16.04
+                                 %w[lp]
+                               else
+                                 %w[loop lp rtc]
+                               end
+
+default[:hardware][:grub][:cmdline] = %w[nomodeset]
 default[:hardware][:sensors] = {}
 
-if node[:dmi] and node[:dmi][:system]
-  case dmi.system.manufacturer
+default[:hardware][:mcelog][:enabled] = true
+
+if node[:dmi] && node[:dmi][:system]
+  case node[:dmi][:system][:manufacturer]
   when "HP"
-    default[:apt][:sources] |= [ "management-component-pack" ]
+    default[:apt][:sources] |= ["management-component-pack"]
 
-    case dmi.system.product_name
-      when "ProLiant DL360 G6", "ProLiant DL360 G7"
-        default[:hardware][:sensors]["power_meter-*"][:power]["power1"] = { :ignore => true }
+    case node[:dmi][:system][:product_name]
+    when "ProLiant DL360 G6", "ProLiant DL360 G7"
+      default[:hardware][:sensors][:"power_meter-*"][:power][:power1] = { :ignore => true }
     end
   end
 end
 
-if Chef::Util.compare_versions(node[:kernel][:release], [3, 3]) < 0
-  default[:hardware][:modules] |= [ "microcode" ]
+if Chef::Util.compare_versions(node[:kernel][:release], [3, 3]).negative?
+  default[:hardware][:modules] |= ["microcode"]
 
-  if node[:cpu]["0"][:vendor_id] == "GenuineIntel"
-    default[:hardware][:modules] |= [ "coretemp" ]
+  if node[:cpu][:"0"][:vendor_id] == "GenuineIntel"
+    default[:hardware][:modules] |= ["coretemp"]
   end
 end
 
-if node[:kernel] and node[:kernel][:modules]
-  raidmods = node[:kernel][:modules].keys & ["cciss", "hpsa", "mptsas", "mpt2sas", "megaraid_mm", "megaraid_sas", "aacraid"]
+if node[:kernel] && node[:kernel][:modules]
+  raidmods = node[:kernel][:modules].keys & %w[cciss hpsa mptsas mpt2sas mpt3sas megaraid_mm megaraid_sas aacraid]
 
-  unless raidmods.empty?
-    default[:apt][:sources] |= [ "hwraid" ]
-  end
+  default[:apt][:sources] |= ["hwraid"] unless raidmods.empty?
 end
 
 if node[:kernel][:modules].include?("ipmi_si")
-  default[:hardware][:modules] |= [ "ipmi_devintf" ]
+  default[:hardware][:modules] |= ["ipmi_devintf"]
 end
 
-if File.exists?("/proc/xen")
+if File.exist?("/proc/xen")
   default[:hardware][:watchdog] = "xen_wdt"
 elsif node[:kernel][:modules].include?("i6300esb")
   default[:hardware][:watchdog] = "none"