X-Git-Url: https://git.openstreetmap.org/chef.git/blobdiff_plain/faf8ae12e85eabb050b0f5eceb2cb67ad1de5261..3a4d52bd4c0f8e6ae7679145846b7bc7845d8ace:/cookbooks/openvpn/recipes/default.rb diff --git a/cookbooks/openvpn/recipes/default.rb b/cookbooks/openvpn/recipes/default.rb index cbd45ee65..3a0bcccf5 100644 --- a/cookbooks/openvpn/recipes/default.rb +++ b/cookbooks/openvpn/recipes/default.rb @@ -25,9 +25,9 @@ service "openvpn" do ignore_failure true end -node[:openvpn][:tunnels].each do |name,details| +node[:openvpn][:tunnels].each do |name, details| if peer = search(:node, "fqdn:#{details[:peer][:host]}").first - if peer[:openvpn] and not details[:peer][:address] + if peer[:openvpn] && !details[:peer][:address] node.default[:openvpn][:tunnels][name][:peer][:address] = peer[:openvpn][:address] end @@ -46,10 +46,10 @@ node[:openvpn][:tunnels].each do |name,details| creates "/etc/openvpn/#{name}.key" end - if File.exists?("/etc/openvpn/#{name}.key") + if File.exist?("/etc/openvpn/#{name}.key") node.set[:openvpn][:keys][name] = IO.read("/etc/openvpn/#{name}.key") end - elsif peer and peer[:openvpn] + elsif peer && peer[:openvpn] file "/etc/openvpn/#{name}.key" do owner "root" group "root" @@ -65,11 +65,11 @@ node[:openvpn][:tunnels].each do |name,details| group "root" mode 0644 variables :name => name, - :address => node[:openvpn][:address], - :port => node[:openvpn][:tunnels][name][:port], - :mode => node[:openvpn][:tunnels][name][:mode], - :peer => node[:openvpn][:tunnels][name][:peer] - notifies :restart, resources(:service => "openvpn") + :address => node[:openvpn][:address], + :port => node[:openvpn][:tunnels][name][:port], + :mode => node[:openvpn][:tunnels][name][:mode], + :peer => node[:openvpn][:tunnels][name][:peer] + notifies :restart, "service[openvpn]" end else file "/etc/openvpn/#{name}.conf" do