From: Tom Hughes <tom@compton.nu>
Date: Fri, 15 May 2015 18:53:31 +0000 (+0100)
Subject: Don't do munin monitoring for disks behind an Areca controller
X-Git-Url: https://git.openstreetmap.org/chef.git/commitdiff_plain/009bb6625414a6c93deb7c65a5764d23bb02598d

Don't do munin monitoring for disks behind an Areca controller

Areca controllers only seem to be able to talk SMART to one thing
at a time, and if munin and smartd both happen to try and talk to
it at the same time one or the other will report errors.
---

diff --git a/cookbooks/hardware/recipes/default.rb b/cookbooks/hardware/recipes/default.rb
index 3169c94a9..6a324a36e 100644
--- a/cookbooks/hardware/recipes/default.rb
+++ b/cookbooks/hardware/recipes/default.rb
@@ -411,6 +411,12 @@ if disks.count > 0
     supports :status => true, :restart => true, :reload => true
   end
 
+  # Don't try and do munin monitoring of disks behind
+  # an Areca controller as they only allow one thing to
+  # talk to the controller at a time and smartd will
+  # throw errors if it clashes with munin
+  disks = disks.reject { |disk| disk[:driver] == "areca" }
+
   disks.each do |disk|
     munin_plugin "smart_#{disk[:munin]}" do
       target "smart_"