From: Matt Amos <zerebubuth@gmail.com>
Date: Sun, 21 Dec 2014 18:10:53 +0000 (+0000)
Subject: Extracted all references to planet dump output locations to attributes
X-Git-Url: https://git.openstreetmap.org/chef.git/commitdiff_plain/063bfb7e0473de34b947b867d4d0c490540b4fc9?ds=sidebyside

Extracted all references to planet dump output locations to attributes
---

diff --git a/cookbooks/planet/attributes/default.rb b/cookbooks/planet/attributes/default.rb
new file mode 100644
index 000000000..649d9b399
--- /dev/null
+++ b/cookbooks/planet/attributes/default.rb
@@ -0,0 +1,4 @@
+default[:planet][:dump][:xml_directory] = "/store/planet/planet"
+default[:planet][:dump][:xml_history_directory] = "/store/planet/planet/full-history"
+default[:planet][:dump][:pbf_directory] = "/store/planet/pbf"
+default[:planet][:dump][:pbf_history_directory] = "/store/planet/pbf/full-history"
diff --git a/cookbooks/planet/recipes/default.rb b/cookbooks/planet/recipes/default.rb
index 706e766e8..51470380d 100644
--- a/cookbooks/planet/recipes/default.rb
+++ b/cookbooks/planet/recipes/default.rb
@@ -61,16 +61,13 @@ remote_directory "/store/planet" do
   files_mode 0755
 end
 
-directory "/store/planet/planet" do
-  owner "www-data"
-  group "planet"
-  mode 0775
-end
-
-directory "/store/planet/pbf" do
-  owner "www-data"
-  group "planet"
-  mode 0775
+[:xml_directory, :xml_history_directory,
+ :pbf_directory, :pbf_history_directory].each do |dir|
+  directory dir do
+    owner "www-data"
+    group "planet"
+    mode 0775
+  end
 end
 
 directory "/store/planet/notes" do
diff --git a/cookbooks/planet/recipes/dump.rb b/cookbooks/planet/recipes/dump.rb
index bc0214da5..1425fbec3 100644
--- a/cookbooks/planet/recipes/dump.rb
+++ b/cookbooks/planet/recipes/dump.rb
@@ -89,9 +89,11 @@ directory "/store/planetdump" do
   mode 0755
 end
 
-template "/usr/local/bin/planetdump" do
-  source "planetdump.erb"
-  owner "root"
-  group "root"
-  mode 0755
+["planetdump", "planet-mirror-redirect-update", "apache-latest-planet-filename"].each do |program|
+  template "/usr/local/bin/#{program}" do
+    source "#{program}.erb"
+    owner "root"
+    group "root"
+    mode 0755
+  end
 end
diff --git a/cookbooks/planet/files/default/bin/apache-latest-planet-filename b/cookbooks/planet/templates/default/apache-latest-planet-filename.erb
similarity index 64%
rename from cookbooks/planet/files/default/bin/apache-latest-planet-filename
rename to cookbooks/planet/templates/default/apache-latest-planet-filename.erb
index e5e35819a..d7c8695c7 100644
--- a/cookbooks/planet/files/default/bin/apache-latest-planet-filename
+++ b/cookbooks/planet/templates/default/apache-latest-planet-filename.erb
@@ -4,7 +4,7 @@
 
 $| = 1;
 while (<STDIN>) {
-	my $where = readlink("/store/planet/planet/planet-latest.osm.bz2");
+	my $where = readlink("<%= node[:planet][:dump][:xml_directory] %>/planet-latest.osm.bz2");
 	s/planet\/planet\-latest\.osm\.bz2/planet\/$where/g;
 	print $_;
 }
diff --git a/cookbooks/planet/files/default/bin/planet-mirror-redirect-update b/cookbooks/planet/templates/default/planet-mirror-redirect-update.erb
similarity index 96%
rename from cookbooks/planet/files/default/bin/planet-mirror-redirect-update
rename to cookbooks/planet/templates/default/planet-mirror-redirect-update.erb
index 6d772ec2b..1f37ecd23 100644
--- a/cookbooks/planet/files/default/bin/planet-mirror-redirect-update
+++ b/cookbooks/planet/templates/default/planet-mirror-redirect-update.erb
@@ -8,7 +8,7 @@
 	Modifies .htaccess
 */
 $_YEAR = date('Y');
-$_PLANET_FOLDER = '/store/planet/planet/'.$_YEAR.'/';
+$_PLANET_FOLDER = '<%= node[:planet][:dump][:xml_directory] %>/'.$_YEAR.'/';
 $_PLANET_REGEX = "/^(planet|changesets)\-\d{6}(\-nolt)?\.osm\.(bz2|gz)$/";
 $_MIRROR = 'http://ftp.heanet.ie/mirrors/openstreetmap.org/planet/'.$_YEAR.'/';
 $_PLANET_HTACCESS = $_PLANET_FOLDER.'../../.htaccess';
diff --git a/cookbooks/planet/templates/default/planetdump.erb b/cookbooks/planet/templates/default/planetdump.erb
index 4d5bac02c..a8fd4aa9f 100644
--- a/cookbooks/planet/templates/default/planetdump.erb
+++ b/cookbooks/planet/templates/default/planetdump.erb
@@ -1,4 +1,5 @@
 #!/bin/bash
+# DO NOT EDIT - This file is being maintained by Chef
 
 # Exit on error
 set -e
@@ -52,15 +53,14 @@ time nice -n 19 /store/planet-dump-ng/planet-dump-ng \
      -p "planet-${date}.osm.pbf" -P "history-${date}.osm.pbf"
 
 # Move XML dumps into place
-for file in "changesets-${date}.osm.bz2" "planet-${date}.osm.bz2" "history-${date}.osm.bz2"
-do
-    md5sum "#{file}" > "#{file}.md5"
-    mv "${file}" "${file}.md5" "/store/planet/planet"
-done
-
-# Move PBF dumps into place
-for file in "planet-${date}.osm.pbf" "history-${date}.osm.pbf"
-do
-    md5sum "#{file}" > "#{file}.md5"
-    mv "${file}" "${file}.md5" "/store/planet/pbf"
-done
+year = `echo ${date} | sed "s/.*-\([0-9]\)\{4\}-.*/\1/"`
+<% {
+	 "changesets-${date}.osm.bz2" => "#{node[:planet][:dump][:xml_directory]}/${year}",
+	 "planet-${date}.osm.bz2" => "#{node[:planet][:dump][:xml_directory]}/${year}",
+	 "history-${date}.osm.bz2" => "#{node[:planet][:dump][:xml_history_directory]}/${year}",
+	 "planet-${date}.osm.pbf" => node[:planet][:dump][:pbf_directory],
+	 "history-${date}.osm.pbf" => node[:planet][:dump][:pbf_history_directory]
+}.each do |file,dir| %>
+md5sum "<%= file %>" > "<%= file %>.md5"
+mv "<%= file %>" "<%= file %>.md5" "<%= dir %>"
+<% end %>