From: Tom Hughes <tom@compton.nu>
Date: Wed, 19 Feb 2020 21:46:32 +0000 (+0000)
Subject: Fetch cookstyle warnings
X-Git-Url: https://git.openstreetmap.org/chef.git/commitdiff_plain/7c4174b2f08a5c142f6c4b8eedfe69a3586b9df7

Fetch cookstyle warnings
---

diff --git a/cookbooks/accounts/recipes/default.rb b/cookbooks/accounts/recipes/default.rb
index 250ca9e41..fa7dc2814 100644
--- a/cookbooks/accounts/recipes/default.rb
+++ b/cookbooks/accounts/recipes/default.rb
@@ -69,13 +69,11 @@ search(:accounts, "*:*").each do |account|
       files_group name.to_s
       files_mode 0o644
       only_if do
-        begin
-          cookbook = run_context.cookbook_collection[cookbook_name]
-          files = cookbook.relative_filenames_in_preferred_directory(node, :files, name.to_s)
-          !files.empty?
-        rescue Chef::Exceptions::FileNotFound
-          false
-        end
+        cookbook = run_context.cookbook_collection[cookbook_name]
+        files = cookbook.relative_filenames_in_preferred_directory(node, :files, name.to_s)
+        !files.empty?
+      rescue Chef::Exceptions::FileNotFound
+        false
       end
     end