From: Tom Hughes <tom@compton.nu>
Date: Thu, 21 Mar 2019 18:06:30 +0000 (+0000)
Subject: Remove support for ifupdown based networking
X-Git-Url: https://git.openstreetmap.org/chef.git/commitdiff_plain/ee8a123dd9ad0fcb3341d7a285edcd46cad224f5

Remove support for ifupdown based networking
---

diff --git a/cookbooks/networking/attributes/default.rb b/cookbooks/networking/attributes/default.rb
index 7dcafe607..f7db87730 100644
--- a/cookbooks/networking/attributes/default.rb
+++ b/cookbooks/networking/attributes/default.rb
@@ -9,4 +9,3 @@ default[:networking][:firewall][:mangle] = true
 default[:networking][:interfaces] = {}
 default[:networking][:nameservers] = []
 default[:networking][:search] = []
-default[:networking][:netplan] = true
diff --git a/cookbooks/networking/recipes/default.rb b/cookbooks/networking/recipes/default.rb
index 45de97872..a308e535d 100644
--- a/cookbooks/networking/recipes/default.rb
+++ b/cookbooks/networking/recipes/default.rb
@@ -23,8 +23,6 @@
 require "ipaddr"
 require "yaml"
 
-network_packages = []
-
 netplan = {
   "network" => {
     "version" => 2,
@@ -37,9 +35,6 @@ netplan = {
 
 node[:networking][:interfaces].each do |name, interface|
   if interface[:interface]
-    network_packages |= ["vlan"] if interface[:interface] =~ /\.\d+$/
-    network_packages |= ["ifenslave"] if interface[:bond]
-
     if interface[:role] && (role = node[:networking][:roles][interface[:role]])
       if role[interface[:family]]
         node.normal[:networking][:interfaces][name][:prefix] = role[interface[:family]][:prefix]
@@ -55,74 +50,72 @@ node[:networking][:interfaces].each do |name, interface|
     node.normal[:networking][:interfaces][name][:netmask] = (~IPAddr.new(interface[:address]).mask(0)).mask(prefix)
     node.normal[:networking][:interfaces][name][:network] = IPAddr.new(interface[:address]).mask(prefix)
 
-    if node[:networking][:netplan]
-      deviceplan = if interface[:interface] =~ /^(.*)\.(\d+)$/
-                     netplan["network"]["vlans"][interface[:interface]] ||= {
-                       "id" => Regexp.last_match(2).to_i,
-                       "link" => Regexp.last_match(1),
-                       "accept-ra" => false,
-                       "addresses" => [],
-                       "routes" => []
-                     }
-                   elsif interface[:interface] =~ /^bond\d+$/
-                     netplan["network"]["bonds"][interface[:interface]] ||= {
-                       "accept-ra" => false,
-                       "addresses" => [],
-                       "routes" => []
-                     }
-                   else
-                     netplan["network"]["ethernets"][interface[:interface]] ||= {
-                       "accept-ra" => false,
-                       "addresses" => [],
-                       "routes" => []
-                     }
-                   end
-
-      deviceplan["addresses"].push("#{interface[:address]}/#{prefix}")
-
-      if interface[:bond]
-        deviceplan["interfaces"] = interface[:bond][:slaves].to_a
-
-        deviceplan["parameters"] = {
-          "mode" => interface[:bond][:mode] || "active-backup",
-          "primary" => interface[:bond][:slaves].first,
-          "mii-monitor-interval" => interface[:bond][:miimon] || 100,
-          "down-delay" => interface[:bond][:downdelay] || 200,
-          "up-delay" => interface[:bond][:updelay] || 200
-        }
-
-        deviceplan["parameters"]["transmit-hash-policy"] = interface[:bond][:xmithashpolicy] if interface[:bond][:xmithashpolicy]
-        deviceplan["parameters"]["lacp-rate"] = interface[:bond][:lacprate] if interface[:bond][:lacprate]
-      end
+    deviceplan = if interface[:interface] =~ /^(.*)\.(\d+)$/
+                   netplan["network"]["vlans"][interface[:interface]] ||= {
+                     "id" => Regexp.last_match(2).to_i,
+                     "link" => Regexp.last_match(1),
+                     "accept-ra" => false,
+                     "addresses" => [],
+                     "routes" => []
+                   }
+                 elsif interface[:interface] =~ /^bond\d+$/
+                   netplan["network"]["bonds"][interface[:interface]] ||= {
+                     "accept-ra" => false,
+                     "addresses" => [],
+                     "routes" => []
+                   }
+                 else
+                   netplan["network"]["ethernets"][interface[:interface]] ||= {
+                     "accept-ra" => false,
+                     "addresses" => [],
+                     "routes" => []
+                   }
+                 end
+
+    deviceplan["addresses"].push("#{interface[:address]}/#{prefix}")
+
+    if interface[:bond]
+      deviceplan["interfaces"] = interface[:bond][:slaves].to_a
+
+      deviceplan["parameters"] = {
+        "mode" => interface[:bond][:mode] || "active-backup",
+        "primary" => interface[:bond][:slaves].first,
+        "mii-monitor-interval" => interface[:bond][:miimon] || 100,
+        "down-delay" => interface[:bond][:downdelay] || 200,
+        "up-delay" => interface[:bond][:updelay] || 200
+      }
+
+      deviceplan["parameters"]["transmit-hash-policy"] = interface[:bond][:xmithashpolicy] if interface[:bond][:xmithashpolicy]
+      deviceplan["parameters"]["lacp-rate"] = interface[:bond][:lacprate] if interface[:bond][:lacprate]
+    end
 
-      if interface[:gateway]
-        if interface[:family] == "inet"
-          default_route = "0.0.0.0/0"
-        elsif interface[:family] == "inet6"
-          default_route = "::/0"
-        end
+    if interface[:gateway]
+      if interface[:family] == "inet"
+        default_route = "0.0.0.0/0"
+      elsif interface[:family] == "inet6"
+        default_route = "::/0"
+      end
 
+      deviceplan["routes"].push(
+        "to" => default_route,
+        "via" => interface[:gateway],
+        "metric" => interface[:metric],
+        "on-link" => true
+      )
+
+      # This ordering relies on systemd-networkd adding routes
+      # in reverse order and will need moving before the previous
+      # route once that is fixed:
+      #
+      # https://github.com/systemd/systemd/issues/5430
+      # https://github.com/systemd/systemd/pull/10938
+      if interface[:family] == "inet6" &&
+         !interface[:network].include?(interface[:gateway]) &&
+         !IPAddr.new("fe80::/64").include?(interface[:gateway])
         deviceplan["routes"].push(
-          "to" => default_route,
-          "via" => interface[:gateway],
-          "metric" => interface[:metric],
-          "on-link" => true
+          "to" => interface[:gateway],
+          "scope" => "link"
         )
-
-        # This ordering relies on systemd-networkd adding routes
-        # in reverse order and will need moving before the previous
-        # route once that is fixed:
-        #
-        # https://github.com/systemd/systemd/issues/5430
-        # https://github.com/systemd/systemd/pull/10938
-        if interface[:family] == "inet6" &&
-           !interface[:network].include?(interface[:gateway]) &&
-           !IPAddr.new("fe80::/64").include?(interface[:gateway])
-          deviceplan["routes"].push(
-            "to" => interface[:gateway],
-            "scope" => "link"
-          )
-        end
       end
     end
   else
@@ -130,64 +123,35 @@ node[:networking][:interfaces].each do |name, interface|
   end
 end
 
-if node[:networking][:netplan]
-  package "netplan.io"
-
-  file "/etc/netplan/01-netcfg.yaml" do
-    action :delete
-  end
-
-  file "/etc/netplan/50-cloud-init.yaml" do
-    action :delete
-  end
-
-  netplan["network"]["bonds"].each_value do |bond|
-    bond["interfaces"].each do |interface|
-      netplan["network"]["ethernets"][interface] ||= { "accept-ra" => false }
-    end
-  end
-
-  netplan["network"]["vlans"].each_value do |vlan|
-    unless vlan["link"] =~ /^bond\d+$/
-      netplan["network"]["ethernets"][vlan["link"]] ||= { "accept-ra" => false }
-    end
-  end
-
-  file "/etc/netplan/99-chef.yaml" do
-    owner "root"
-    group "root"
-    mode 0o644
-    content YAML.dump(netplan)
-  end
-
-  service "networking" do
-    action :disable
+netplan["network"]["bonds"].each_value do |bond|
+  bond["interfaces"].each do |interface|
+    netplan["network"]["ethernets"][interface] ||= { "accept-ra" => false }
   end
+end
 
-  file "/etc/network/interfaces" do
-    action :delete
+netplan["network"]["vlans"].each_value do |vlan|
+  unless vlan["link"] =~ /^bond\d+$/
+    netplan["network"]["ethernets"][vlan["link"]] ||= { "accept-ra" => false }
   end
+end
 
-  package "ifupdown" do
-    action :purge
-  end
+file "/etc/netplan/01-netcfg.yaml" do
+  action :delete
+end
 
-  file "/etc/cloud/cloud.cfg.d/99-chef.cfg" do
-    action :delete
-  end
+file "/etc/netplan/50-cloud-init.yaml" do
+  action :delete
+end
 
-  package "cloud-init" do
-    action :purge
-  end
-else
-  package network_packages
+file "/etc/netplan/99-chef.yaml" do
+  owner "root"
+  group "root"
+  mode 0o644
+  content YAML.dump(netplan)
+end
 
-  template "/etc/network/interfaces" do
-    source "interfaces.erb"
-    owner "root"
-    group "root"
-    mode 0o644
-  end
+package "cloud-init" do
+  action :purge
 end
 
 execute "hostname" do
diff --git a/cookbooks/networking/templates/default/interfaces.erb b/cookbooks/networking/templates/default/interfaces.erb
deleted file mode 100644
index 1e547b38b..000000000
--- a/cookbooks/networking/templates/default/interfaces.erb
+++ /dev/null
@@ -1,60 +0,0 @@
-# DO NOT EDIT - This file is being maintained by Chef
-
-iface lo inet loopback
-<% node[:networking][:interfaces].each do |name,interface| -%>
-<% if interface[:interface] -%>
-<% if interface[:bond] -%>
-<% interface[:bond][:slaves].each do |slave| -%>
-
-iface <%= slave %> inet manual
-      bond-master <%= interface[:interface] %>
-<% end -%>
-
-auto <%= interface[:bond][:slaves].sort.uniq.join(" ") %>
-<% end -%>
-
-iface <%= interface[:interface] %> <%= interface[:family] %> static
-<% if interface[:interface] =~ /\.\d+$/ -%>
-      vlan-raw-device <%= interface[:interface].split(".").first %>
-<% end -%>
-      address <%= interface[:address] %>
-<% if interface[:family] == "inet" -%>
-      netmask <%= interface[:netmask] %>
-<% elsif interface[:family] == "inet6" -%>
-      netmask <%= interface[:prefix] %>
-<% end -%>
-<% if interface[:hwaddress] -%>
-      hwaddress <%= interface[:hwaddress] %>
-<% end -%>
-<% if interface[:gateway] -%>
-<% if interface[:network].include?(interface[:gateway]) or IPAddr.new("fe80::/64").include?(interface[:gateway]) -%>
-      gateway <%= interface[:gateway] %>
-      metric <%= interface[:metric] %>
-<% else -%>
-      post-up /sbin/ip -f <%= interface[:family] %> route add <%= interface[:gateway] %> dev <%= interface[:interface] %>
-      post-up /sbin/ip -f <%= interface[:family] %> route add default metric <%= interface[:metric] %> via <%= interface[:gateway] %>
-      pre-down /sbin/ip -f <%= interface[:family] %> route del default metric <%= interface[:metric] %> via <%= interface[:gateway] %>
-      pre-down /sbin/ip -f <%= interface[:family] %> route del <%= interface[:gateway] %> dev <%= interface[:interface] %>
-<% end -%>
-<% end -%>
-<% if interface[:family] == "inet6" -%>
-      autoconf 0
-<% end -%>
-<% if interface[:bond] -%>
-      bond-mode <%= interface[:bond][:mode] || "active-backup" %>
-      bond-slaves none
-      bond-primary <%= interface[:bond][:slaves].first %>
-      bond-miimon <%= interface[:bond][:miimon] || 100 %>
-<% if interface[:bond][:xmithashpolicy] -%>
-      bond_xmit_hash_policy <%= interface[:bond][:xmithashpolicy] %>
-<% end -%>
-<% if interface[:bond][:lacprate] -%>
-      bond-lacp-rate <%= interface[:bond][:lacprate] %>
-<% end -%>
-      bond-downdelay <%= interface[:bond][:downdelay] || 200 %>
-      bond-updelay <%= interface[:bond][:updelay] || 200 %>
-<% end -%>
-<% end -%>
-<% end -%>
-
-auto lo <%= node[:networking][:interfaces].collect { |n,i| i[:interface] }.compact.sort.uniq.join(" ") %>