From 2f0b6f10a1269e4a0a3ae8897d6fda10dd14fb4d Mon Sep 17 00:00:00 2001
From: Tigerfell <tigerfell-688@tuta.io>
Date: Tue, 9 Mar 2021 21:54:19 +0100
Subject: [PATCH] split configuration in two, include new templates

---
 .../templates/default/LocalSettings.php.erb        | 11 -----------
 cookbooks/wiki/recipes/default.rb                  | 14 ++++++++++++++
 .../templates/default/after_extensions.php.erb     | 14 ++++++++++++++
 ...lSettings.php.erb => before_extensions.php.erb} |  5 +++++
 4 files changed, 33 insertions(+), 11 deletions(-)
 create mode 100644 cookbooks/wiki/templates/default/after_extensions.php.erb
 rename cookbooks/wiki/templates/default/{LocalSettings.php.erb => before_extensions.php.erb} (92%)

diff --git a/cookbooks/mediawiki/templates/default/LocalSettings.php.erb b/cookbooks/mediawiki/templates/default/LocalSettings.php.erb
index f3c127e5a..035ae0acc 100644
--- a/cookbooks/mediawiki/templates/default/LocalSettings.php.erb
+++ b/cookbooks/mediawiki/templates/default/LocalSettings.php.erb
@@ -230,13 +230,6 @@ $wgGroupPermissions['*']['createaccount'] = false;
 $wgUploadPath = "$wgScriptPath/img_auth.php";
 <% end -%>
 
-<% if not(@mediawiki[:private_accounts]) and not(@mediawiki[:private_site]) -%>
-# user group "confirmed" with identical rights as "autoconfirmed", but assigned manually by sysops
-$wgGroupPermissions['confirmed'] = $wgGroupPermissions['autoconfirmed'];
-$wgAddGroups['sysop'][] = 'confirmed';
-$wgRemoveGroups['sysop'][] = 'confirmed';
-<% end -%>
-
 # Allow Subpages on Main Namespace
 $wgNamespacesWithSubpages[NS_MAIN] = true;
 
@@ -273,10 +266,6 @@ $wgAllowExternalImagesFrom = array( 'http://tile.openstreetmap.org/', 'https://t
 
 $wgNoFollowDomainExceptions = array( 'www.openstreetmap.org', 'josm.openstreetmap.de', 'taginfo.openstreetmap.org', 'blog.openstreetmap.org', 'wiki.osmfoundation.org' );
 
-# FIXME - move to specific
-# defines which links of the sidebar are translatable 
-$wgForceUIMsgAsContentMsg = array( 'mainpage-url', 'mapfeatures-url', 'contributors-url', 'helppage', 'blogs-url', 'shop-url', 'sitesupport-url' );
-
 # FIXME - move to specific
 $wgAllowUserJs = TRUE;
 $wgAllowUserCss = TRUE;
diff --git a/cookbooks/wiki/recipes/default.rb b/cookbooks/wiki/recipes/default.rb
index 72af19cb8..04b7c74c6 100644
--- a/cookbooks/wiki/recipes/default.rb
+++ b/cookbooks/wiki/recipes/default.rb
@@ -60,6 +60,13 @@ mediawiki_site "wiki.openstreetmap.org" do
   # site_readonly "MAINTENANCE: WIKI READ-ONLY UNTIL Monday 16 May 2016 - 11:00am UTC/GMT."
 end
 
+template "/srv/wiki.openstreetmap.org/00_before_extensions.php" do
+  source "before_extensions.php.erb"
+  owner node[:mediawiki][:user]
+  group node[:mediawiki][:group]
+  mode "600"
+end
+
 mediawiki_extension "CodeEditor" do
   site "wiki.openstreetmap.org"
 end
@@ -134,6 +141,13 @@ directory "/srv/wiki.openstreetmap.org/dump" do
   mode "0775"
 end
 
+template "/srv/wiki.openstreetmap.org/99_after_extensions.php" do
+  source "after_extensions.php.erb"
+  owner node[:mediawiki][:user]
+  group node[:mediawiki][:group]
+  mode "600"
+end
+
 cron_d "wiki-dump" do
   minute "0"
   hour "2"
diff --git a/cookbooks/wiki/templates/default/after_extensions.php.erb b/cookbooks/wiki/templates/default/after_extensions.php.erb
new file mode 100644
index 000000000..190b40772
--- /dev/null
+++ b/cookbooks/wiki/templates/default/after_extensions.php.erb
@@ -0,0 +1,14 @@
+<?php
+# DO NOT EDIT - This file is being maintained by Chef
+
+# Protect against web entry
+if ( !defined( 'MEDIAWIKI' ) ) {
+	exit;
+}
+
+# configuration loaded after the extensions
+
+# user group "confirmed" with identical rights as "autoconfirmed", but assigned manually by sysops
+$wgGroupPermissions['confirmed'] = $wgGroupPermissions['autoconfirmed'];
+$wgAddGroups['sysop'][] = 'confirmed';
+$wgRemoveGroups['sysop'][] = 'confirmed';
diff --git a/cookbooks/wiki/templates/default/LocalSettings.php.erb b/cookbooks/wiki/templates/default/before_extensions.php.erb
similarity index 92%
rename from cookbooks/wiki/templates/default/LocalSettings.php.erb
rename to cookbooks/wiki/templates/default/before_extensions.php.erb
index bcef00d0e..6159c9a04 100644
--- a/cookbooks/wiki/templates/default/LocalSettings.php.erb
+++ b/cookbooks/wiki/templates/default/before_extensions.php.erb
@@ -6,6 +6,8 @@ if ( !defined( 'MEDIAWIKI' ) ) {
 	exit;
 }
 
+# configuration loaded before the extensions
+
 # DE
 define('NS_LANG_DE', 200);
 $wgExtraNamespaces[NS_LANG_DE] = 'DE';
@@ -88,3 +90,6 @@ $wgNamespacesToBeSearchedDefault[NS_LANG_NL] = TRUE;
 $wgNamespacesToBeSearchedDefault[NS_LANG_RU] = TRUE;
 $wgNamespacesToBeSearchedDefault[NS_LANG_JA] = TRUE;
 $wgNamespacesToBeSearchedDefault[NS_PROPOSAL] = TRUE;
+
+# defines which links of the sidebar are translatable 
+$wgForceUIMsgAsContentMsg = array( 'mainpage-url', 'mapfeatures-url', 'contributors-url', 'helppage', 'blogs-url', 'shop-url', 'sitesupport-url' );
-- 
2.43.2