From 8501596c8696a646bbd60ff2ff19a2b864b7e3e8 Mon Sep 17 00:00:00 2001
From: Tom Hughes <tom@compton.nu>
Date: Thu, 27 Oct 2016 18:52:14 +0100
Subject: [PATCH] Add tests for munin::server recipe

---
 .kitchen.yml                                  |  3 +++
 .../munin/templates/default/munin.conf.erb    |  6 ++++++
 .../munin-server/serverspec/apache_spec.rb    | 21 +++++++++++++++++++
 .../munin-server/serverspec/munin_spec.rb     |  8 +++++++
 .../munin-server/serverspec/rrdcached_spec.rb | 13 ++++++++++++
 5 files changed, 51 insertions(+)
 create mode 100644 test/integration/munin-server/serverspec/apache_spec.rb
 create mode 100644 test/integration/munin-server/serverspec/munin_spec.rb
 create mode 100644 test/integration/munin-server/serverspec/rrdcached_spec.rb

diff --git a/.kitchen.yml b/.kitchen.yml
index 12ffa4914..389ab5792 100644
--- a/.kitchen.yml
+++ b/.kitchen.yml
@@ -28,6 +28,9 @@ suites:
   - name: munin
     run_list:
       - recipe[munin::default]
+  - name: munin-server
+    run_list:
+      - recipe[munin::server]
   - name: networking
     run_list:
       - recipe[networking::default]
diff --git a/cookbooks/munin/templates/default/munin.conf.erb b/cookbooks/munin/templates/default/munin.conf.erb
index d5dc7a4b8..ec443ed74 100644
--- a/cookbooks/munin/templates/default/munin.conf.erb
+++ b/cookbooks/munin/templates/default/munin.conf.erb
@@ -89,6 +89,7 @@ unknown_limit 144
 <% end -%>
 <% end -%>
 <% end -%>
+<% unless @frontends.empty? && @backends.empty? -%>
 
 # Configure compound graphs for www.openstreetmap.org
 [www.openstreetmap]
@@ -292,6 +293,8 @@ unknown_limit 144
     memcached_multi_bytes.bytes_written.negative bytes_read
     memcached_multi_bytes.bytes_written.label Traffic in (-) / out (+)
     memcached_multi_bytes.bytes_written.cdef bytes_written,8,*
+<% end -%>
+<% unless @tilecaches.empty? -%>
 
 # Configure compound graphs for tile.openstreetmap.org
 [tile.openstreetmap]
@@ -442,6 +445,8 @@ unknown_limit 144
     squid_byte_hitrates.<%= tc[:name].tr("-", "_") %>_hits.label <%= tc[:name] %>
     squid_byte_hitrates.<%= tc[:name].tr("-", "_") %>_hits.draw LINE1
 <% end -%>
+<% end -%>
+<% unless @renderers.empty? -%>
 
 # Configure compound graphs for render.openstreetmap.org
 [render.openstreetmap]
@@ -702,6 +707,7 @@ unknown_limit 144
     renderd_zoom_time.zoomtime6.cdef zoomtime6,1000,/
     renderd_zoom_time.zoomtime6.draw STACK
     renderd_zoom_time.zoomtime6.info Time for Metatiles for z19 - z20
+<% end -%>
 <% unless @geocoders.empty? -%>
 
 # Configure compound graphs for nominatim.openstreetmap.org
diff --git a/test/integration/munin-server/serverspec/apache_spec.rb b/test/integration/munin-server/serverspec/apache_spec.rb
new file mode 100644
index 000000000..57b0b7d86
--- /dev/null
+++ b/test/integration/munin-server/serverspec/apache_spec.rb
@@ -0,0 +1,21 @@
+require "serverspec"
+
+# Required by serverspec
+set :backend, :exec
+
+describe package("apache2") do
+  it { should be_installed }
+end
+
+describe service("apache2") do
+  it { should be_enabled }
+  it { should be_running }
+end
+
+describe port(80) do
+  it { should be_listening }
+end
+
+describe port(443) do
+  it { should_not be_listening }
+end
diff --git a/test/integration/munin-server/serverspec/munin_spec.rb b/test/integration/munin-server/serverspec/munin_spec.rb
new file mode 100644
index 000000000..eeae1e4a9
--- /dev/null
+++ b/test/integration/munin-server/serverspec/munin_spec.rb
@@ -0,0 +1,8 @@
+require "serverspec"
+
+# Required by serverspec
+set :backend, :exec
+
+describe package("munin") do
+  it { should be_installed }
+end
diff --git a/test/integration/munin-server/serverspec/rrdcached_spec.rb b/test/integration/munin-server/serverspec/rrdcached_spec.rb
new file mode 100644
index 000000000..dad61e8f1
--- /dev/null
+++ b/test/integration/munin-server/serverspec/rrdcached_spec.rb
@@ -0,0 +1,13 @@
+require "serverspec"
+
+# Required by serverspec
+set :backend, :exec
+
+describe package("rrdcached") do
+  it { should be_installed }
+end
+
+describe service("rrdcached") do
+  it { should be_enabled }
+  it { should be_running }
+end
-- 
2.43.2