From: Sarah Hoffmann Date: Sat, 6 Apr 2024 07:11:42 +0000 (+0200) Subject: Merge remote-tracking branch 'upstream/master' X-Git-Url: https://git.openstreetmap.org/nominatim-ui.git/commitdiff_plain/044b38e5fab5a1de96a648502de606559d49ae93?hp=a1d2a5b19e7731811a55903593b44a02f34cfdab Merge remote-tracking branch 'upstream/master' --- diff --git a/CHANGES.md b/CHANGES.md index 0cc68df..e07ed24 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,10 @@ # CHANGES +* version 3.5.2 - 2024-04-05 + * Detail page: Link to postcode search not includes the country code + * test-suite: fix typos based on a codespell run + * NPM package updates (Svelte 4.2) + * version 3.5.1 - 2024-02-14 * Automatic release creation for 3.5.0 failed on Github Actions diff --git a/package.json b/package.json index 23c2594..b94e2a3 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "nominatim-ui", "description": "Debug web interface for Nominatim geocoder", - "version": "3.5.1", + "version": "3.5.2", "license": "GPL-2.0", "scripts": { "build": "rollup -c", diff --git a/src/components/DetailsOneRow.svelte b/src/components/DetailsOneRow.svelte index 8b77df2..8ba3769 100644 --- a/src/components/DetailsOneRow.svelte +++ b/src/components/DetailsOneRow.svelte @@ -8,6 +8,7 @@ export let addressLine; export let bDistanceInMeters; export let bMarkUnusedLines = false; + export let sCountryCode; $: bAddressLineUsed = addressLine.isaddress; $: reverse_only = Nominatim_Config.Reverse_Only; @@ -38,7 +39,8 @@ search by name {:else if !reverse_only && addressLine.type === 'postcode'} - + search by name {/if} diff --git a/src/pages/DetailsPage.svelte b/src/pages/DetailsPage.svelte index 225d1a0..aa3670f 100644 --- a/src/pages/DetailsPage.svelte +++ b/src/pages/DetailsPage.svelte @@ -63,6 +63,11 @@ ); } + function country_code(aThisPlace) { + let aLine = aThisPlace.address.find((address_line) => address_line.type === 'country_code'); + return aLine ? aLine.localname : null; + } + $: { let pageinfo = $page; if (pageinfo.tab === 'details') { @@ -155,7 +160,7 @@

Address

- +
@@ -172,7 +177,8 @@ {#each aPlace.address as addressLine} + bDistanceInMeters={false} + sCountryCode={country_code(aPlace)} /> {/each} {/if} diff --git a/test/details.js b/test/details.js index 2d1094d..a6fd5e5 100644 --- a/test/details.js +++ b/test/details.js @@ -68,6 +68,12 @@ describe('Details Page', function () { // Reverse-only installation have no search index, therefore no keywords if (!reverse_only) { + it('should have a link to postcode which includes country code', async function () { + const url = 'search.html?postalcode=9490&country=li'; + + assert.strictEqual((await page.$$eval(`a[href="${url}"]`, (links) => links.length)), 1); + }); + it('should change url and add new header on clicking display keywords', async function () { let current_url; let display_headers;
Local name