From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 22 Apr 2020 07:59:44 +0000 (+0200)
Subject: Merge pull request #1758 from krahulreddy/advanced-installations
X-Git-Tag: v3.5.0~32
X-Git-Url: https://git.openstreetmap.org/nominatim.git/commitdiff_plain/2740974a13697da482245faae892bdd05403bd2a?hp=5c56ea31984fe043bc0efe73e616017cbabfc909

Merge pull request #1758 from krahulreddy/advanced-installations

Advanced installations
---

diff --git a/VAGRANT.md b/VAGRANT.md
index 0cab24fa..4c8eb724 100644
--- a/VAGRANT.md
+++ b/VAGRANT.md
@@ -141,7 +141,7 @@ No. Long running Nominatim installations will differ once new import features (o
 bug fixes) get added since those usually only get applied to new/changed data.
 
 Also this document skips the optional Wikipedia data import which affects ranking
-of search results. See [Nominatim installation](http://nominatim.org/release-docs/latest/Installation) for details.
+of search results. See [Nominatim installation](https://nominatim.org/release-docs/latest/admin/Installation) for details.
 
 ##### Why Ubuntu? Can I test CentOS/Fedora/CoreOS/FreeBSD?
 
diff --git a/docs/api/Search.md b/docs/api/Search.md
index 688d7e0c..c18655dc 100644
--- a/docs/api/Search.md
+++ b/docs/api/Search.md
@@ -92,8 +92,12 @@ comma-separated list of language codes.
 * `countrycodes=<countrycode>[,<countrycode>][,<countrycode>]...`
 
 Limit search results to one or more countries. `<countrycode>` must be the
-ISO 3166-1alpha2 code, e.g. `gb` for the United Kingdom, `de` for Germany.
+[ISO 3166-1alpha2](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2) code,
+e.g. `gb` for the United Kingdom, `de` for Germany.
 
+Each place in Nominatim is assigned to one country code based
+on `admin_level=2` tags, in rare cases to none (for example in
+international waters outside any country).
 
 * `exclude_place_ids=<place_id,[place_id],[place_id]`
 
diff --git a/lib/ClassTypes.php b/lib/ClassTypes.php
index 60f18d95..a7c2cd4f 100644
--- a/lib/ClassTypes.php
+++ b/lib/ClassTypes.php
@@ -268,7 +268,7 @@ function getList()
             'tourism:caravan_site' => array('label' => 'Caravan Site', 'frequency' => 183, 'icon' => 'accommodation_caravan_park'),
             'amenity:bus_station' => array('label' => 'Bus Station', 'frequency' => 181, 'icon' => 'transport_bus_station'),
             'amenity:kindergarten' => array('label' => 'Kindergarten', 'frequency' => 179),
-            'highway:construction' => array('label' => 'Construction', 'frequency' => 176),
+            'highway:construction' => array('label' => 'Construction', 'frequency' => 176, 'simplelabel' => 'road'),
             'amenity:atm' => array('label' => 'Atm', 'frequency' => 172, 'icon' => 'money_atm2'),
             'amenity:emergency_phone' => array('label' => 'Emergency Phone', 'frequency' => 164),
             'waterway:lock' => array('label' => 'Lock', 'frequency' => 146),
diff --git a/nominatim/nominatim.py b/nominatim/nominatim.py
index 14643770..0db0777d 100755
--- a/nominatim/nominatim.py
+++ b/nominatim/nominatim.py
@@ -304,7 +304,7 @@ class Indexer(object):
             else:
                 ready, _, _ = select.select(self.threads, [], [])
 
-        assert(False, "Unreachable code")
+        assert False, "Unreachable code"
 
 
 def nominatim_arg_parser():
diff --git a/settings/address-levels.json b/settings/address-levels.json
index 9f32fc98..10cbf307 100644
--- a/settings/address-levels.json
+++ b/settings/address-levels.json
@@ -63,7 +63,11 @@
           "sea" : [4, 0]
       },
       "waterway" : {
-          "" : [17, 0]
+          "river" : [19, 0],
+          "stream" : [22, 0],
+          "ditch" : [22, 0],
+          "drain" : [22, 0],
+          "" : [20, 0]
       },
       "highway" : {
           "" : 26,
diff --git a/test/bdd/api/reverse/addressdetails.feature b/test/bdd/api/reverse/addressdetails.feature
new file mode 100644
index 00000000..5aa3846b
--- /dev/null
+++ b/test/bdd/api/reverse/addressdetails.feature
@@ -0,0 +1,10 @@
+@APIDB
+Feature: Reverse addressdetails
+    Tests for addressdetails in reverse queries
+
+    #github #1763
+    Scenario: Correct translation of highways under construction
+        When sending jsonv2 reverse coordinates -34.0290514,-53.5832235
+        Then result addresses contain
+        | road |
+        | Ruta 9 Coronel Leonardo Olivera |
diff --git a/utils/update.php b/utils/update.php
index c1dc2ab9..6965cd57 100644
--- a/utils/update.php
+++ b/utils/update.php
@@ -354,7 +354,7 @@ if ($aResult['import-osmosis'] || $aResult['import-osmosis-all']) {
     //
     if (strpos(CONST_Replication_Url, 'download.geofabrik.de') !== false && CONST_Replication_Update_Interval < 86400) {
         fail('Error: Update interval too low for download.geofabrik.de. ' .
-             "Please check install documentation (http://nominatim.org/release-docs/latest/Import-and-Update#setting-up-the-update-process)\n");
+             "Please check install documentation (https://nominatim.org/release-docs/latest/admin/Import-and-Update#setting-up-the-update-process)\n");
     }
 
     $sImportFile = CONST_InstallPath.'/osmosischange.osc';