From: Sarah Hoffmann <lonvia@denofr.de>
Date: Tue, 17 Nov 2020 09:53:26 +0000 (+0100)
Subject: disallow linking for postcode areas
X-Git-Tag: v3.6.0~31^2
X-Git-Url: https://git.openstreetmap.org/nominatim.git/commitdiff_plain/9ede048769ca31c211e9e49693b5b99c43cdd1de

disallow linking for postcode areas
---

diff --git a/sql/functions/placex_triggers.sql b/sql/functions/placex_triggers.sql
index c9095fbe..7d6352b4 100644
--- a/sql/functions/placex_triggers.sql
+++ b/sql/functions/placex_triggers.sql
@@ -138,6 +138,7 @@ DECLARE
 BEGIN
   IF bnd.rank_search >= 26 or bnd.rank_address = 0
      or ST_GeometryType(bnd.geometry) NOT IN ('ST_Polygon','ST_MultiPolygon')
+     or bnd.type IN ('postcode', 'postal_code')
   THEN
     RETURN NULL;
   END IF;
diff --git a/test/bdd/db/import/linking.feature b/test/bdd/db/import/linking.feature
index fa96e5b3..1e0d131a 100644
--- a/test/bdd/db/import/linking.feature
+++ b/test/bdd/db/import/linking.feature
@@ -14,7 +14,22 @@ Feature: Linking of places
          | R13     | - |
          | N256    | - |
 
-    Scenario: Waterways are linked when in waterway relations
+    Scenario: Postcode areas cannot be linked
+        Given the grid
+         | 1 |   | 2 |
+         |   | 9 |   |
+         | 4 |   | 3 |
+        And the named places
+         | osm | class    | type        | addr+postcode  | extra+wikidata | geometry    |
+         | R13 | boundary | postal_code | 123            | Q87493         | (1,2,3,4,1) |
+         | N25 | place    | suburb      | 123            | Q87493         | 9 |
+        When importing
+        Then placex contains
+         | object | linked_place_id |
+         | R13    | - |
+         | N25    | - |
+
+     Scenario: Waterways are linked when in waterway relations
         Given the scene split-road
         And the places
          | osm | class    | type  | name  | geometry |