From e82de99e5aac77947bc4b43423c7ab2f09ef7a05 Mon Sep 17 00:00:00 2001 From: AntoJvlt Date: Mon, 29 Mar 2021 22:07:29 +0200 Subject: [PATCH] Cleaned tests of exceptions and fix phrase_settings.json test file name. --- test/python/test_tools_import_special_phrases.py | 13 ++++--------- .../{phrase-settings.json => phrase_settings.json} | 0 2 files changed, 4 insertions(+), 9 deletions(-) rename test/testfiles/{phrase-settings.json => phrase_settings.json} (100%) diff --git a/test/python/test_tools_import_special_phrases.py b/test/python/test_tools_import_special_phrases.py index 7a8b832d..b77ae10d 100644 --- a/test/python/test_tools_import_special_phrases.py +++ b/test/python/test_tools_import_special_phrases.py @@ -17,16 +17,14 @@ def test_check_sanity_class(special_phrases_importer): If a wrong class or type is given, an UsageError should raise. If a good class and type are given, nothing special happens. """ - with pytest.raises(UsageError) as wrong_class: + with pytest.raises(UsageError): special_phrases_importer._check_sanity('en', '', 'type') - with pytest.raises(UsageError) as wrong_type: + with pytest.raises(UsageError): special_phrases_importer._check_sanity('en', 'class', '') special_phrases_importer._check_sanity('en', 'class', 'type') - assert wrong_class and wrong_type - def test_load_white_and_black_lists(special_phrases_importer): """ Test that _load_white_and_black_lists() well return @@ -55,12 +53,9 @@ def test_convert_settings_wrong_file(special_phrases_importer): Test that _convert_php_settings_if_needed() raise an exception if the given file is not a valid file. """ - - with pytest.raises(UsageError) as exceptioninfos: + with pytest.raises(UsageError, match='random_file is not a valid file.'): special_phrases_importer._convert_php_settings_if_needed('random_file') - assert str(exceptioninfos.value) == 'random_file is not a valid file.' - def test_convert_settings_json_already_exist(special_phrases_importer): """ Test that if we give to '_convert_php_settings_if_needed' a php file path @@ -78,7 +73,7 @@ def test_convert_settings_giving_json(special_phrases_importer): Test that if we give to '_convert_php_settings_if_needed' a json file path the same path is directly returned """ - json_file = (TEST_BASE_DIR / 'testfiles' / 'phrase-settings.json').resolve() + json_file = (TEST_BASE_DIR / 'testfiles' / 'phrase_settings.json').resolve() returned = special_phrases_importer._convert_php_settings_if_needed(json_file) diff --git a/test/testfiles/phrase-settings.json b/test/testfiles/phrase_settings.json similarity index 100% rename from test/testfiles/phrase-settings.json rename to test/testfiles/phrase_settings.json -- 2.45.1