X-Git-Url: https://git.openstreetmap.org/osqa.git/blobdiff_plain/13bee2f2e6aea2d936909861f3ab60bb09821a60..fa21c2cc4d92e1f723a3b38daa2f033dbb4889e5:/forum/views/commands.py
diff --git a/forum/views/commands.py b/forum/views/commands.py
index 3d2f9d3..be6aa71 100644
--- a/forum/views/commands.py
+++ b/forum/views/commands.py
@@ -1,28 +1,47 @@
+# -*- coding: utf-8 -*-
+
import datetime
-from forum import settings
+import json
+import logging
+
+from urllib import urlencode
+
from django.core.exceptions import ObjectDoesNotExist
-from django.utils import simplejson
-from django.http import HttpResponse, HttpResponseRedirect, Http404
-from django.shortcuts import get_object_or_404, render_to_response
+from django.core.urlresolvers import reverse
+from django.utils.encoding import smart_unicode
from django.utils.translation import ungettext, ugettext as _
-from django.template import RequestContext
+from django.http import (HttpResponse, HttpResponseRedirect, Http404,
+ HttpResponseBadRequest)
+from django.shortcuts import get_object_or_404, render_to_response
+
+from django.contrib import messages
+
from forum.models import *
-from forum.models.node import NodeMetaClass
+from forum.utils.decorators import ajax_login_required
from forum.actions import *
-from django.core.urlresolvers import reverse
-from forum.utils.decorators import ajax_method, ajax_login_required
-from decorators import command, CommandException, RefreshPageCommand
from forum.modules import decorate
from forum import settings
-import logging
+
+from decorators import command, CommandException, RefreshPageCommand
class NotEnoughRepPointsException(CommandException):
- def __init__(self, action):
- super(NotEnoughRepPointsException, self).__init__(
- _(
- """Sorry, but you don't have enough reputation points to %(action)s.
Please check the faq"""
- ) % {'action': action, 'faq_url': reverse('faq')}
- )
+ def __init__(self, action, user_reputation=None, reputation_required=None, node=None):
+ if reputation_required is not None and user_reputation is not None:
+ message = _(
+ """Sorry, but you don't have enough reputation points to %(action)s.
+ The minimum reputation required is %(reputation_required)d (yours is %(user_reputation)d).
+ Please check the FAQ"""
+ ) % {
+ 'action': action,
+ 'faq_url': reverse('faq'),
+ 'reputation_required' : reputation_required,
+ 'user_reputation' : user_reputation,
+ }
+ else:
+ message = _(
+ """Sorry, but you don't have enough reputation points to %(action)s.
Please check the faq"""
+ ) % {'action': action, 'faq_url': reverse('faq')}
+ super(NotEnoughRepPointsException, self).__init__(message)
class CannotDoOnOwnException(CommandException):
def __init__(self, action):
@@ -59,6 +78,10 @@ class CannotDoubleActionException(CommandException):
@decorate.withfn(command)
def vote_post(request, id, vote_type):
+ if not request.method == 'POST':
+ raise CommandException(_("Invalid request"))
+
+
post = get_object_or_404(Node, id=id).leaf
user = request.user
@@ -69,9 +92,12 @@ def vote_post(request, id, vote_type):
raise CannotDoOnOwnException(_('vote'))
if not (vote_type == 'up' and user.can_vote_up() or user.can_vote_down()):
- raise NotEnoughRepPointsException(vote_type == 'up' and _('upvote') or _('downvote'))
+ reputation_required = int(settings.REP_TO_VOTE_UP) if vote_type == 'up' else int(settings.REP_TO_VOTE_DOWN)
+ action_type = vote_type == 'up' and _('upvote') or _('downvote')
+ raise NotEnoughRepPointsException(action_type, user_reputation=user.reputation, reputation_required=reputation_required, node=post)
user_vote_count_today = user.get_vote_count_today()
+ user_can_vote_count_today = user.can_vote_count_today()
if user_vote_count_today >= user.can_vote_count_today():
raise NotEnoughLeftException(_('votes'), str(settings.MAX_VOTES_PER_DAY))
@@ -90,13 +116,11 @@ def vote_post(request, id, vote_type):
)
old_vote.cancel(ip=request.META['REMOTE_ADDR'])
- score_inc += (old_vote.__class__ == VoteDownAction) and 1 or -1
-
- if old_vote.__class__ != new_vote_cls:
- new_vote_cls(user=user, node=post, ip=request.META['REMOTE_ADDR']).save()
- score_inc += (new_vote_cls == VoteUpAction) and 1 or -1
- else:
+ score_inc = (old_vote.__class__ == VoteDownAction) and 1 or -1
vote_type = "none"
+ else:
+ new_vote_cls(user=user, node=post, ip=request.META['REMOTE_ADDR']).save()
+ score_inc = (new_vote_cls == VoteUpAction) and 1 or -1
response = {
'commands': {
@@ -105,7 +129,7 @@ def vote_post(request, id, vote_type):
}
}
- votes_left = (int(settings.MAX_VOTES_PER_DAY) - user_vote_count_today) + (vote_type == 'none' and -1 or 1)
+ votes_left = (user_can_vote_count_today - user_vote_count_today) + (vote_type == 'none' and -1 or 1)
if int(settings.START_WARN_VOTES_LEFT) >= votes_left:
response['message'] = _("You have %(nvotes)s %(tvotes)s left today.") % \
@@ -161,7 +185,7 @@ def like_comment(request, id):
raise CannotDoOnOwnException(_('like'))
if not user.can_like_comment(comment):
- raise NotEnoughRepPointsException( _('like comments'))
+ raise NotEnoughRepPointsException( _('like comments'), node=comment)
like = VoteAction.get_action_for(node=comment, user=user)
@@ -201,17 +225,17 @@ def delete_comment(request, id):
@decorate.withfn(command)
def mark_favorite(request, id):
- question = get_object_or_404(Question, id=id)
+ node = get_object_or_404(Node, id=id)
if not request.user.is_authenticated():
raise AnonymousNotAllowedException(_('mark a question as favorite'))
try:
- favorite = FavoriteAction.objects.get(canceled=False, node=question, user=request.user)
+ favorite = FavoriteAction.objects.get(canceled=False, node=node, user=request.user)
favorite.cancel(ip=request.META['REMOTE_ADDR'])
added = False
except ObjectDoesNotExist:
- FavoriteAction(node=question, user=request.user, ip=request.META['REMOTE_ADDR']).save()
+ FavoriteAction(node=node, user=request.user, ip=request.META['REMOTE_ADDR']).save()
added = True
return {
@@ -265,7 +289,9 @@ def comment(request, id):
id, comment.id, comment.comment, user.decorated_name, user.get_profile_url(),
reverse('delete_comment', kwargs={'id': comment.id}),
reverse('node_markdown', kwargs={'id': comment.id}),
- reverse('convert_comment', kwargs={'id': comment.id}),
+ reverse('convert_comment', kwargs={'id': comment.id}),
+ user.can_convert_comment_to_answer(comment),
+ bool(settings.SHOW_LATEST_COMMENTS_FIRST)
]
}
}
@@ -284,7 +310,7 @@ def node_markdown(request, id):
raise AnonymousNotAllowedException(_('accept answers'))
node = get_object_or_404(Node, id=id)
- return HttpResponse(node.active_revision.body, mimetype="text/plain")
+ return HttpResponse(node.active_revision.body, content_type="text/plain")
@decorate.withfn(command)
@@ -322,6 +348,21 @@ def accept_answer(request, id):
AcceptAnswerAction(node=answer, user=user, ip=request.META['REMOTE_ADDR']).save()
+
+ # If the request is not an AJAX redirect to the answer URL rather than to the home page
+ if not request.is_ajax():
+ msg = _("""
+ Congratulations! You've accepted an answer.
+ """)
+
+ # Notify the user with a message that an answer has been accepted
+ messages.info(request, msg)
+
+ # Redirect URL should include additional get parameters that might have been attached
+ redirect_url = answer.parent.get_absolute_url() + "?accepted_answer=true&%s" % smart_unicode(urlencode(request.GET))
+
+ return HttpResponseRedirect(redirect_url)
+
commands['mark_accepted'] = [answer.id]
return {'commands': commands}
@@ -408,8 +449,15 @@ def convert_to_comment(request, id):
answer = get_object_or_404(Answer, id=id)
question = answer.question
+ # Check whether the user has the required permissions
+ if not user.is_authenticated():
+ raise AnonymousNotAllowedException(_("convert answers to comments"))
+
+ if not user.can_convert_to_comment(answer):
+ raise NotEnoughRepPointsException(_("convert answers to comments"))
+
if not request.POST:
- description = lambda a: _("Answer by %(uname)s: %(snippet)s...") % {'uname': a.author.username,
+ description = lambda a: _("Answer by %(uname)s: %(snippet)s...") % {'uname': smart_unicode(a.author.username),
'snippet': a.summary[:10]}
nodes = [(question.id, _("Question"))]
[nodes.append((a.id, description(a))) for a in
@@ -417,12 +465,6 @@ def convert_to_comment(request, id):
return render_to_response('node/convert_to_comment.html', {'answer': answer, 'nodes': nodes})
- if not user.is_authenticated():
- raise AnonymousNotAllowedException(_("convert answers to comments"))
-
- if not user.can_convert_to_comment(answer):
- raise NotEnoughRepPointsException(_("convert answers to comments"))
-
try:
new_parent = Node.objects.get(id=request.POST.get('under', None))
except:
@@ -456,36 +498,6 @@ def convert_comment_to_answer(request, id):
return RefreshPageCommand()
-@decorate.withfn(command)
-def convert_to_question(request, id):
- user = request.user
- answer = get_object_or_404(Answer, id=id)
- question = answer.question
-
- if not request.POST:
- description = lambda a: _("Answer by %(uname)s: %(snippet)s...") % {'uname': a.author.username,
- 'snippet': a.summary[:10]}
- nodes = [(question.id, _("Question"))]
- [nodes.append((a.id, description(a))) for a in
- question.answers.filter_state(deleted=False).exclude(id=answer.id)]
-
- return render_to_response('node/convert_to_question.html', {'answer': answer})
-
- if not user.is_authenticated():
- raise AnonymousNotAllowedException(_("convert answers to questions"))
-
- if not user.can_convert_to_question(answer):
- raise NotEnoughRepPointsException(_("convert answers to questions"))
-
- try:
- title = request.POST.get('title', None)
- except:
- raise CommandException(_("You haven't specified the title of the new question"))
-
- AnswerToQuestionAction(user=user, node=answer, ip=request.META['REMOTE_ADDR']).save(data=dict(title=title))
-
- return RefreshPageCommand()
-
@decorate.withfn(command)
def subscribe(request, id, user=None):
if user:
@@ -536,18 +548,19 @@ def mark_tag(request, tag=None, **kwargs):#tagging system
pass
else:
ts.update(reason=reason)
- return HttpResponse(simplejson.dumps(''), mimetype="application/json")
+ return HttpResponse(json.dumps(''), content_type="application/json")
def matching_tags(request):
- if len(request.GET['q']) == 0:
- raise CommandException(_("Invalid request"))
+ q = request.GET.get('q')
+ if not q:
+ return HttpResponseBadRequest(_("Invalid request"))
- possible_tags = Tag.active.filter(name__icontains = request.GET['q'])
+ possible_tags = Tag.active.filter(name__icontains=q)
tag_output = ''
for tag in possible_tags:
tag_output += "%s|%s|%s\n" % (tag.id, tag.name, tag.used_count)
- return HttpResponse(tag_output, mimetype="text/plain")
+ return HttpResponse(tag_output, content_type="text/plain")
def matching_users(request):
if len(request.GET['q']) == 0:
@@ -559,14 +572,18 @@ def matching_users(request):
for user in possible_users:
output += ("%s|%s|%s\n" % (user.id, user.decorated_name, user.reputation))
- return HttpResponse(output, mimetype="text/plain")
+ return HttpResponse(output, content_type="text/plain")
def related_questions(request):
if request.POST and request.POST.get('title', None):
can_rank, questions = Question.objects.search(request.POST['title'])
- return HttpResponse(simplejson.dumps(
+
+ if can_rank and isinstance(can_rank, basestring):
+ questions = questions.order_by(can_rank)
+
+ return HttpResponse(json.dumps(
[dict(title=q.title, url=q.get_absolute_url(), score=q.score, summary=q.summary)
- for q in questions.filter_state(deleted=False)[0:10]]), mimetype="application/json")
+ for q in questions.filter_state(deleted=False)[0:10]]), content_type="application/json")
else:
raise Http404()
@@ -578,5 +595,51 @@ def answer_permanent_link(request, id):
# Getting the current object URL -- the Application URL + the object relative URL
url = '%s%s' % (settings.APP_BASE_URL, answer.get_absolute_url())
- # Display the template
- return render_to_response('node/permanent_link.html', { 'url' : url, })
+ if not request.POST:
+ # Display the template
+ return render_to_response('node/permanent_link.html', { 'url' : url, })
+
+ return {
+ 'commands' : {
+ 'copy_url' : [request.POST['permanent_link_url'],],
+ },
+ 'message' : _("The permanent URL to the answer has been copied to your clipboard."),
+ }
+
+@decorate.withfn(command)
+def award_points(request, user_id, answer_id):
+ user = request.user
+ awarded_user = get_object_or_404(User, id=user_id)
+ answer = get_object_or_404(Answer, id=answer_id)
+
+ # Users shouldn't be able to award themselves
+ if awarded_user.id == user.id:
+ raise CannotDoOnOwnException(_("award"))
+
+ # Anonymous users cannot award points, they just don't have such
+ if not user.is_authenticated():
+ raise AnonymousNotAllowedException(_('award'))
+
+ if not request.POST:
+ return render_to_response("node/award_points.html", {
+ 'user' : user,
+ 'awarded_user' : awarded_user,
+ 'reputation_to_comment' : str(settings.REP_TO_COMMENT)
+ })
+ else:
+ points = int(request.POST['points'])
+
+ # We should check if the user has enough reputation points, otherwise we raise an exception.
+ if points < 0:
+ raise CommandException(_("The number of points to award needs to be a positive value."))
+
+ if user.reputation < points:
+ raise NotEnoughRepPointsException(_("award"))
+
+ extra = dict(message=request.POST.get('message', ''), awarding_user=request.user.id, value=points)
+
+ # We take points from the awarding user
+ AwardPointsAction(user=request.user, node=answer, extra=extra).save(data=dict(value=points, affected=awarded_user))
+
+ return { 'message' : _("You have awarded %(awarded_user)s with %(points)d points") % {'awarded_user' : awarded_user, 'points' : points} }
+