ids are Numbers. Not ints, and certainly not uints. Numbers.
authorRichard Fairhurst <richard@systemed.net>
Mon, 14 Jun 2010 12:36:04 +0000 (12:36 +0000)
committerRichard Fairhurst <richard@systemed.net>
Mon, 14 Jun 2010 12:36:04 +0000 (12:36 +0000)
TODO.txt
net/systemeD/halcyon/MapPaint.as
net/systemeD/halcyon/connection/AMFConnection.as
net/systemeD/halcyon/connection/AMFCounter.as
net/systemeD/halcyon/connection/EntityRenumberedEvent.as
net/systemeD/halcyon/vectorlayers/VectorLayer.as
net/systemeD/potlatch2/TagViewer.mxml

index c9ca179..780c89e 100644 (file)
--- a/TODO.txt
+++ b/TODO.txt
@@ -31,7 +31,6 @@ Potlatch 2: main outstanding issues
 
 ** Doesn't always update selected tab when you select a new entity
 ** Doesn't update selected tab when you change the relations on an entity
-* Double-clicking a relation to edit it sometimes comes up with the POIs (how to reproduce?)
 * Dynamic reloading of stylesheet/map_features, so that you don't need to reload the full page when editing them
 * If a select name is too long then, the select menu seems to give a horizontal scrollbar instead of the name of the item e.g. cuisine#Coffee Shop
 * If you have both inputSets names and buildingAddress, and name= key is filled in then the basic tab will get both, surely only name should be shown and building name should be ignored e.g. cafes. [Actually this was an issue of addr: being missing from one of them, however this may still be a problem for other overlapping inputSets]
index 68f0713..75a8f1b 100644 (file)
@@ -109,13 +109,13 @@ package net.systemeD.halcyon {
                        delete nodeuis[node.id];
                }
                
-               public function renumberWayUI(way:Way,oldID:int):void {
+               public function renumberWayUI(way:Way,oldID:Number):void {
                        if (!wayuis[oldID]) { return; }
                        wayuis[way.id]=wayuis[oldID];
                        delete wayuis[oldID];
                }
 
-               public function renumberNodeUI(node:Node,oldID:int):void {
+               public function renumberNodeUI(node:Node,oldID:Number):void {
                        if (!nodeuis[oldID]) { return; }
                        nodeuis[node.id]=nodeuis[oldID];
                        delete nodeuis[oldID];
index 03d5a6c..c1d25b5 100755 (executable)
@@ -111,7 +111,7 @@ package net.systemeD.halcyon.connection {
 
         private function error(r:Object):void {}
 
-               private function loadWay(id:uint):void {
+               private function loadWay(id:Number):void {
                        readConnection.call("getway",new Responder(gotWay, error),id);
                }
 
@@ -163,7 +163,7 @@ package net.systemeD.halcyon.connection {
                }
 
 
-               private function loadRelation(id:uint):void {
+               private function loadRelation(id:Number):void {
                        readConnection.call("getrelation",new Responder(gotRelation, error),id);
                }
 
index 5106e95..cd9555a 100644 (file)
@@ -20,10 +20,10 @@ package net.systemeD.halcyon.connection {
                        eventList.push(e);
                }
                
-               public function addRelationRequest(id:uint):void {
+               public function addRelationRequest(id:Number):void {
                        addRequest(id+"rel");
                }
-               public function addWayRequest(id:uint):void {
+               public function addWayRequest(id:Number):void {
                        addRequest(id+"way");
                }
                private function addRequest(n:String):Boolean {
index 5477f31..50203a6 100644 (file)
@@ -5,7 +5,7 @@ package net.systemeD.halcyon.connection {
     public class EntityRenumberedEvent extends EntityEvent {
         private var _oldID:Number;
 
-        public function EntityRenumberedEvent(type:String, item:Entity, oldID:int) {
+        public function EntityRenumberedEvent(type:String, item:Entity, oldID:Number) {
             super(type, item);
             this._oldID = oldID;
         }
index 48f9a68..87c4713 100644 (file)
@@ -71,7 +71,7 @@ package net.systemeD.halcyon.vectorlayers {
                                }
                                // delete this way
                                while (oldWay.length) { 
-                                       var id:int=oldWay.getNode(0).id;
+                                       var id:Number=oldWay.getNode(0).id;
                                        oldWay.removeNodeByIndex(0,MainUndoStack.getGlobalStack().addAction,false);
                                        delete nodes[id];
                                }
index a8b2e42..6cb1250 100644 (file)
           // add members in new order
           for each(var memberObject:Object in membersGrid.dataProvider) {
             var e:Entity;
-            var id:int = memberObject.id;
+            var id:Number = memberObject.id;
             if(memberObject.type == 'node') {
               e = conn.getNode(id);
             } else if (memberObject.type == 'way') {
           trace("complete: relation "+rel.id+" now has "+rel.length+" members");
       }
       
-      private function editRelation(id:uint):void {
-          trace("edit relation "+id);
+      private function editRelation(id:Number):void {
           var panel:RelationEditorPanel = RelationEditorPanel(
               PopUpManager.createPopUp(Application(Application.application), RelationEditorPanel, true));
           panel.setRelation(Connection.getConnectionInstance().getRelation(id));