Fix the "can't deselect a marker by clicking on the background" bug. Note the comment...

diff --git a/net/systemeD/potlatch2/controller/ControllerState.as b/net/systemeD/potlatch2/controller/ControllerState.as
index e92e6429e42e37730b1949f99cb569122b756400..7c2e1068d3405896ec6952d64420bdfb6340ca1b 100644 (file)
--- a/net/systemeD/potlatch2/controller/ControllerState.as
+++ b/net/systemeD/potlatch2/controller/ControllerState.as
@@ -97,6 +97,12 @@ package net.systemeD.potlatch2.controller {
                                        // drag map
                                        return new DragBackground(event);
                                }
+            } else if ( event.type == MouseEvent.CLICK && focus == null && map.dragstate!=map.DRAGGING) {
+                // this is identical to the below, but needed for unselecting markers on vector background layers.
+                // Deselecting a POI or way on the main layer emits both CLICK and MOUSE_UP, but markers only CLICK
+                // I'll leave it to someone who understands to decide whether they are the same thing and should be
+                // combined with a (CLICK || MOUSE_UP)
+                return (this is NoSelection) ? null : new NoSelection();
                        } else if ( event.type == MouseEvent.MOUSE_UP && focus == null && map.dragstate!=map.DRAGGING) {
                                return (this is NoSelection) ? null : new NoSelection();
                        } else if ( event.type == MouseEvent.MOUSE_UP && focus && map.dragstate!=map.NOT_DRAGGING) {