Fix two infinite loops in the one line: decrement counter towards zero, and a uint...
authorAndy Allan <gravitystorm@gmail.com>
Fri, 20 Aug 2010 17:01:15 +0000 (17:01 +0000)
committerAndy Allan <gravitystorm@gmail.com>
Fri, 20 Aug 2010 17:01:15 +0000 (17:01 +0000)
TODO.txt
net/systemeD/halcyon/connection/actions/RemoveEntityFromRelationAction.as

index 8b945a4..2da8ae0 100644 (file)
--- a/TODO.txt
+++ b/TODO.txt
@@ -7,7 +7,6 @@ Potlatch 2: main outstanding issues
 * purgeOutside simply doesn't work - WayUIs stay around. To investigate
 * P1-style J (join) / shift-J (unjoin)
 * Make parallelise properly undoable
-* shift+delete a way that's part of a relation, then undo triggers infinite loop
 * double-click to make a poi leaves two actions in the undo list
 
 == Vector background layers ==
index fc41dea..3575770 100644 (file)
@@ -41,7 +41,7 @@ package net.systemeD.halcyon.connection.actions {
             member.addParent(entity);
             
             var last:int = 0;
-            for (var i:uint = removedMembers.length - 1; i >= 0; i++) {
+            for (var i:int = removedMembers.length - 1; i >= 0; i--) {
                 var removed:RelationMember = removedMembers[i];
                 var index:int = memberRemovedFrom[i];
                 memberList.splice(index, 0, removed);