potlatch2.git
8 years agoupdate toolbox when reversing a way, or when adding nodes during drawway
Andy Allan [Wed, 26 Jan 2011 12:06:13 +0000 (12:06 +0000)]
update toolbox when reversing a way, or when adding nodes during drawway

8 years agoADD getNextNode(), getPrevNode() to net/systemeD/halcyon/connection/Way.as. These...
Steve Bennett [Wed, 26 Jan 2011 11:56:53 +0000 (11:56 +0000)]
ADD getNextNode(), getPrevNode() to net/systemeD/halcyon/connection/Way.as. These assist with navigating ways that are circular.
ADD followWay() to net/systemeD/potlatch2/controller/DrawWay.as. A new way to draw a way, by following an existing way. This is useful for making two areas touch each other exactly, or for a road to partially run along a border, or whatever local mapping practice dictates. Press "F" to use it.

TODO better user feedback on Follow, documenting it in user instructions, verifying correctness of getNextNode/getPrevNode.

8 years agoAdd a wrapper hbox around the rotating one, to stop glitches in the viewstack
Andy Allan [Tue, 25 Jan 2011 19:25:44 +0000 (19:25 +0000)]
Add a wrapper hbox around the rotating one, to stop glitches in the viewstack

8 years agoAdd a direction-sensing reverse arrow, with one or two caveats
Andy Allan [Tue, 25 Jan 2011 18:52:20 +0000 (18:52 +0000)]
Add a direction-sensing reverse arrow, with one or two caveats

8 years agoAdd an angle calculation for ways
Andy Allan [Tue, 25 Jan 2011 18:52:18 +0000 (18:52 +0000)]
Add an angle calculation for ways

8 years agoUnit tests for Feature, using mockito to mock MapFeatures
Andy Allan [Tue, 25 Jan 2011 10:57:34 +0000 (10:57 +0000)]
Unit tests for Feature, using mockito to mock MapFeatures

8 years agoAdd mockito - flex mocking library
Andy Allan [Tue, 25 Jan 2011 10:57:30 +0000 (10:57 +0000)]
Add mockito - flex mocking library

8 years agoUpgrade flexunit to 4.1.0 RC2
Andy Allan [Tue, 25 Jan 2011 10:57:21 +0000 (10:57 +0000)]
Upgrade flexunit to 4.1.0 RC2

8 years agoAdd keys to Feature tags while parsing inputSets - better list of keys for autocomplete
Andy Allan [Mon, 24 Jan 2011 16:11:48 +0000 (16:11 +0000)]
Add keys to Feature tags while parsing inputSets - better list of keys for autocomplete

8 years agoClean confusing indentation
Andy Allan [Mon, 24 Jan 2011 16:11:46 +0000 (16:11 +0000)]
Clean confusing indentation

8 years agoADD railway=disused, railway=abandoned as faded brown version of normal railway ...
Steve Bennett [Mon, 24 Jan 2011 14:00:02 +0000 (14:00 +0000)]
ADD railway=disused, railway=abandoned as faded brown version of normal railway (no distinction between them)
ADD aeroway=aerodrome, aeroway=taxiway, aeroway=runway, aeroway=apron. It's possible, but highly unlikely, that I went too far in the eye candy department on aeroway=runway.

8 years agoAdd Danish Fugro imagery to presets
Andy Allan [Mon, 24 Jan 2011 10:23:54 +0000 (10:23 +0000)]
Add Danish Fugro imagery to presets

8 years agoSupport @import directives in MapCSS files
Richard Fairhurst [Sun, 23 Jan 2011 17:55:01 +0000 (17:55 +0000)]
Support @import directives in MapCSS files

8 years agoFIX error introduced in previous checkin [25117]. I will continue to review my qualit...
Steve Bennett [Sun, 23 Jan 2011 11:04:59 +0000 (11:04 +0000)]
FIX error introduced in previous checkin [25117]. I will continue to review my quality control procedures, with greater urgency.

8 years agoADD directional arrows to highway=*, waterway=*, railway=*, aerial_way=* when selected.
Steve Bennett [Sun, 23 Jan 2011 10:20:34 +0000 (10:20 +0000)]
ADD directional arrows to highway=*, waterway=*, railway=*, aerial_way=* when selected.

This was inspired by http://trac.openstreetmap.org/ticket/3380. I actually think it works pretty well. Even on my ancient desktop, where potlatch as a whole runs pretty slow, I don't see any performance hit. I've tried to keep it as unobtrusive as possible - in many instances you need to zoom in to see the arrows, which I think is ok.

8 years ago[removing some noise accidentally checked in in 25114. I will review my quality contr...
Steve Bennett [Sun, 23 Jan 2011 09:42:58 +0000 (09:42 +0000)]
[removing some noise accidentally checked in in 25114. I will review my quality control procedures.]

8 years agoADD support for "sourcekey" entity in imagery.xml and controller/ControllerState.as.
Steve Bennett [Sun, 23 Jan 2011 09:33:23 +0000 (09:33 +0000)]
ADD support for "sourcekey" entity in imagery.xml and controller/ControllerState.as.

http://trac.openstreetmap.org/ticket/3472

8 years agoModify behaviour when removing node from way (minus key): remove, but don't delete...
Steve Bennett [Sun, 23 Jan 2011 08:59:46 +0000 (08:59 +0000)]
Modify behaviour when removing node from way (minus key): remove, but don't delete, nodes that have interesting tags.
http://trac.openstreetmap.org/ticket/3473

8 years agomove lots of eventListeners to weak references; fix a few dodgy (or non-existent...
Richard Fairhurst [Sat, 22 Jan 2011 22:27:16 +0000 (22:27 +0000)]
move lots of eventListeners to weak references; fix a few dodgy (or non-existent) disposals of eventListeners

8 years agomore important TODOs
Richard Fairhurst [Thu, 20 Jan 2011 16:27:45 +0000 (16:27 +0000)]
more important TODOs

8 years agomake note of critical bug
Richard Fairhurst [Thu, 20 Jan 2011 14:29:02 +0000 (14:29 +0000)]
make note of critical bug

8 years agowe don't actually need a mask any more now that we have a ScrollRect
Richard Fairhurst [Sun, 16 Jan 2011 18:58:06 +0000 (18:58 +0000)]
we don't actually need a mask any more now that we have a ScrollRect

8 years agosupport reverting individual entities - makes conflict resolution work
Richard Fairhurst [Sun, 16 Jan 2011 16:55:35 +0000 (16:55 +0000)]
support reverting individual entities - makes conflict resolution work

8 years agoremove no-longer needed types from MapEvent
Richard Fairhurst [Sun, 16 Jan 2011 16:55:05 +0000 (16:55 +0000)]
remove no-longer needed types from MapEvent

8 years agoSaveDialog support for floating alerts
Richard Fairhurst [Sun, 16 Jan 2011 16:54:39 +0000 (16:54 +0000)]
SaveDialog support for floating alerts

8 years agoadd namespace for VideoPlayer
Richard Fairhurst [Sun, 16 Jan 2011 16:54:08 +0000 (16:54 +0000)]
add namespace for VideoPlayer

8 years agofloating alerts
Richard Fairhurst [Sun, 16 Jan 2011 16:53:32 +0000 (16:53 +0000)]
floating alerts

8 years agosupport embedded video in help dialogue
Richard Fairhurst [Sun, 16 Jan 2011 16:52:56 +0000 (16:52 +0000)]
support embedded video in help dialogue

8 years agopress J to merge ways
Richard Fairhurst [Sun, 16 Jan 2011 16:52:28 +0000 (16:52 +0000)]
press J to merge ways

8 years agodon't leave name hanging around when moving nodes; ignore drawExcept/drawOnly for...
Richard Fairhurst [Sun, 16 Jan 2011 16:51:34 +0000 (16:51 +0000)]
don't leave name hanging around when moving nodes; ignore drawExcept/drawOnly for areas

8 years agodon't throw an exception if imagery logo/attribution is unreachable
Richard Fairhurst [Sun, 16 Jan 2011 16:50:59 +0000 (16:50 +0000)]
don't throw an exception if imagery logo/attribution is unreachable

8 years agorelation actions menu. This should make it easier to merge relations, etc. etc.
Richard Fairhurst [Fri, 14 Jan 2011 19:08:41 +0000 (19:08 +0000)]
relation actions menu. This should make it easier to merge relations, etc. etc.

8 years agoAdd fix for 0-byte-reporting browsers
Andy Allan [Fri, 14 Jan 2011 16:48:22 +0000 (16:48 +0000)]
Add fix for 0-byte-reporting browsers

8 years agoCustom preloader based on idea and code from Pathfinder Development
Andy Allan [Fri, 14 Jan 2011 14:39:50 +0000 (14:39 +0000)]
Custom preloader based on idea and code from Pathfinder Development

8 years agoPosition the X button more prettily
Andy Allan [Fri, 14 Jan 2011 13:01:18 +0000 (13:01 +0000)]
Position the X button more prettily

8 years agoDocument new Q shortcut
Andy Allan [Thu, 13 Jan 2011 18:33:41 +0000 (18:33 +0000)]
Document new Q shortcut

8 years agoMake quadralaterawhatsit work on selected waynodes, too. Add Q shortcut for both.
Andy Allan [Thu, 13 Jan 2011 18:27:40 +0000 (18:27 +0000)]
Make quadralaterawhatsit work on selected waynodes, too. Add Q shortcut for both.

8 years agoFilter out bad_routing bugs and don't bother fetching closed bugs either
Andy Allan [Thu, 13 Jan 2011 17:18:23 +0000 (17:18 +0000)]
Filter out bad_routing bugs and don't bother fetching closed bugs either

8 years agoMove the cutting/embankment highlighting to be below other things, so that roads...
Andy Allan [Thu, 13 Jan 2011 16:27:03 +0000 (16:27 +0000)]
Move the cutting/embankment highlighting to be below other things, so that roads in a cutting don't resemble railway trackbeds so much

8 years agomove Scottish Popular Edition to ooc.osm.org now that Ollie's UCL machine has been...
Richard Fairhurst [Mon, 10 Jan 2011 17:50:45 +0000 (17:50 +0000)]
move Scottish Popular Edition to ooc.osm.org now that Ollie's UCL machine has been turned off

8 years agomap_features.xml:
Steve Bennett [Sun, 9 Jan 2011 21:22:01 +0000 (21:22 +0000)]
map_features.xml:
ADD several common shop=*: car, kiosk, florist
REWORK building=yes assumption as a checkbox option

potlatch.css:
ADD highway=living_street

ADD flowers.png (needs work to make it fit in)

8 years agoallow <feature>s to be grouped
Richard Fairhurst [Sun, 9 Jan 2011 17:09:50 +0000 (17:09 +0000)]
allow <feature>s to be grouped

8 years agopermit XML file nesting in map_features.xml
Richard Fairhurst [Sun, 9 Jan 2011 16:50:08 +0000 (16:50 +0000)]
permit XML file nesting in map_features.xml

8 years agoADD 6 types of boundaries to map_features.xml
Steve Bennett [Sun, 9 Jan 2011 01:02:32 +0000 (01:02 +0000)]
ADD 6 types of boundaries to map_features.xml
ADD several boundary types to potlatch.css, including a catch-all
REMOVE way[sport] from potlatch.css (it is only a support tag, should theoretically not be rendered without an accompanying leisure=, amenity= etc.
TODO icons for boundaries in map_features.xml
TODO work out whether the other boundary types are worth supporting (and wtf the difference between boundary=town and place=town is)

8 years agoadd dummy error handler to stop #2044s being thrown in the debug player when Skobbler...
Richard Fairhurst [Thu, 6 Jan 2011 10:32:24 +0000 (10:32 +0000)]
add dummy error handler to stop #2044s being thrown in the debug player when Skobbler's site is screwing up

8 years agodon't update value after every keystroke (forcing expensive redraws), but rather...
Richard Fairhurst [Tue, 4 Jan 2011 19:39:28 +0000 (19:39 +0000)]
don't update value after every keystroke (forcing expensive redraws), but rather, only when the change is complete

8 years agodon't allow users to set empty keys
Richard Fairhurst [Tue, 4 Jan 2011 19:19:39 +0000 (19:19 +0000)]
don't allow users to set empty keys

8 years agoshow what's being undone as a tooltip
Richard Fairhurst [Tue, 4 Jan 2011 15:24:11 +0000 (15:24 +0000)]
show what's being undone as a tooltip

8 years agomake '+' work when tab focus is on Delete button, too
Richard Fairhurst [Tue, 4 Jan 2011 14:03:51 +0000 (14:03 +0000)]
make '+' work when tab focus is on Delete button, too

8 years agoFix autocomplete issues #3388 and #3403. Back out comments from previous change ...
Richard Fairhurst [Tue, 4 Jan 2011 13:09:48 +0000 (13:09 +0000)]
Fix autocomplete issues #3388 and #3403. Back out comments from previous change - sorry, I couldn't read the actual code with so much surrounding verbiage. Will document AutoComplete.as in due course when I'm feeling brave. :)

8 years agoshop=books. Closes #3376.
Richard Fairhurst [Tue, 4 Jan 2011 11:54:50 +0000 (11:54 +0000)]
shop=books. Closes #3376.

8 years agorelation editing for multiple selections
Richard Fairhurst [Fri, 31 Dec 2010 17:38:09 +0000 (17:38 +0000)]
relation editing for multiple selections

8 years agodrag multiple items
Richard Fairhurst [Fri, 31 Dec 2010 13:27:38 +0000 (13:27 +0000)]
drag multiple items

8 years agoAdd lots of icons. All from SJJB except two from http://www.clker.com/.
Steve Bennett [Tue, 28 Dec 2010 13:23:24 +0000 (13:23 +0000)]
Add lots of icons. All from SJJB except two from clker.com/.

8 years agomake + keypress work even if the advanced panel isn't currently selected
Richard Fairhurst [Tue, 28 Dec 2010 13:11:31 +0000 (13:11 +0000)]
make + keypress work even if the advanced panel isn't currently selected

8 years agomultipolygons shouldn't have non-Way members
Richard Fairhurst [Fri, 24 Dec 2010 10:33:33 +0000 (10:33 +0000)]
multipolygons shouldn't have non-Way members

8 years agostop space-drag from breaking when in SelectedWayNode state
Richard Fairhurst [Fri, 24 Dec 2010 10:10:29 +0000 (10:10 +0000)]
stop space-drag from breaking when in SelectedWayNode state

8 years agoDocument all tools, and SelectedParallelWay.
Steve Bennett [Fri, 24 Dec 2010 02:25:06 +0000 (02:25 +0000)]
Document all tools, and SelectedParallelWay.

8 years agoADD note about changing global flash security settings
Steve Bennett [Fri, 24 Dec 2010 01:48:48 +0000 (01:48 +0000)]
ADD note about changing global flash security settings
ADD note about using Flex Builder/Flash Builder
REWORD the "before you begin" to make it easier for skim readers who never read anything properly, like me.

8 years agoADD lots of amenity tags and more cuisine types. Trying to be systematic, working...
Steve Bennett [Thu, 23 Dec 2010 06:39:43 +0000 (06:39 +0000)]
ADD lots of amenity tags and more cuisine types. Trying to be systematic, working through taginfo from most popular to least. The top 30 cuisines and top 30 amenities are now represented. (Still much work to go on amenities: even the 30th most popular has nearly 19,000 uses.)
MODIFY some landuse and buildings, in particular removing some building=yes

8 years agoADD highway=path
Steve Bennett [Thu, 23 Dec 2010 01:48:48 +0000 (01:48 +0000)]
ADD highway=path
IMPROVE highway=cycleway, highway=footway (add help text)

8 years agoMake conjoint waterway/administrative boundary play nicely.
Steve Bennett [Thu, 23 Dec 2010 01:41:13 +0000 (01:41 +0000)]
Make conjoint waterway/administrative boundary play nicely.

8 years agoFix to bug 3409 (http://trac.openstreetmap.org/ticket/3409)
Steve Bennett [Wed, 22 Dec 2010 13:39:58 +0000 (13:39 +0000)]
Fix to bug 3409 (trac.openstreetmap.org/ticket/3409)

I've left in a heap of (disabled) trace code because it's likely someone will want to debug something similar.

In amongst all that there are two lines of code that fix the bug: one that sets selectedIndex to -1, and another that updates the cursor position. Basically with the incorrect index being set, it was partially acting like an autocomplete was being triggered, and then the cursor position was getting set to weird values.

Still some more usability issues remain.

8 years agoJust documentation in a few random places to do with styles, hitzones, layers etc.
Steve Bennett [Mon, 20 Dec 2010 12:22:12 +0000 (12:22 +0000)]
Just documentation in a few random places to do with styles, hitzones, layers etc.

8 years agoFix bug in TileSet where certain tiles would never get loaded. (Turned out to be...
Steve Bennett [Sun, 19 Dec 2010 13:58:17 +0000 (13:58 +0000)]
Fix bug in TileSet where certain tiles would never get loaded. (Turned out to be because map had scrolled, meaning tile was no longer needed on screen, but it didn't get reset to "unqueued".)

Hurray!

Also, a bunch of random doco.

8 years agoImplement speed-up for the case of a drawn way intersecting with another way. Do...
Steve Bennett [Sun, 19 Dec 2010 11:02:37 +0000 (11:02 +0000)]
Implement speed-up for the case of a drawn way intersecting with another way. Do this by not highlighting nodes that are offscreen. Added a bit of extra logic to make this happen, like tracking the "highlighted node" state of a way, and updating nodes when appropriate. I suspect I missed a much simpler way of doing this, in the UpdateEntityUIs logic somewhere...

Also a bunch of ASDoc documentation.

8 years agopressing Enter in the changeset comment field automatically clicks 'Save'
Richard Fairhurst [Sat, 18 Dec 2010 10:05:59 +0000 (10:05 +0000)]
pressing Enter in the changeset comment field automatically clicks 'Save'

8 years agoCommenting for ASDoc
Steve Bennett [Sat, 18 Dec 2010 02:25:57 +0000 (02:25 +0000)]
Commenting for ASDoc

8 years agoAdd cycleway=shared and cycleway=segregated tag choices for being able to get more...
Shaun McDonald [Fri, 17 Dec 2010 15:15:31 +0000 (15:15 +0000)]
Add cycleway=shared and cycleway=segregated tag choices for being able to get more accurate cycle path information for routing purposes (e.g. CycleStreets).

8 years agotalk to TomH's changes for XML error reporting and conditional deletes
Richard Fairhurst [Thu, 16 Dec 2010 16:34:02 +0000 (16:34 +0000)]
talk to TomH's changes for XML error reporting and conditional deletes

8 years agoback out r24710 because it breaks things
Richard Fairhurst [Thu, 16 Dec 2010 15:54:47 +0000 (15:54 +0000)]
back out r24710 because it breaks things

8 years agoSince junction=roundabout implies oneway=yes, lets show the one way arrows for them...
Shaun McDonald [Thu, 16 Dec 2010 15:10:57 +0000 (15:10 +0000)]
Since junction=roundabout implies oneway=yes, lets show the one way arrows for them too.

8 years agoASDocs for SelectedWay and ControllerState. Make some keycodes more readable.
Steve Bennett [Thu, 16 Dec 2010 13:21:52 +0000 (13:21 +0000)]
ASDocs for SelectedWay and ControllerState. Make some keycodes more readable.

8 years agoAdd note about running test suite
Andy Allan [Wed, 15 Dec 2010 10:40:56 +0000 (10:40 +0000)]
Add note about running test suite

8 years agoFix typo in readme - flex 3 downloads, not flex 4
Andy Allan [Wed, 15 Dec 2010 10:38:34 +0000 (10:38 +0000)]
Fix typo in readme - flex 3 downloads, not flex 4

8 years agoAdding emergency=* drop-down to Hospital preset
Jonathan Bennett [Tue, 14 Dec 2010 23:49:39 +0000 (23:49 +0000)]
Adding emergency=* drop-down to Hospital preset

8 years agoAdding bicycle=dismount to the bicycle access restrictions for cyclists. Adding descr...
Shaun McDonald [Tue, 14 Dec 2010 15:24:08 +0000 (15:24 +0000)]
Adding bicycle=dismount to the bicycle access restrictions for cyclists. Adding description to the prohibited to note that you are not allowed to even push your bike there.

8 years agoAdd a direct link to the downloads page in the readme.
Shaun McDonald [Tue, 14 Dec 2010 14:49:07 +0000 (14:49 +0000)]
Add a direct link to the downloads page in the readme.

8 years agoAdd the first test for JoinNodeAction
Andy Allan [Tue, 14 Dec 2010 12:57:32 +0000 (12:57 +0000)]
Add the first test for JoinNodeAction

8 years agoFix bug:
Steve Bennett [Tue, 14 Dec 2010 12:49:59 +0000 (12:49 +0000)]
Fix bug:
#3391: Dragging map deselects current way

Mouse up was causing both CLICK and MOUSE_UP events. Like the previous commenter, I don't know what's going on, but this fix will presumably allow correct behaviour for both SelectedMarker and SelectedWay states.

8 years agoAdd some unit tests for Node.within
Andy Allan [Tue, 14 Dec 2010 12:13:44 +0000 (12:13 +0000)]
Add some unit tests for Node.within

8 years agoRecalculate what imagery is available when the map is moved.
Tom Hughes [Tue, 14 Dec 2010 12:05:39 +0000 (12:05 +0000)]
Recalculate what imagery is available when the map is moved.

8 years agoAdd opencyclemap and mapquest tiles as optional background layers
Andy Allan [Tue, 14 Dec 2010 11:36:44 +0000 (11:36 +0000)]
Add opencyclemap and mapquest tiles as optional background layers

8 years agoadd some stuff about dependencies
Richard Fairhurst [Mon, 13 Dec 2010 13:54:31 +0000 (13:54 +0000)]
add some stuff about dependencies

8 years agoIncorporate feedback from randomjunk and TomH
Andy Allan [Mon, 13 Dec 2010 11:30:43 +0000 (11:30 +0000)]
Incorporate feedback from randomjunk and TomH

8 years agoSee, tabs are evil in all kinds of ways
Andy Allan [Mon, 13 Dec 2010 11:11:33 +0000 (11:11 +0000)]
See, tabs are evil in all kinds of ways

8 years agoD'oh, wrong place
Andy Allan [Mon, 13 Dec 2010 11:05:55 +0000 (11:05 +0000)]
D'oh, wrong place

8 years agoWrite down the coding standards that we've been using up to now
Andy Allan [Mon, 13 Dec 2010 11:00:20 +0000 (11:00 +0000)]
Write down the coding standards that we've been using up to now

8 years agoFix documentation typos, and expand entity.markClean/markDirty to warn off using...
Andy Allan [Mon, 13 Dec 2010 10:43:21 +0000 (10:43 +0000)]
Fix documentation typos, and expand entity.markClean/markDirty to warn off using them directly

8 years agoMove bindable metadata to put it immediately adjacent to the function definition...
Andy Allan [Mon, 13 Dec 2010 10:43:19 +0000 (10:43 +0000)]
Move bindable metadata to put it immediately adjacent to the function definition. Indentation tweaks

8 years agoerror/conflict-handling work-in-progress
Richard Fairhurst [Sun, 12 Dec 2010 23:20:25 +0000 (23:20 +0000)]
error/conflict-handling work-in-progress

8 years agoKludge up a one-line fix to another GUI updating bug:
Steve Bennett [Sun, 12 Dec 2010 05:32:50 +0000 (05:32 +0000)]
Kludge up a one-line fix to another GUI updating bug:
1) On advanced tab, change a tag like highway=road to waterway=river
2) Switch to simple tab
3) Although the new feature is recognised, the old editors are present.

Also applied to repeating tags, or deleting all tags.

8 years agoAllow numpad + as well as "equals plus". (Like P1)
Steve Bennett [Sun, 12 Dec 2010 05:16:42 +0000 (05:16 +0000)]
Allow numpad + as well as "equals plus". (Like P1)

8 years agoFix two irritating bugs where the editing panel wasn't being updated:
Steve Bennett [Sun, 12 Dec 2010 04:01:00 +0000 (04:01 +0000)]
Fix two irritating bugs where the editing panel wasn't being updated:
1) On pressing Source button ("B")
2) On repeating tags ("R")

8 years agoTwo more files documented.
Steve Bennett [Sun, 12 Dec 2010 03:47:59 +0000 (03:47 +0000)]
Two more files documented.

8 years agoOne more doco.
Steve Bennett [Sat, 11 Dec 2010 14:51:23 +0000 (14:51 +0000)]
One more doco.

8 years agoSome more doco.
Steve Bennett [Sat, 11 Dec 2010 14:43:52 +0000 (14:43 +0000)]
Some more doco.

8 years agoAdd some ASDoc comments to mapfeature-related classes. Probably best if someone quick...
Steve Bennett [Sat, 11 Dec 2010 12:14:35 +0000 (12:14 +0000)]
Add some ASDoc comments to mapfeature-related classes. Probably best if someone quickly reviews these.

Also replaced a few tab characters with 4 spaces. Hope that's ok.

8 years agostop control characters from being entered (works properly this time. I hope)
Richard Fairhurst [Sat, 11 Dec 2010 12:12:41 +0000 (12:12 +0000)]
stop control characters from being entered (works properly this time. I hope)

8 years agoback out previous change... sigh
Richard Fairhurst [Sat, 11 Dec 2010 00:09:45 +0000 (00:09 +0000)]
back out previous change... sigh