Move browse#note to notes#show This allows a more resourceful routing approach.
Rename api_notes resource to avoid conflict with non-API resource This allows using e.g. note_path for notes#show in the future.
Merge pull request #3676 from harry-wood/notes-disappear-time Display how long until a note will disappear
Remove unused note id data attributes
Remove 'Hide' button from hidden note page
Display how long until a note will disappear Modify the message displayed at the bottom of the notes sidepanel. For already resolved notes we don't want to say "please resolve it". Fixes https://github.com/openstreetmap/openstreetmap-website/issues/3663 Instead explain that it will disappear from the map (so reporting is probably not necessary) and display how long to go until that happens. Tackling https://github.com/openstreetmap/openstreetmap-website/issues/3071
Use standard bootstrap spacers, rather than custom css, to space out the elements Also make the reporting text small, since it's not required reading in most circumstances.
Move note reporting link to bottom of the sidebar Move the 'report this note' and surrounding sentence down the sidebar beneath the commont/resolve form to give it less prominence.
Add wording to discourage reporting a note Add some wording wrapped around the 'Report this note' link to explain to users to resolve the note instead. Tackling the issue reported by DWG, that too many note reports are coming to them, where the users could deal it themselves: https://github.com/openstreetmap/openstreetmap-website/issues/3071
Bootstrap 5: Replace all form-group classes with mb-3
Add missing autocomplete attributes
Rework sidebar to use padding on the sidebar_content div This saves every header, list, paragraph etc having to sort out their own padding. The couple of instances where we want edge-to-edge can be acheived using the negative margin spacing utilities. The padding is based on $spacer so that it can be adjusted automatically via bootstrap configuration. This also means that we can remove many (mis-)uses of the browse-section class, which is only supposed to be for cases where there are multiple browse-sections in sequence (e.g. multiple nodes in the node history browse pages).
Add btn-wrapper class
Fix unexpected spacing on note buttons when overflowed
Convert note form to use bootstrap
Fix erblint warning
Use flexbox to position the close icon on the sidebars This ensures that the text and the close icon don't overlap, regardless of the length of the title. The title div grows to use all available space, while ensuring the text breaks if necessary to prevent it from pushing the close icon offscreen.
Avoid lego translations for coordinates Use the i18n system for joining coordinate values together, while avoiding making any changes or standardisation involving the exact symbol used in each situation. Refs #2732
Merge remote-tracking branch 'upstream/pull/2667'
Fix rubocop warning