Bootstrap 5: Add form-label class to hand-crafted form labels This is done automatically for forms created by bootstrap_form
Bootstrap 5: Update manual select boxes to use form-select class
Add missing autocomplete attributes
Refactor user_blocks form to use bootstrap Further refactoring could involve a virtual attribute for duration.
Refactor away from global form control styling This enables forms to be converted one-by-one to bootstrap. Without this refactoring, these global styles interfere with form control styling from bootstrap. The rearrangement of the search and directions styling is to solve CSS selector specitivity issues.
Avoid double-escaping display names when sent through the translation system They are escaped properly without the h() call, and doing that just double-escapes them
Use _html suffix to avoid using raw when displaying translated strings This is safer than raw, since any user input is still escaped.
Use built-in form sumbit translation keys for user blocks
Allow user_blocks to be created for longer periods This avoids admins from having to manually change end periods in the database
erblint: fix remaining single quoted strings
Whitespace fixes for user_blocks erb files
Use lazy lookups for user_blocks translations
Refactor @this_user to @user Historically we used @user for the currently logged in user, but this was changed to `current_user` in 2017.
Use user_path links. Fixes #1785
Site cleanup I set out to do a quick and dirty typography overhaul to make things more consistent and a bit cleaner, but I kept running into things I didn't like, so this lead me down something of a rabbit hole of design tweaks to the OSM site. Goals here are to have better content hierarchy, better vertical rhythm, more consistent UI, cleaner markup with less tables, all while keeping the basics pretty much intact. There are a lot of things I didn't touch even though they need to be updated (lots of tables where stuff shouldn't be tables, mostly). Basic overview of changes: I added a new persistent header that helps segment pages. It's now a lot easier to know what you're looking at. The header has a page title, a description, plus a submenu of actions. There is now a pattern of 20px/10px margins and padding for more rhythm and breathing room throughout the site. I know there are other problems here or things I've missed - would love another set of eyes to look over this! I am still getting comfortable working on the site - it's my first time ever digging into a ruby or rails so I'm not familiar with the templating language yet.
Add preview functionality to rich text controls
Fixed escaping in title
Removed bogus characters from form_for
Use <%= instead of <% for block helpers that use concat
Set a limit on the new/edit block text area. Make it as big as diary comments instead of the insane default rails size of 40/20 cols/rows