Move the amf and swf controllers into the api namespace
Remove unnecessary requires from tests
Fix tests for rails 5.2.1 compatibility Rails 5.2.1 has changed how the request body is handled internally for a test which means we can no longer cheat by stashing it in the request environment and must instead pass it properly to the request method.
Fix new rubocop warnings
Fix Style/NumericPredicate rubocop warnings
Resolve 34 Rubocop Lint/AmbiguousOperator conflicts
Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts
Fix new rubocop warnings
Fix new rubocop warnings
Fix rubocop warnings
Update amf_controller tests to use a factory-generated user for credentials.
refactor remaining amf controller tests to use factories.
More amf_controller tests converted to use factories.
Refactor more amf_controller tests to use factories.
Refactor putway method tests to use factories This involved decoding a lot of magic numbers, to figure out which were node_ids and which were other things (versions, coordinates etc)
Refactor some more amf_controller tests to use factories. The timestamp truncation thing was a pain to figure out.
Refactor some amf_controller tests to use factories.
Make all factory-generated users 'normal' The use of create(:normal_user) makes the tests needlessly harder to understand and reason about, particularly when we start using associations in the factories.
Refactor amf_controller tests to avoid users fixtures In all honesty I wouldn't be surprised if there are some semi-hidden dependencies on the user fixtures here, given the number of magic numbers all over the place. But this commit takes care of the explicit dependencies for now.
Merge remote-tracking branch 'openstreetmap/pull/1347' into master