Remove assert_response when followed by assert_redirected_to
Merge pull request #4535 from tomhughes/rails-tokens Use rails generated tokens for emails
Treat github and wikipedia provided emails as confirmed Fixes #4270
Use rails tokens for signup confirmations
Test that mismatched passwords are rejected
Test that signups can be confirmed and can authenticate afterwards
Avoid running integration tests in every locale We have over 200 locales, and so this takes a long time. This reduces time taken from around 200 seconds to 6 to run these tests.
Use SecureRandom to generate user tokens
Change provider name to "microsoft"
Update tests for microsoft_graph endpoints
Use omniauth-microsoft_graph instead of omniauth-windowslive Omniauth-microsoft_graph correctly populates 'email' and 'name' fields used by OpenStreetMap. It also uses updated endpoints for Microsoft identity provider. Use email address returned by microsoft_graph provider as a verified address. Upgrading exisiting users from windowslive to microsoft_graph: - upon next login existing `windowslive` users will have to authorizei OpenStreetMap application to "Read Your Profile," required for proper reading of display name field. The name of the identity provider in OSM is kept to 'windowslive': - the entries in users table with `provider == 'windowslive'` can be reused for microsoft_graph provider, since the uid field is preserved. Users will not need to repeat the sign up process. - OAuth2 callback is still `/auth/windowslive`, no updates to Microsoft Identity Provider portal App registration are necessary.
Test that verified emails from OAuth signups are accepted automatically
Bootstrap 5: Replace all form-group classes with mb-3
Avoid accidental locale changes in tests
Fix new ruboop warnings
Move confirmation methods into ConfirmationsController
Update to Omniauth 2.x This requires converting all use of the /auth endpoints to use the POST method as GET is no longer supported.
Refactor user registration form to use bootstrap
Ensure that test utility methods are marked as private This allows us to enable the check for test method names.
Improve locale selection algorithm Don't include locales which only have rails translations in the candidates, and ensure that user specified options take priority over less specific variants of earlier choices.