+# The NodeController is the RESTful interface to Node objects
+
class NodeController < ApplicationController
require 'xml/libxml'
- before_filter :authorize
+ session :off
+ before_filter :authorize, :only => [:create, :update, :delete]
+ before_filter :check_write_availability, :only => [:create, :update, :delete]
+ before_filter :check_read_availability, :except => [:create, :update, :delete]
after_filter :compress_output
+ # Create a node from XML.
def create
- response.headers["Content-Type"] = 'text/xml'
if request.put?
node = Node.from_xml(request.raw_post, true)
+ # FIXME remove debug
+ logger.debug request.raw_post
+ logger.debug node
if node
- node.user_id = @user.id
- node.visible = 1
- if node.save_with_history
- render :text => node.id.to_s
- else
- render :nothing => true, :status => 500
- end
- return
+ node.version = 0
+ #node.changeset_id = node.changeset
+ node.visible = true
+ node.save_with_history!
+ render :text => node.id.to_s, :content_type => "text/plain"
else
- render :nothing => true, :status => 400 # if we got here the doc didnt parse
- return
+ render :nothing => true, :status => :bad_request
end
+ else
+ render :nothing => true, :status => :method_not_allowed
end
-
- render :nothing => true, :status => 500 # something went very wrong
end
- def rest
- response.headers["Content-Type"] = 'text/xml'
- unless Node.exists?(params[:id])
- render :nothing => true, :status => 404
- return
- end
-
- node = Node.find(params[:id])
-
- case request.method
-
- when :get
- unless node
- render :nothing => true, :status => 500
- return
+ # Dump the details on a node given in params[:id]
+ def read
+ begin
+ node = Node.find(params[:id])
+ if node.visible?
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
+ else
+ render :text => "", :status => :gone
end
-
- unless node.visible
- render :nothing => true, :status => 410
- return
- end
-
- render :text => node.to_xml.to_s
- return
-
- when :delete
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ end
+ end
+
+ # Dump a specific version of the node based on the given params[:id] and params[:version]
+ def version
+ begin
+ node = Node.find(:first, :conditions => { :id => params[:id], :version => params[:version] } )
if node.visible
- if Segment.find(:first, :conditions => [ "visible = 1 and (node_a = ? or node_b = ?)", node.id, node.id])
- render :nothing => true, :status => HTTP_PRECONDITION_FAILED
- else
- node.user_id = @user.id
- node.visible = 0
- node.save_with_history
- render :nothing => true
- end
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
else
- render :nothing => true, :status => 410
+ render :nothing => true, :status => :gone
end
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ end
+ end
- when :put
+ # Update a node from given XML
+ def update
+ begin
+ node = Node.find(params[:id])
new_node = Node.from_xml(request.raw_post)
- if new_node
- node.timestamp = Time.now
- node.user_id = @user.id
-
- node.latitude = new_node.latitude
- node.longitude = new_node.longitude
- node.tags = new_node.tags
-
- if node.id == new_node.id and node.save_with_history
- render :nothing => true
- else
- render :nothing => true, :status => 500
- end
+ if new_node and new_node.id == node.id
+ node.update_from(new_node, @user)
+ render :text => node.version.to_s, :content_type => "text/plain"
else
- render :nothing => true, :status => 400 # if we got here the doc didnt parse
+ render :nothing => true, :status => :bad_request
end
- return
+ rescue OSM::APIVersionMismatchError => ex
+ render :text => "Version mismatch: Provided " + ex.provided.to_s +
+ ", server had: " + ex.latest.to_s, :status => :bad_request
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
end
+ end
+ # Delete a node. Doesn't actually delete it, but retains its history in a wiki-like way.
+ # FIXME remove all the fricking SQL
+ def delete
+ begin
+ node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
+ # FIXME we no longer care about the user, (or maybe we want to check
+ # that the user of the changeset is the same user as is making this
+ # little change?) we really care about the
+ # changeset which must be open, and that the version that we have been
+ # given is the one that is currently stored in the database
+
+ if new_node and new_node.id == node.id
+ node.delete_with_history(new_node, @user)
+ render :nothing => true
+ else
+ render :nothing => true, :status => :bad_request
+ end
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ rescue OSM::APIError => ex
+ render ex.render_opts
+ end
end
+ # WTF does this do?
def nodes
- response.headers["Content-Type"] = 'text/xml'
- ids = params['nodes'].split(',').collect {|n| n.to_i }
+ ids = params['nodes'].split(',').collect { |n| n.to_i }
+
if ids.length > 0
- nodelist = Node.find(ids)
- doc = get_xml_doc
- nodelist.each do |node|
+ doc = OSM::API.new.get_xml_doc
+
+ Node.find(ids).each do |node|
doc.root << node.to_xml_node
end
- render :text => doc.to_s
+
+ render :text => doc.to_s, :content_type => "text/xml"
else
- render :nothing => true, :status => 400
+ render :nothing => true, :status => :bad_request
end
end
end
projects / rails.git / blobdiff