Rubocop fixes and increase per method complexity limit from 23 to 25

[rails.git] / app / helpers / note_helper.rb

diff --git a/app/helpers/note_helper.rb b/app/helpers/note_helper.rb
index bfd7f493dfb8103b9d85b1b9187ce2bb7ec8b162..4b5be42d78b8786988be869e4dc5d2b5ca3c1901 100644 (file)
--- a/app/helpers/note_helper.rb
+++ b/app/helpers/note_helper.rb
@@ -1,13 +1,24 @@
 module NoteHelper
 module NoteHelper

-  def note_event(at, by)
+  def note_event(event, at, by)

     if by.nil?
     if by.nil?

-      I18n.t("browse.note.at_html", :when => friendly_date(at)).html_safe
+      I18n.t("browse.note." + event + "_by_anonymous",
+             :when => friendly_date(at),
+             :exact_time => l(at)).html_safe

     else
     else

-      I18n.t("browse.note.at_by_html", :when => friendly_date(at), :user => note_author(by)).html_safe
+      I18n.t("browse.note." + event + "_by",
+             :when => friendly_date(at),
+             :exact_time => l(at),
+             :user => note_author(by)).html_safe

     end
   end
 
   def note_author(author, link_options = {})
     end
   end
 
   def note_author(author, link_options = {})

-    link_to h(author.display_name), link_options.merge({:controller => "user", :action => "view", :display_name => author.display_name})
+    if author.nil?
+      ""
+    elsif author.status == "deleted"
+      t("users.no_such_user.deleted")
+    else
+      link_to h(author.display_name), link_options.merge(:controller => "/users", :action => "show", :display_name => author.display_name)
+    end

   end
 end
   end
 end