Merge remote-tracking branch 'upstream/pull/2167'

[rails.git] / test / models / note_test.rb

diff --git a/test/models/note_test.rb b/test/models/note_test.rb
index 441f52eb6b8a0036c3fc1a60a8b263c912785d87..2010fe20204047f4a4f78eaea9387ba5ff8fc762 100644 (file)
--- a/test/models/note_test.rb
+++ b/test/models/note_test.rb
@@ -1,12 +1,9 @@
-# -*- coding: utf-8 -*-
 require "test_helper"
 
 class NoteTest < ActiveSupport::TestCase
-  fixtures :users
-
   def test_status_valid
-    ok = %w(open closed hidden)
-    bad = %w(expropriated fubared)
+    ok = %w[open closed hidden]
+    bad = %w[expropriated fubared]
 
     ok.each do |status|
       note = create(:note)
@@ -17,7 +14,7 @@ class NoteTest < ActiveSupport::TestCase
     bad.each do |status|
       note = create(:note)
       note.status = status
-      assert !note.valid?, "#{status} is valid when it shouldn't be"
+      assert_not note.valid?, "#{status} is valid when it shouldn't be"
     end
   end
 
@@ -51,16 +48,27 @@ class NoteTest < ActiveSupport::TestCase
   end
 
   def test_author
-    anonymous_comment = create(:note_comment)
-    assert_nil anonymous_comment.note.author
-    comment = create(:note_comment, :author_id => users(:normal_user).id)
-    assert_equal users(:normal_user), comment.note.author
+    comment = create(:note_comment)
+    assert_nil comment.note.author
+
+    user = create(:user)
+    comment = create(:note_comment, :author => user)
+    assert_equal user, comment.note.author
   end
 
   def test_author_ip
+    comment = create(:note_comment)
+    assert_nil comment.note.author_ip
+
     comment = create(:note_comment, :author_ip => IPAddr.new("192.168.1.1"))
     assert_equal IPAddr.new("192.168.1.1"), comment.note.author_ip
-    comment = create(:note_comment, :author_ip => nil)
-    assert_nil comment.note.author_ip
+  end
+
+  # Ensure the lat/lon is formatted as a decimal e.g. not 4.0e-05
+  def test_lat_lon_format
+    note = build(:note, :latitude => 0.00004 * GeoRecord::SCALE, :longitude => 0.00008 * GeoRecord::SCALE)
+
+    assert_equal "0.0000400", note.lat.to_s
+    assert_equal "0.0000800", note.lon.to_s
   end
 end