Return usernames correctly.
[rails.git] / app / models / node.rb
index 6eecc853d12a585577a95e36c3a1e87331bf5fd4..abf0c583e14a97ced1aed1cd69d8bd932a4beaaa 100644 (file)
@@ -84,15 +84,17 @@ class Node < ActiveRecord::Base
     el1['lat'] = self.latitude.to_s
     el1['lon'] = self.longitude.to_s
 
-    # el['user'] = self.user.display_name if self.user.data_public?
     user_display_name_cache = {} if user_display_name_cache.nil?
+
     if user_display_name_cache and user_display_name_cache[self.user_id]
       # use the cache if available
-    else
+    elsif self.user.data_public?
       user_display_name_cache[self.user_id] = self.user.display_name
+    else
+      user_display_name_cache[self.user_id] = nil
     end
 
-    el1['user'] = user_display_name_cache[self.user_id]
+    el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil?
 
     Node.split_tags(el1, self.tags)
     el1['visible'] = self.visible.to_s