+# The NodeController is the RESTful interface to Node objects
+
class NodeController < ApplicationController
require 'xml/libxml'
-
- before_filter :authorize
- def create
-# @node = Node.new
-# @node.id = 1
-# @node.latitude = 1
-# @node.save
+ session :off
+ before_filter :authorize, :only => [:create, :update, :delete]
+ before_filter :check_write_availability, :only => [:create, :update, :delete]
+ before_filter :check_read_availability, :except => [:create, :update, :delete]
+ after_filter :compress_output
- if request.putt?
- @txt = resp.body
+ # Create a node from XML.
+ def create
+ if request.put?
+ node = Node.from_xml(request.raw_post, true)
+ # FIXME remove debug
+ logger.debug request.raw_post
+ logger.debug node
+
+ if node
+ node.version = 0
+ #node.changeset_id = node.changeset
+ node.visible = true
+ node.save_with_history!
+
+ render :text => node.id.to_s, :content_type => "text/plain"
+ else
+ render :nothing => true, :status => :bad_request
+ end
+ else
+ render :nothing => true, :status => :method_not_allowed
end
end
- def dummy
- if request.post?
- userid = dao.useridfromcreds(r.user, r.get_basic_auth_pw)
- doc = Document.new $stdin.read
-
- doc.elements.each('osm/node') do |pt|
- lat = pt.attributes['lat'].to_f
- lon = pt.attributes['lon'].to_f
- xmlnodeid = pt.attributes['id'].to_i
-
- tags = []
- pt.elements.each('tag') do |tag|
- tags << [tag.attributes['k'],tag.attributes['v']]
- end
-
- tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
-
- tags = '' unless tags
- if xmlnodeid == nodeid && userid != 0
- if nodeid == 0
- new_node_id = dao.create_node(lat, lon, userid, tags)
- if new_node_id
- puts new_node_id
- exit
- else
- exit HTTP_INTERNAL_SERVER_ERROR
- end
- else
- node = dao.getnode(nodeid)
- if node
- #FIXME: need to check the node hasn't moved too much
- if dao.update_node?(nodeid, userid, lat, lon, tags)
- exit
- else
- exit HTTP_INTERNAL_SERVER_ERROR
- end
- else
- exit HTTP_NOT_FOUND
- end
- end
-
- else
- exit BAD_REQUEST
- end
+ # Dump the details on a node given in params[:id]
+ def read
+ begin
+ node = Node.find(params[:id])
+ if node.visible?
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
+ else
+ render :text => "", :status => :gone
end
- exit HTTP_INTERNAL_SERVER_ERROR
-
-
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
end
end
-
-
- def rest
-
- #
- # POST ???
- #
-
- if request.post?
- nodeid = r.args.match(/nodeid=([0-9]+)/).captures.first.to_i
- userid = dao.useridfromcreds(r.user, r.get_basic_auth_pw)
- doc = Document.new $stdin.read
-
- doc.elements.each('osm/node') do |pt|
- lat = pt.attributes['lat'].to_f
- lon = pt.attributes['lon'].to_f
- xmlnodeid = pt.attributes['id'].to_i
-
- tags = []
- pt.elements.each('tag') do |tag|
- tags << [tag.attributes['k'],tag.attributes['v']]
- end
-
- tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
-
- tags = '' unless tags
- if xmlnodeid == nodeid && userid != 0
- if nodeid == 0
- new_node_id = dao.create_node(lat, lon, userid, tags)
- if new_node_id
- puts new_node_id
- exit
- else
- exit HTTP_INTERNAL_SERVER_ERROR
- end
- else
- node = dao.getnode(nodeid)
- if node
- #FIXME: need to check the node hasn't moved too much
- if dao.update_node?(nodeid, userid, lat, lon, tags)
- exit
- else
- exit HTTP_INTERNAL_SERVER_ERROR
- end
- else
- exit HTTP_NOT_FOUND
- end
- end
-
- else
- exit BAD_REQUEST
- end
+
+ # Dump a specific version of the node based on the given params[:id] and params[:version]
+ def version
+ begin
+ node = Node.find(:first, :conditions => { :id => params[:id], :version => params[:version] } )
+ if node.visible
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
+ else
+ render :nothing => true, :status => :gone
end
- exit HTTP_INTERNAL_SERVER_ERROR
-
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
end
+ end
- #
- # GET ???
- #
-
- if request.get?
- node = node.find(params[:id])
- doc = Document.new
- doc.encoding = "UTF-8"
- root = Node.new 'osm'
- root['version'] = '0.4'
- root['generator'] = 'OpenStreetMap server'
- doc.root = root
- el1 = Node.new 'node'
- el1['id'] = node.id.to_s
- el1['lat'] = node.latitude.to_s
- el1['lon'] = node.longitude.to_s
- split_tags(el1, node.tags)
- el1['visible'] = node.visible.to_s
- el1['timestamp'] = node.timestamp
- root << el1
-
- render :text => doc.to_s, :template => false
- end
-
- #
- # DELETE????
- #
-
- if request.delete?
- userid = dao.useridfromcreds(r.user, r.get_basic_auth_pw)
- #cgi doesnt work with DELETE so extract manually:
- nodeid = r.args.match(/nodeid=([0-9]+)/).captures.first.to_i
+ # Update a node from given XML
+ def update
+ begin
+ node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
- if userid > 0 && nodeid != 0
- node = dao.getnode(nodeid)
- if node
- if node.visible
- if dao.delete_node?(nodeid, userid)
- exit
- else
- exit HTTP_INTERNAL_SERVER_ERROR
- end
- else
- exit HTTP_GONE
- end
- else
- exit HTTP_NOT_FOUND
- end
+ if new_node and new_node.id == node.id
+ node.update_from(new_node, @user)
+ render :text => node.version.to_s, :content_type => "text/plain"
else
- exit BAD_REQUEST
-
+ render :nothing => true, :status => :bad_request
end
+ rescue OSM::APIVersionMismatchError => ex
+ render :text => "Version mismatch: Provided " + ex.provided.to_s +
+ ", server had: " + ex.latest.to_s, :status => :bad_request
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ end
+ end
-
+ # Delete a node. Doesn't actually delete it, but retains its history in a wiki-like way.
+ # FIXME remove all the fricking SQL
+ def delete
+ begin
+ node = Node.find(params[:id])
+ # FIXME we no longer care about the user, (or maybe we want to check
+ # that the user of the changeset is the same user as is making this
+ # little change?) we really care about the
+ # changeset which must be open, and that the version that we have been
+ # given is the one that is currently stored in the database
+ node.delete_with_history(@user)
+
+ render :nothing => true
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ rescue OSM::APIError => ex
+ render ex.render_opts
end
+ end
+ # WTF does this do?
+ def nodes
+ ids = params['nodes'].split(',').collect { |n| n.to_i }
- end
+ if ids.length > 0
+ doc = OSM::API.new.get_xml_doc
- private
- def split_tags(el, tags)
- tags.split(';').each do |tag|
- parts = tag.split('=')
- key = ''
- val = ''
- key = parts[0].strip unless parts[0].nil?
- val = parts[1].strip unless parts[1].nil?
- if key != '' && val != ''
- el2 = Node.new('tag')
- el2['k'] = key.to_s
- el2['v'] = val.to_s
- el << el2
- end
+ Node.find(ids).each do |node|
+ doc.root << node.to_xml_node
+ end
+
+ render :text => doc.to_s, :content_type => "text/xml"
+ else
+ render :nothing => true, :status => :bad_request
end
end
-
end
projects / rails.git / blobdiff