Refactor notes#mine to simplify code

[rails.git] / app / views / notes / mine.html.erb

diff --git a/app/views/notes/mine.html.erb b/app/views/notes/mine.html.erb
index c58548b47c385aa2cc32bf8a5f26edce345877e0..2966b81bbe305953eb372acb4293ecea8acb1d8f 100644 (file)
--- a/app/views/notes/mine.html.erb
+++ b/app/views/notes/mine.html.erb
@@ -1,37 +1,35 @@
-<h1><%= @heading %></h1>
-<p><%= raw @description %></p>
+<% content_for :heading do %>
+  <h2><%= t "notes.mine.heading", :user => @user.display_name %></h2>
+  <p><%= t "notes.mine.subheading_html", :user => link_to(@user.display_name, user_path(@user)) %></p>
+<% end %>
 
-<%= render :partial => 'notes_paging_nav' %>
+<%= render :partial => "notes_paging_nav" %>
 
-<table id="note_list" cellpadding="3">
+<table class="note_list">
   <tr>
     <th></th>
-    <th><%= t'note.mine.id' %></th>
-    <th><%= t'changeset.changesets.user' %></th>
-    <th><%= t'changeset.changesets.comment' %></th>
-    <th><%= t'changeset.changesets.saved_at' %></th>
-    <th><%= t'note.mine.last_changed' %></th>
+    <th><%= t ".id" %></th>
+    <th><%= t ".creator" %></th>
+    <th><%= t ".description" %></th>
+    <th><%= t ".created_at" %></th>
+    <th><%= t ".last_changed" %></th>
   </tr>
 <% @notes.each do |note| -%>
-  <tr<% if note.author != @user2 %> bgcolor="#EEEEEE"<% end %>>
+  <tr<% if note.author == @user %> class="creator"<% end %>>
     <td>
-      <% if note.status == "closed" %>
-        <%= image_tag("closed_note_marker.png", :alt => 'closed') %>
+      <% if note.closed? %>
+        <%= image_tag("closed_note_marker.png", :alt => "closed") %>
       <% else %>
-        <%= image_tag("open_note_marker.png", :alt => 'open') %>
+        <%= image_tag("open_note_marker.png", :alt => "open") %>
       <% end %>
     </td>
-    <td><%= link_to note.id.to_s, :controller => "browse", :action => "note", :id => note.id %></td>
-    <% if note.author.nil? %> 
-      <td> <%= note.author_name %> </td> 
-    <% else %> 
-      <td><%= link_to h(note.author_name), :controller => "user", :action => "view", :display_name => note.author_name %></td>
-    <% end %>
-    <td> <%= note.comments.first.body.to_html  %> </td>        
-    <td><%= l note.created_at %></td>
-    <td><%= l note.updated_at %></td>
+    <td><%= link_to note.id, browse_note_path(note) %></td>
+    <td><%= note_author(note.author) %></td>
+    <td><%= note.comments.first.body.to_html %></td>
+    <td><%= t ".ago_html", :when => friendly_date(note.created_at) %></td>
+    <td><%= t ".ago_html", :when => friendly_date(note.updated_at) %></td>
   </tr>
 <% end -%>
 </table>
 
-<%= render :partial => 'notes_paging_nav' %>
+<%= render :partial => "notes_paging_nav" %>