Fix most auto-correctable rubocop issues

[rails.git] / app / models / old_relation.rb

diff --git a/app/models/old_relation.rb b/app/models/old_relation.rb
index dc89afa50294ba35710123aa382243676f04c282..8e0727743dd88ffa48b9d7c506bec0e1f35ec3b6 100644 (file)
--- a/app/models/old_relation.rb
+++ b/app/models/old_relation.rb
@@ -1,7 +1,7 @@
 class OldRelation < ActiveRecord::Base
   include ConsistencyValidations
   include ObjectMetadata
 class OldRelation < ActiveRecord::Base
   include ConsistencyValidations
   include ObjectMetadata

-  
+

   self.table_name = "relations"
   self.primary_keys = "relation_id", "version"
 
   self.table_name = "relations"
   self.primary_keys = "relation_id", "version"
 


@@ -15,7 +15,7 @@ class OldRelation < ActiveRecord::Base
 
   has_many :old_members, -> { order(:sequence_id) }, :class_name => 'OldRelationMember', :foreign_key => [:relation_id, :version]
   has_many :old_tags, :class_name => 'OldRelationTag', :foreign_key => [:relation_id, :version]
 
   has_many :old_members, -> { order(:sequence_id) }, :class_name => 'OldRelationMember', :foreign_key => [:relation_id, :version]
   has_many :old_tags, :class_name => 'OldRelationTag', :foreign_key => [:relation_id, :version]

-  
+

   validates_associated :changeset
 
   def self.from_relation(relation)
   validates_associated :changeset
 
   def self.from_relation(relation)


@@ -27,31 +27,24 @@ class OldRelation < ActiveRecord::Base
     old_relation.version = relation.version
     old_relation.members = relation.members
     old_relation.tags = relation.tags
     old_relation.version = relation.version
     old_relation.members = relation.members
     old_relation.tags = relation.tags

-    return old_relation
+    old_relation

   end
 
   def save_with_dependencies!
   end
 
   def save_with_dependencies!

-
-    # see comment in old_way.rb ;-)

     save!
     save!

-    clear_aggregation_cache
-    clear_association_cache
-    @attributes.update(OldRelation.where(:relation_id => self.relation_id, :timestamp => self.timestamp).order("version DESC").first.instance_variable_get('@attributes'))
-
-    # ok, you can touch from here on

 
 

-    self.tags.each do |k,v|
+    tags.each do |k, v|

       tag = OldRelationTag.new
       tag.k = k
       tag.v = v
       tag = OldRelationTag.new
       tag.k = k
       tag.v = v

-      tag.relation_id = self.relation_id
-      tag.version = self.version
+      tag.relation_id = relation_id
+      tag.version = version

       tag.save!
     end
 
       tag.save!
     end
 

-    self.members.each_with_index do |m,i|
+    members.each_with_index do |m, i|

       member = OldRelationMember.new
       member = OldRelationMember.new

-      member.id = [self.relation_id, self.version, i]
+      member.id = [relation_id, version, i]

       member.member_type = m[0].classify
       member.member_id = m[1]
       member.member_role = m[2]
       member.member_type = m[0].classify
       member.member_id = m[1]
       member.member_role = m[2]


@@ -60,66 +53,62 @@ class OldRelation < ActiveRecord::Base
   end
 
   def members
   end
 
   def members

-    @members ||= self.old_members.collect do |member|
+    @members ||= old_members.collect do |member|

       [member.member_type, member.member_id, member.member_role]
     end
   end
 
   def tags
       [member.member_type, member.member_id, member.member_role]
     end
   end
 
   def tags

-    @tags ||= Hash[self.old_tags.collect { |t| [t.k, t.v] }]
+    @tags ||= Hash[old_tags.collect { |t| [t.k, t.v] }]

   end
 
   end
 

-  def members=(s)
-    @members = s
-  end
+  attr_writer :members

 
 

-  def tags=(t)
-    @tags = t
-  end
+  attr_writer :tags

 
   def to_xml
     doc = OSM::API.new.get_xml_doc
 
   def to_xml
     doc = OSM::API.new.get_xml_doc

-    doc.root << to_xml_node()
-    return doc
+    doc.root << to_xml_node
+    doc

   end
 
   def to_xml_node(changeset_cache = {}, user_display_name_cache = {})
     el = XML::Node.new 'relation'
   end
 
   def to_xml_node(changeset_cache = {}, user_display_name_cache = {})
     el = XML::Node.new 'relation'

-    el['id'] = self.relation_id.to_s
+    el['id'] = relation_id.to_s

 
     add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
 
 
     add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
 

-    self.old_members.each do |member|
+    old_members.each do |member|

       member_el = XML::Node.new 'member'
       member_el['type'] = member.member_type.to_s.downcase
       member_el['ref'] = member.member_id.to_s # "id" is considered uncool here as it should be unique in XML
       member_el['role'] = member.member_role.to_s
       el << member_el
     end
       member_el = XML::Node.new 'member'
       member_el['type'] = member.member_type.to_s.downcase
       member_el['ref'] = member.member_id.to_s # "id" is considered uncool here as it should be unique in XML
       member_el['role'] = member.member_role.to_s
       el << member_el
     end

-    
-    add_tags_to_xml_node(el, self.old_tags)

 
 

-    return el
+    add_tags_to_xml_node(el, old_tags)
+
+    el

   end
 
   # Temporary method to match interface to nodes
   def tags_as_hash
   end
 
   # Temporary method to match interface to nodes
   def tags_as_hash

-    return self.tags
+    tags

   end
 
   # Temporary method to match interface to relations
   def relation_members
   end
 
   # Temporary method to match interface to relations
   def relation_members

-    return self.old_members
+    old_members

   end
 
   # Pretend we're not in any relations
   def containing_relation_members
   end
 
   # Pretend we're not in any relations
   def containing_relation_members

-    return []
+    []

   end
 
   # check whether this element is the latest version - that is,
   # has the same version as its "current" counterpart.
   def is_latest_version?
   end
 
   # check whether this element is the latest version - that is,
   # has the same version as its "current" counterpart.
   def is_latest_version?

-    current_relation.version == self.version
+    current_relation.version == version

   end
 end
   end
 end