Avoid making the map scroll when adding a new note

[rails.git] / app / assets / javascripts / index / notes.js.erb

diff --git a/app/assets/javascripts/index/notes.js.erb b/app/assets/javascripts/index/notes.js.erb
index 154c6026df47f279cf3d92eab7bba7f8f1daaa7d..43374012963f271c4084cc5320b51c7dcdf89679 100644 (file)
--- a/app/assets/javascripts/index/notes.js.erb
+++ b/app/assets/javascripts/index/notes.js.erb
@@ -67,36 +67,52 @@ $(document).ready(function () {
     return marker;
   }
 
+  var noteLoader;
+
   function loadNotes() {
     var bounds = map.getBounds();
-    var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" + bounds.toBBOX();
+    var size = bounds.getSize();
 
-    $.ajax({
-      url: url,
-      success: function (json) {
-        var oldNotes = notes;
+    if (size <= OSM.MAX_NOTE_REQUEST_AREA) {
+      var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" + bounds.toBBOX();
+
+      if (noteLoader) noteLoader.abort();
+
+      noteLoader = $.ajax({
+        url: url,
+        success: function (json) {
+          var oldNotes = notes;
+
+          notes = {};
 
-        notes = {};
+          json.features.forEach(function (feature) {
+            var marker = oldNotes[feature.properties.id];
 
-        json.features.forEach(function (feature) {
-          var marker = oldNotes[feature.properties.id];
+            delete oldNotes[feature.properties.id];
 
-          delete oldNotes[feature.properties.id];
+            notes[feature.properties.id] = updateMarker(marker, feature);
+          });
 
-          notes[feature.properties.id] = updateMarker(marker, feature);
-        });
+          for (id in oldNotes) {
+            noteLayer.removeLayer(oldNotes[id]);
+          }
 
-        for (id in oldNotes) {
-          noteLayer.removeLayer(oldNotes[id]);
+          noteLoader = null;
         }
-      }
-    });
+      });
+    }
   };
 
   function popupOptions() {
     var mapSize = map.getSize();
 
-    return { maxHeight: mapSize.y * 2 / 3 };
+    return { 
+      minWidth: 320,
+      maxWidth: mapSize.y * 1 / 3, 
+      maxHeight: mapSize.y * 2 / 3, 
+      offset: new L.Point(0, -3),
+      autoPanPadding: new L.Point(60, 40)
+    };
   }
 
   function createPopupContent(marker, properties) {
@@ -164,9 +180,27 @@ $(document).ready(function () {
   $("#createnoteanchor").click(function (e) {
     e.preventDefault();
 
+    if ($(e.target).hasClass("disabled")) return;
+
     map.addLayer(noteLayer);
 
-    var marker = L.marker(map.getCenter(), {
+    var mapSize = map.getSize();
+    var markerPosition;
+
+    if (mapSize.y > 800)
+    {
+      markerPosition = [mapSize.x / 2, mapSize.y / 2];
+    }
+    else if (mapSize.y > 400)
+    {
+      markerPosition = [mapSize.x / 2, 400];
+    }
+    else
+    {
+      markerPosition = [mapSize.x / 2, mapSize.y];
+    }
+
+    var marker = L.marker(map.containerPointToLatLng(markerPosition), {
       icon: noteIcons["new"],
       opacity: 0.7,
       draggable: true