Fix most auto-correctable rubocop issues

[rails.git] / lib / daemons / gpx_import.rb

diff --git a/lib/daemons/gpx_import.rb b/lib/daemons/gpx_import.rb
index e80a519446b283cd82b277712db1c09f15551694..c257c1bfcab1c443ec96c6917a4f1324e46f4fd9 100755 (executable)
--- a/lib/daemons/gpx_import.rb
+++ b/lib/daemons/gpx_import.rb
@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-#You might want to change this
-#ENV["RAILS_ENV"] ||= "development"
+# You might want to change this
+# ENV["RAILS_ENV"] ||= "development"
 
 require File.dirname(__FILE__) + "/../../config/environment"
 
@@ -9,11 +9,11 @@ terminated = false
 
 logger = ActiveRecord::Base.logger
 
-while(true) do
+loop do
   ActiveRecord::Base.logger.info("GPX Import daemon wake @ #{Time.now}.")
 
-  Trace.find(:all, :conditions => 'inserted = 0').each do |trace|
-    Signal.trap("TERM") do 
+  Trace.find(:all, :conditions => { :inserted => false, :visible => true }, :order => "id").each do |trace|
+    Signal.trap("TERM") do
       terminated = true
     end
 
@@ -21,16 +21,16 @@ while(true) do
       gpx = trace.import
 
       if gpx.actual_points > 0
-        Notifier::deliver_gpx_success(trace, gpx.actual_points)
+        Notifier.gpx_success(trace, gpx.actual_points).deliver
       else
+        Notifier.gpx_failure(trace, '0 points parsed ok. Do they all have lat,lng,alt,timestamp?').deliver
         trace.destroy
-        Notifier::deliver_gpx_failure(trace, '0 points parsed ok. Do they all have lat,lng,alt,timestamp?')
       end
     rescue Exception => ex
       logger.info ex.to_s
-      ex.backtrace.each {|l| logger.info l }
+      ex.backtrace.each { |l| logger.info l }
+      Notifier.gpx_failure(trace, ex.to_s + "\n" + ex.backtrace.join("\n")).deliver
       trace.destroy
-      Notifier::deliver_gpx_failure(trace, ex.to_s + "\n" + ex.backtrace.join("\n"))
     end
 
     Signal.trap("TERM", "DEFAULT")
@@ -38,8 +38,8 @@ while(true) do
     exit if terminated
   end
 
-  Trace.find(:all, :conditions => 'visible = 0').each do |trace|
-    Signal.trap("TERM") do 
+  Trace.find(:all, :conditions => { :visible => false }, :order => "id").each do |trace|
+    Signal.trap("TERM") do
       terminated = true
     end
 
@@ -47,7 +47,7 @@ while(true) do
       trace.destroy
     rescue Exception => ex
       logger.info ex.to_s
-      ex.backtrace.each {|l| logger.info l }
+      ex.backtrace.each { |l| logger.info l }
     end
 
     Signal.trap("TERM", "DEFAULT")
@@ -55,5 +55,5 @@ while(true) do
     exit if terminated
   end
 
-  sleep 5.minutes
+  sleep 5.minutes.value
 end