Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509

[rails.git] / app / models / old_node.rb

diff --git a/app/models/old_node.rb b/app/models/old_node.rb
index c63738fc48e3b8e4a89c8fbf5c425a6905d67b32..b103e5c7310160033f1d733029b26f5a29da50d7 100644 (file)
--- a/app/models/old_node.rb
+++ b/app/models/old_node.rb
@@ -1,72 +1,106 @@
 class OldNode < ActiveRecord::Base
-  set_table_name 'nodes'
-  
-  validates_presence_of :user_id, :timestamp
-  validates_inclusion_of :visible, :in => [ true, false ]
-  validates_numericality_of :latitude, :longitude
+  include GeoRecord
+  include ConsistencyValidations
+  include ObjectMetadata
+
+  self.table_name = "nodes"
+  self.primary_keys = "node_id", "version"
+
+  # note this needs to be included after the table name changes, or
+  # the queries generated by Redactable will use the wrong table name.
+  include Redactable
+
+  validates :changeset, :presence => true, :associated => true
+  validates :latitude, :presence => true,
+                       :numericality => { :integer_only => true }
+  validates :longitude, :presence => true,
+                        :numericality => { :integer_only => true }
+  validates :timestamp, :presence => true
+  validates :visible, :inclusion => [true, false]
+
   validate :validate_position
 
-  belongs_to :user
- 
-  before_save :update_tile
+  belongs_to :changeset
+  belongs_to :redaction
+  belongs_to :current_node, :class_name => "Node", :foreign_key => "node_id"
 
-  def self.find_by_area(minlat, minlon, maxlat, maxlon, options)
-    self.with_scope(:find => {:conditions => OSM.sql_for_area(minlat, minlon, maxlat, maxlon)}) do
-      return self.find(:all, options)
-    end
+  has_many :old_tags, :class_name => "OldNodeTag", :foreign_key => [:node_id, :version]
+
+  def validate_position
+    errors.add(:base, "Node is not in the world") unless in_world?
   end
 
-  def update_tile
-    self.tile = QuadTile.tile_for_point(lat, lon)
+  def self.from_node(node)
+    old_node = OldNode.new
+    old_node.latitude = node.latitude
+    old_node.longitude = node.longitude
+    old_node.visible = node.visible
+    old_node.tags = node.tags
+    old_node.timestamp = node.timestamp
+    old_node.changeset_id = node.changeset_id
+    old_node.node_id = node.id
+    old_node.version = node.version
+    old_node
   end
 
-  def lat=(l)
-    self.latitude = (l * 10000000).round
+  def to_xml
+    doc = OSM::API.new.get_xml_doc
+    doc.root << to_xml_node
+    doc
   end
 
-  def lon=(l)
-    self.longitude = (l * 10000000).round
+  def to_xml_node(changeset_cache = {}, user_display_name_cache = {})
+    el = XML::Node.new "node"
+    el["id"] = node_id.to_s
+
+    add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
+
+    if visible?
+      el["lat"] = lat.to_s
+      el["lon"] = lon.to_s
+    end
+
+    add_tags_to_xml_node(el, old_tags)
+
+    el
   end
 
-  def lat
-    return self.latitude.to_f / 10000000
+  def save_with_dependencies!
+    save!
+
+    tags.each do |k, v|
+      tag = OldNodeTag.new
+      tag.k = k
+      tag.v = v
+      tag.node_id = node_id
+      tag.version = version
+      tag.save!
+    end
   end
 
-  def lon
-    return self.longitude.to_f / 10000000
+  def tags
+    @tags ||= Hash[old_tags.collect { |t| [t.k, t.v] }]
   end
 
-  def validate_position
-    errors.add_to_base("Node is not in the world") unless in_world?
+  attr_writer :tags
+
+  def tags_as_hash
+    tags
   end
 
-  def in_world?
-    return false if self.lat < -90 or self.lat > 90
-    return false if self.lon < -180 or self.lon > 180
-    return true
+  # Pretend we're not in any ways
+  def ways
+    []
   end
 
-  def self.from_node(node)
-    old_node = OldNode.new
-    old_node.latitude = node.latitude
-    old_node.longitude = node.longitude
-    old_node.visible = node.visible
-    old_node.tags = node.tags
-    old_node.timestamp = node.timestamp
-    old_node.user_id = node.user_id
-    old_node.id = node.id
-    return old_node
+  # Pretend we're not in any relations
+  def containing_relation_members
+    []
   end
 
-  def to_xml_node
-    el1 = XML::Node.new 'node'
-    el1['id'] = self.id.to_s
-    el1['lat'] = self.lat.to_s
-    el1['lon'] = self.lon.to_s
-    el1['user'] = self.user.display_name if self.user.data_public?
-    Node.split_tags(el1, self.tags)
-    el1['visible'] = self.visible.to_s
-    el1['timestamp'] = self.timestamp.xmlschema
-    return el1
+  # check whether this element is the latest version - that is,
+  # has the same version as its "current" counterpart.
+  def is_latest_version?
+    current_node.version == version
   end
 end