Fix exception handling in GPX importer.
[rails.git] / lib / daemons / gpx_import.rb
index 82232e496c3e47ae5bf2a94bd911d7a12b7eb7d8..ba76d60f0bcb90142ea1df0512d92028ba3b6b50 100755 (executable)
@@ -5,97 +5,38 @@
 
 require File.dirname(__FILE__) + "/../../config/environment"
 
-$running = true;
-Signal.trap("TERM") do 
-  $running = false
-end
+terminated = false
 
 logger = ActiveRecord::Base.logger
 
-while($running) do
-
+while(true) do
   ActiveRecord::Base.logger.info("GPX Import daemon wake @ #{Time.now}.")
 
-  traces = Trace.find(:all, :conditions => ['inserted = ?', false])
-
-  if traces and traces.length > 0
-    traces.each do |trace|
-      begin
-
-        logger.info("GPX Import importing #{trace.name} (#{trace.id}) from #{trace.user.email}")
-        \r
-        # TODO *nix specific, could do to work on windows... would be functionally inferior though - check for '.gz'
-        gzipped = `file -b /home/osm/gpx/#{trace.id}.gpx`.chomp =~/^gzip/\r
-
-        if gzipped
-          logger.info("gzipped")
-        else
-          logger.info("not gzipped")
-        end
-
-        gpx = OSM::GPXImporter.new("/home/osm/gpx/#{trace.id}.gpx")
-
-        f_lat = 0
-        f_lon = 0
-        first = true
-
-        gpx.points do |point|
-          if first
-            f_lat = point['latitude']
-            f_lon = point['longitude']
-          end
-
-          tp = Tracepoint.new
-          tp.lat = point['latitude'].to_f
-          tp.lng = point['longitude'].to_f
-          tp.altitude = point['altitude'].to_f
-          tp.user_id = trace.user.id
-          tp.gpx_id = trace.id
-          tp.trackid = point['segment'].to_i
-          tp.save!
-        end
-
-        if gpx.actual_points > 0
-          max_lat = Tracepoint.maximum('latitude', :conditions => ['gpx_id = ?', trace.id])
-          min_lat = Tracepoint.minimum('latitude', :conditions => ['gpx_id = ?', trace.id])
-          max_lon = Tracepoint.maximum('longitude', :conditions => ['gpx_id = ?', trace.id])
-          min_lon = Tracepoint.minimum('longitude', :conditions => ['gpx_id = ?', trace.id])
-
-          max_lat = max_lat.to_f / 1000000
-          min_lat = min_lat.to_f / 1000000
-          max_lon = max_lon.to_f / 1000000
-          min_lon = min_lon.to_f / 1000000
-
-          trace.latitude = f_lat
-          trace.longitude = f_lon
-          trace.large_picture = gpx.get_picture(min_lat, min_lon, max_lat, max_lon, gpx.actual_points)
-          trace.icon_picture = gpx.get_icon(min_lat, min_lon, max_lat, max_lon)
-          trace.size = gpx.actual_points
-          trace.inserted = true
-          trace.save
+  Trace.find(:all, :conditions => ['inserted = ?', false]).each do |trace|
+    Signal.trap("TERM") do 
+      terminated = true
+    end
 
-          logger.info "done trace #{trace.id}"
-          Notifier::deliver_gpx_success(trace, gpx.possible_points)
-        else
-          `rm /home/osm/gpx/#{trace.id}.gpx`
-          trace.destroy
-          Notifier::deliver_gpx_failure(trace, '0 points parsed ok. Do they all have lat,lng,alt,timestamp?')
-        end
+    begin
+      gpx = trace.import
 
-      rescue Exception => ex
-        logger.info ex
-        ex.backtrace.each {|l| logger.info l }
-          `rm /home/osm/gpx/#{trace.id}.gpx`
-          trace.destroy
-          Notifier::deliver_gpx_failure(trace, ex.to_s + ex.backtrace.join("\n") )
+      if gpx.actual_points > 0
+        Notifier::deliver_gpx_success(trace, gpx.actual_points)
+      else
+        trace.destroy
+        Notifier::deliver_gpx_failure(trace, '0 points parsed ok. Do they all have lat,lng,alt,timestamp?')
       end
+    rescue Exception => ex
+      logger.info ex.to_s
+      ex.backtrace.each {|l| logger.info l }
+      trace.destroy
+      Notifier::deliver_gpx_failure(trace, ex.to_s + "\n" + ex.backtrace.join("\n"))
     end
-  end
 
-  Trace.find(:all, :conditions => ['inserted = ?', false]).each do |trace|
-     `rm /home/osm/gpx/#{trace.id}.gpx`
-     trace.destroy
+    Signal.trap("TERM", "DEFAULT")
+
+    exit if terminated
   end
-  exit
-  sleep 15.minutes
+
+  sleep 5.minutes
 end