Don't show lat/lon for a deleted node, in case it is redacted

[rails.git] / app / views / browse / _common_details.html.erb

diff --git a/app/views/browse/_common_details.html.erb b/app/views/browse/_common_details.html.erb
index 07b44a94a7d1515c537a7d2c1c2bc346115b199a..971e467aa02c7c66622e80bf14837ed7354f59c7 100644 (file)
--- a/app/views/browse/_common_details.html.erb
+++ b/app/views/browse/_common_details.html.erb
@@ -1,38 +1,33 @@
-<tr>
-  <% if common_details.visible? %>
-    <th><%= t 'browse.common_details.edited_at' %></th>
+<h4>
+  <% if common_details.changeset.tags['comment'].present? %>
+    <%= linkify(h(common_details.changeset.tags['comment'])) %>
   <% else %>
-    <th><%= t 'browse.common_details.deleted_at' %></th>
+    <%= t 'browse.no_comment' %>
   <% end %>
-  <td><%= l common_details.timestamp %></td>
-</tr>
+</h4>
 
-<% if common_details.changeset.user.data_public? %>
-  <tr>
-    <% if common_details.visible? %>
-      <th><%= t 'browse.common_details.edited_by' %></th>
-    <% else %>
-      <th><%= t 'browse.common_details.deleted_by' %></th>
-    <% end %>
-    <td><%= link_to h(common_details.changeset.user.display_name), :controller => "user", :action => "view", :display_name => common_details.changeset.user.display_name %></td>
-  </tr>
-<% end %>
-
-<tr>
-  <th><%= t 'browse.common_details.version' %></th>
-  <td><%= h(common_details.version) %></td>
-</tr>
+<div class="details">
+  <%=
+      t "browse.#{common_details.visible? ? :edited : :deleted}_by_html",
+        :time => distance_of_time_in_words_to_now(common_details.timestamp),
+        :user => changeset_user_link(common_details.changeset),
+        :title => l(common_details.timestamp)
+  %>
+</div>
 
-<tr>
-  <th><%= t 'browse.common_details.in_changeset' %></th>
-  <td><%= link_to common_details.changeset_id, :action => :changeset, :id => common_details.changeset_id %></td>
-</tr>
+<div class="details">
+  <%= t 'browse.version' %>
+  #<%= h(common_details.version) %>
+  &middot;
+  <%= t 'browse.in_changeset' %>
+  #<%= link_to common_details.changeset_id, :action => :changeset, :id => common_details.changeset_id %>
+</div>
 
-<% if common_details.changeset.tags['comment'] %>
-  <tr>
-    <th><%= t 'browse.common_details.changeset_comment' %></th>
-    <td><%= linkify(h(common_details.changeset.tags['comment'])) %></td>
-  </tr>
+<% if @type == "node" and common_details.visible? %>
+<div class="details geo">
+  <%= t 'browse.location' %>
+  <%= link_to(content_tag(:span, number_with_delimiter(common_details.lat), :class => "latitude") + ", " + content_tag(:span, number_with_delimiter(common_details.lon), :class => "longitude"), {:controller => 'site', :action => 'index', :lat => h(common_details.lat), :lon => h(common_details.lon), :zoom => "18"}) %>
+</div>
 <% end %>
 
-<%= render :partial => "tag_details", :object => common_details %>
+<%= render :partial => "tag_details", :object => common_details.tags %>