X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/067b0de4391a32124aef23c56d73e2bb492df8ca..71cb2c50fcaf29e2b933fc981e40a00223d94d34:/test/helpers/browse_tags_helper_test.rb?ds=sidebyside
diff --git a/test/helpers/browse_tags_helper_test.rb b/test/helpers/browse_tags_helper_test.rb
index 3f36b9210..f47c215c0 100644
--- a/test/helpers/browse_tags_helper_test.rb
+++ b/test/helpers/browse_tags_helper_test.rb
@@ -22,6 +22,15 @@ class BrowseTagsHelperTest < ActionView::TestCase
html = format_value("unknown", "unknown")
assert_dom_equal "unknown", html
+ html = format_value("unknown", "abc;def")
+ assert_dom_equal "abc;def", html
+
+ html = format_value("unknown", "foo;")
+ assert_dom_equal "foo;", html
+
+ html = format_value("addr:street", "Rue de l'Amigo")
+ assert_dom_equal "Rue de l'Amigo", html
+
html = format_value("phone", "+1234567890")
assert_dom_equal "+1234567890", html
@@ -45,10 +54,18 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_dom_equal "File:Test.jpg", html
html = format_value("colour", "#f00")
- assert_dom_equal %(#f00), html
+ dom = Rails::Dom::Testing.html_document_fragment.parse html
+ assert_select dom, "svg>rect>@fill", "#f00"
+ assert_match(/#f00$/, html)
- html = format_value("contact", "foo@example.com")
+ html = format_value("email", "foo@example.com")
assert_dom_equal "foo@example.com", html
+
+ html = format_value("source", "https://example.com")
+ assert_dom_equal "https://example.com", html
+
+ html = format_value("source", "https://example.com;hello;https://example.net")
+ assert_dom_equal "https://example.com;hello;https://example.net", html
end
def test_wiki_link
@@ -123,6 +140,15 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "//www.wikidata.org/entity/Q24?uselang=en", links[0][:url]
assert_equal "Q24", links[0][:title]
+ # This verified buried is working
+ links = wikidata_links("buried:wikidata", "Q24")
+ assert_equal "//www.wikidata.org/entity/Q24?uselang=en", links[0][:url]
+ assert_equal "Q24", links[0][:title]
+
+ links = wikidata_links("species:wikidata", "Q26899")
+ assert_equal "//www.wikidata.org/entity/Q26899?uselang=en", links[0][:url]
+ assert_equal "Q26899", links[0][:title]
+
# Another allowed key, this time with multiple values and I18n
I18n.with_locale "dsb" do
links = wikidata_links("brand:wikidata", "Q936;Q2013;Q1568346")
@@ -185,6 +211,10 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "zh-classical:Test#Section", link[:title]
end
+ link = wikipedia_link("subject:wikipedia", "en:Catherine McAuley")
+ assert_equal "https://en.wikipedia.org/wiki/en:Catherine McAuley?uselang=en", link[:url]
+ assert_equal "en:Catherine McAuley", link[:title]
+
link = wikipedia_link("foo", "Test")
assert_nil link
end
@@ -260,6 +290,12 @@ class BrowseTagsHelperTest < ActionView::TestCase
# Strips whitespace at ends
email = email_link("email", " test@email.com ")
assert_equal "test@email.com", email
+
+ email = email_link("contact:email", "example@example.com")
+ assert_equal "example@example.com", email
+
+ email = email_link("maxweight:conditional", "none@agricultural")
+ assert_nil email
end
def test_telephone_links