X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/0e2a66e8de55b3719bd307261058b7f898598994..847536c80dbd1f8a0b4e0c0f803e80407e00e4b1:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1baaf0ab6..6b080f113 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2020-08-06 17:20:38 UTC using RuboCop version 0.89.0. +# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -18,7 +18,7 @@ require: # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 370 + Max: 250 # Offense count: 36 # Configuration parameters: AllowSafeAssignment. @@ -33,19 +33,12 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 20 -Lint/MissingSuper: - Exclude: - - 'config/initializers/oauth.rb' - - 'lib/osm.rb' - - 'lib/session_persistence.rb' - # Offense count: 682 # Configuration parameters: IgnoredMethods. Metrics/AbcSize: @@ -65,7 +58,7 @@ Metrics/BlockNesting: # Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 645 + Max: 643 # Offense count: 68 # Configuration parameters: IgnoredMethods. @@ -87,6 +80,25 @@ Metrics/ParameterLists: Metrics/PerceivedComplexity: Max: 26 +# Offense count: 540 +Minitest/MultipleAssertions: + Max: 81 + +# Offense count: 26 +# Cop supports --auto-correct. +Minitest/TestMethodName: + Exclude: + - 'test/abilities/api_capability_test.rb' + - 'test/controllers/api/nodes_controller_test.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' + - 'test/helpers/browse_helper_test.rb' + - 'test/integration/client_applications_test.rb' + - 'test/integration/short_links_test.rb' + - 'test/integration/user_blocks_test.rb' + - 'test/integration/user_creation_test.rb' + # Offense count: 6 Naming/AccessorMethodName: Exclude: @@ -153,11 +165,6 @@ Rails/OutputSafety: Exclude: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changesets_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' @@ -168,15 +175,6 @@ Rails/OutputSafety: Rails/TimeZone: Enabled: false -# Offense count: 6 -# Cop supports --auto-correct. -Style/ExplicitBlockArgument: - Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/mailers/notifier.rb' - - 'test/integration/client_applications_test.rb' - # Offense count: 572 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -206,7 +204,7 @@ Style/OptionalBooleanParameter: - 'test/models/trace_test.rb' - 'test/models/tracetag_test.rb' -# Offense count: 44 +# Offense count: 28 # Cop supports --auto-correct. Style/StringConcatenation: Enabled: false