X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/0e2a66e8de55b3719bd307261058b7f898598994..d516ba53357e8673ca35979de4a4ffc4ab142e00:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1baaf0ab6..c1060cbe2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2020-08-06 17:20:38 UTC using RuboCop version 0.89.0. +# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -18,7 +18,7 @@ require: # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 370 + Max: 250 # Offense count: 36 # Configuration parameters: AllowSafeAssignment. @@ -33,19 +33,12 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 20 -Lint/MissingSuper: - Exclude: - - 'config/initializers/oauth.rb' - - 'lib/osm.rb' - - 'lib/session_persistence.rb' - # Offense count: 682 # Configuration parameters: IgnoredMethods. Metrics/AbcSize: @@ -65,7 +58,7 @@ Metrics/BlockNesting: # Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 645 + Max: 643 # Offense count: 68 # Configuration parameters: IgnoredMethods. @@ -87,6 +80,10 @@ Metrics/ParameterLists: Metrics/PerceivedComplexity: Max: 26 +# Offense count: 540 +Minitest/MultipleAssertions: + Max: 81 + # Offense count: 6 Naming/AccessorMethodName: Exclude: @@ -153,11 +150,6 @@ Rails/OutputSafety: Exclude: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changesets_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' @@ -168,15 +160,6 @@ Rails/OutputSafety: Rails/TimeZone: Enabled: false -# Offense count: 6 -# Cop supports --auto-correct. -Style/ExplicitBlockArgument: - Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/mailers/notifier.rb' - - 'test/integration/client_applications_test.rb' - # Offense count: 572 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -189,24 +172,3 @@ Style/FrozenStringLiteralComment: # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 - -# Offense count: 20 -Style/OptionalBooleanParameter: - Exclude: - - 'app/controllers/api/notes_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/helpers/browse_helper.rb' - - 'app/models/changeset.rb' - - 'app/models/node.rb' - - 'app/models/relation.rb' - - 'app/models/trace.rb' - - 'app/models/tracepoint.rb' - - 'app/models/way.rb' - - 'test/models/diary_entry_test.rb' - - 'test/models/trace_test.rb' - - 'test/models/tracetag_test.rb' - -# Offense count: 44 -# Cop supports --auto-correct. -Style/StringConcatenation: - Enabled: false