X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/20aa4ba31b61a926c8fcb98f88c02f7d1cbeb655..b78bb9f6313f3139ac83784df52bf39a5619d3e7:/app/models/relation.rb

diff --git a/app/models/relation.rb b/app/models/relation.rb
index ed37d159a..b78c95ce4 100644
--- a/app/models/relation.rb
+++ b/app/models/relation.rb
@@ -281,15 +281,19 @@ class Relation < ActiveRecord::Base
   private
 
   def save_with_history!
+    t = Time.now.getutc
+
+    self.version += 1
+    self.timestamp = t
+
     Relation.transaction do
       # have to be a little bit clever here - to detect if any tags
       # changed then we have to monitor their before and after state.
       tags_changed = false
 
-      t = Time.now.getutc
-      self.version += 1
-      self.timestamp = t
-      save!
+      # clone the object before saving it so that the original is
+      # still marked as dirty if we retry the transaction
+      clone.save!
 
       tags = self.tags.clone
       relation_tags.each do |old_tag|
@@ -370,7 +374,7 @@ class Relation < ActiveRecord::Base
       # materially change the rest of the relation.
       any_relations =
         changed_members.collect { |_id, type| type == "relation" }
-                       .inject(false) { |a, e| a || e }
+                       .inject(false) { |acc, elem| acc || elem }
 
       update_members = if tags_changed || any_relations
                          # add all non-relation bounding boxes to the changeset