X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/20ae3232cd60b91ab284a068c1d4e452fca854b6..9c01c4cb639775f4f93f477546124247a33f80d2:/app/controllers/application.rb diff --git a/app/controllers/application.rb b/app/controllers/application.rb index fd6ea7866..acb2f9162 100644 --- a/app/controllers/application.rb +++ b/app/controllers/application.rb @@ -3,11 +3,19 @@ class ApplicationController < ActionController::Base def authorize_web - @user = User.find_by_token(session[:token]) + if session[:user] + @user = User.find(session[:user]) + elsif session[:token] + @user = User.authenticate(:token => session[:token]) + session[:user] = @user.id + end + rescue Exception => ex + logger.info("Exception authorizing user: #{ex.to_s}") + @user = nil end def require_user - redirect_to :controller => 'user', :action => 'login' unless @user + redirect_to :controller => 'user', :action => 'login', :referer => request.request_uri unless @user end def authorize(realm='Web Password', errormessage="Couldn't authenticate you") @@ -16,41 +24,51 @@ class ApplicationController < ActionController::Base if username.nil? @user = nil # no authentication provided - perhaps first connect (client should retry after 401) elsif username == 'token' - @user = User.authenticate_token(passwd) # preferred - random token for user from db, passed in basic auth + @user = User.authenticate(:token => passwd) # preferred - random token for user from db, passed in basic auth else - @user = User.authenticate(username, passwd) # basic auth + @user = User.authenticate(:username => username, :password => passwd) # basic auth end - + # handle authenticate pass/fail - if @user - # user exists and password is correct ... horray! - if @user.methods.include? 'lastlogin' # note last login - @session['lastlogin'] = user.lastlogin - @user.last.login = Time.now - @user.save() - @session["User.id"] = @user.id - end - else + unless @user # no auth, the user does not exist or the password was wrong response.headers["Status"] = "Unauthorized" response.headers["WWW-Authenticate"] = "Basic realm=\"#{realm}\"" - render_text(errormessage, 401) # :unauthorized + render :text => errormessage, :status => :unauthorized + return false end end + def check_read_availability + if API_STATUS == :offline + response.headers['Error'] = "Database offline for maintenance" + render :nothing => true, :status => :service_unavailable + return false + end + end + + def check_write_availability + if API_STATUS == :offline or API_STATUS == :readonly + response.headers['Error'] = "Database offline for maintenance" + render :nothing => true, :status => :service_unavailable + return false + end + end + # Report and error to the user # (If anyone ever fixes Rails so it can set a http status "reason phrase", # rather than only a status code and having the web engine make up a # phrase from that, we can also put the error message into the status # message. For now, rails won't let us) def report_error(message) - render :nothing => true, :status => 400 + render :nothing => true, :status => :bad_request # Todo: some sort of escaping of problem characters in the message response.headers['Error'] = message end +private + # extract authorisation credentials from headers, returns user = nil if none - private def get_auth_data if request.env.has_key? 'X-HTTP_AUTHORIZATION' # where mod_rewrite might have put it authdata = request.env['X-HTTP_AUTHORIZATION'].to_s.split @@ -59,7 +77,7 @@ class ApplicationController < ActionController::Base end # only basic authentication supported if authdata and authdata[0] == 'Basic' - user, pass = Base64.decode64(authdata[1]).split(':')[0..1] + user, pass = Base64.decode64(authdata[1]).split(':',2) end return [user, pass] end