X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/2198b6ebbf46cdad39b75a461b9a72e5cde93c3a..edd6235b45164bff20cbe8f2a0c9d10027211cf4:/app/assets/javascripts/routing.js.erb diff --git a/app/assets/javascripts/routing.js.erb b/app/assets/javascripts/routing.js.erb index 30846479d..81cd3e7a1 100644 --- a/app/assets/javascripts/routing.js.erb +++ b/app/assets/javascripts/routing.js.erb @@ -7,7 +7,12 @@ https://github.com/apmon/openstreetmap-website/blob/9755c3ae0a8d0684d43760f91dc864ff42d8477a/app/views/routing/start.js.erb *** draggable start/end markers - + *** translation (including all alerts and presentation) + *** export GPX + *** URL history (or do we consciously not want to support that?) + + *** add YOURS engine + *** add GraphHopper engine */ var TURN_INSTRUCTIONS=["", @@ -36,16 +41,46 @@ var ROUTING_POLYLINE={ }; +OSM.RoutingEngines={ + list: [] + // common functions and constants, e.g. OSRM parser, can go here +}; + OSM.Routing=function(map,name,jqSearch) { var r={}; + r.map=map; // Leaflet map r.name=name; // global variable name of this instance (needed for JSONP) r.jqSearch=jqSearch; // JQuery object for search panel - r.route_from=null; - r.route_to=null; - r.viaPoints=[]; - r.polyline=null; + r.route_from=null; // null=unset, false=awaiting response, [lat,lon]=geocoded + r.route_to=null; // | + r.awaitingGeocode=false;// true if the user has requested a route, but we're waiting on a geocode result + r.viaPoints=[]; // not yet used + + r.polyline=null; // Leaflet polyline object + r.popup=null; // Leaflet popup object + r.marker_from=null; // Leaflet from marker + r.marker_to=null; // Leaflet to marker + + r.chosenEngine=null; // currently selected routing engine + + var icon_from = L.icon({ + iconUrl: <%= asset_path('marker-green.png').to_json %>, + iconSize: [25, 41], + iconAnchor: [12, 41], + popupAnchor: [1, -34], + shadowUrl: <%= asset_path('images/marker-shadow.png').to_json %>, + shadowSize: [41, 41] + }); + var icon_to = L.icon({ + iconUrl: <%= asset_path('marker-red.png').to_json %>, + iconSize: [25, 41], + iconAnchor: [12, 41], + popupAnchor: [1, -34], + shadowUrl: <%= asset_path('images/marker-shadow.png').to_json %>, + shadowSize: [41, 41] + }); // Geocoding @@ -56,6 +91,7 @@ OSM.Routing=function(map,name,jqSearch) { var querystring = '<%= NOMINATIM_URL %>search?q=' + encodeURIComponent(v) + '&format=json'; // *** &accept-language=<%#= request.user_preferred_languages.join(',') %> // *** prefer current viewport + r[field.id]=false; $.getJSON(querystring, function(json) { _this._gotGeocode(json,field); }); }; @@ -68,16 +104,52 @@ OSM.Routing=function(map,name,jqSearch) { field.value=json[0].display_name; var lat=Number(json[0].lat), lon=Number(json[0].lon); r[field.id]=[lat,lon]; - // ** update markers + r.updateMarkers(field.id); + if (r.awaitingGeocode) { + r.awaitingGeocode=false; + r.requestRoute(); + } + }; + + // Drag and drop markers + + r.handleDrop=function(e) { + var id=e.originalEvent.dataTransfer.getData('id'); + var ll=r.map.mouseEventToLatLng(e.originalEvent); + // *** ^^^ this is slightly off - we need to work out the latLng of the tip + r.createMarker(ll,id); + // update to/from field + }; + r.createMarker=function(latlng,id) { + if (r[id]) r.map.removeLayer(r[id]); + r[id]=L.marker(latlng, { + icon: id=='marker_from' ? icon_from : icon_to, + draggable: true, + name: id + }).addTo(r.map); + r[id].on('drag',r.markerDragged); + r[id].on('dragend',r.markerDragged); + }; + r.updateMarkers=function(id) { + }; + r.markerDragged=function(e) { + // marker has been dragged + if (e.type=='drag' && !r.chosenEngine.draggable) return; + // *** also return if e.type=='drag' and not long enough since last request returned + // *** but always do if e.type=='dragend' + console.log(e.target.options.name); + console.log(e.target.getLatLng()); }; // Route-fetching UI r.requestRoute=function() { if (r.route_from && r.route_to) { - var chosen=jqSearch.find('select.routing_engines :selected').val(); - r.engines[chosen].getRoute(true,[r.route_from,r.route_to]); + r.chosenEngine.getRoute(true,[r.route_from,r.route_to]); // then, when the route has been fetched, it'll call the engine's gotRoute function + } else if (r.route_from==false || r.route_to==false) { + // we're waiting for a Nominatim response before we can request a route + r.awaitingGeocode=true; } }; @@ -85,75 +157,91 @@ OSM.Routing=function(map,name,jqSearch) { r.setPolyline=function(line) { if (r.polyline) map.removeLayer(r.polyline); r.polyline=L.polyline(line, ROUTING_POLYLINE).addTo(r.map); - // *** zoom to fit + r.map.fitBounds(r.polyline.getBounds()); }; - // Take an array of directions and write it out - // (we use OSRM's route_instructions format) - r.setItinerary=function(steps) { + // Take directions and write them out + // data = { steps: array of [latlng, sprite number, instruction text, distance in metres] } + // sprite numbers equate to OSRM's route_instructions turn values + // *** translations? + r.setItinerary=function(data) { + // Create base table $("#content").removeClass("overlay-sidebar"); $('#sidebar_content').empty(); - var html=""; - for (var i=0; i"); + row.append(" "); + row.append(""+step[2]); + row.append(""+dist); + with ({ num: i, ll: step[0] }) { + row.on('click',function(e) { r.clickTurn(num, ll); }); + }; + $('#turnbyturn').append(row); + cumulative+=step[3]; } - $('#sidebar_content').html(html); + }; + r.clickTurn=function(num,latlng) { + r.popup=L.popup().setLatLng(latlng).setContent("

"+(num+1)+"

").openOn(r.map); }; - - // Add engines + // Close all routing UI - r.engines=[]; - r.addEngine=function(engine) { - // Save engine - var i=r.engines.length; - engine.subscript=i; - r['engine'+i]=engine; - r.engines.push(engine); - - // Add generic JSONP function - engine.requestJSONP=function(url) { - var script = document.createElement('script'); - script.src = url+"&jsonp="+r.name+".engine"+this.subscript+".gotRoute"; - // OSRM doesn't like non-alphanumeric, otherwise we could just do OSM.routing.engines["+engine.subscript+"].gotRoute - document.body.appendChild(script); - }; - - // Populate dropdown - var select=jqSearch.find('select.routing_engines'); - select.append(""); + r.close=function() { + $("#content").addClass("overlay-sidebar"); + var remove=[r.polyline,r.popup,r.marker_from,r.marker_to]; + for (var i=0; ib.name; }); + var select=r.jqSearch.find('select.routing_engines'); + for (var i=0; i"+list[i].name+""); + } + r.engines=list; + r.chosenEngine=list[0]; // default to first engine + + // Choose an engine on dropdown change + r.selectEngine=function(e) { + r.chosenEngine=r.engines[e.target.selectedIndex]; + }; + // Choose an engine by name + r.chooseEngine=function(name) { + for (var i=0; i