X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/22005a38a696828c3c6ade4c49d7499afc06bc81..40647c53dff5f04f0ecfd4db891c4d3bf76b4a8d:/lib/consistency_validations.rb diff --git a/lib/consistency_validations.rb b/lib/consistency_validations.rb index 6e214f902..4f3881542 100644 --- a/lib/consistency_validations.rb +++ b/lib/consistency_validations.rb @@ -13,7 +13,7 @@ module ConsistencyValidations elsif new.changeset.user_id != user.id raise OSM::APIUserChangesetMismatchError.new elsif not new.changeset.is_open? - raise OSM::APIChangesetAlreadyClosedError.new + raise OSM::APIChangesetAlreadyClosedError.new(new.changeset) end end @@ -24,7 +24,22 @@ module ConsistencyValidations elsif new.changeset.user_id != user.id raise OSM::APIUserChangesetMismatchError.new elsif not new.changeset.is_open? - raise OSM::APIChangesetAlreadyClosedError.new + raise OSM::APIChangesetAlreadyClosedError.new(new.changeset) + end + end + + ## + # subset of consistency checks which should be applied to almost + # all the changeset controller's writable methods. + def check_changeset_consistency(changeset, user) + # check user credentials - only the user who opened a changeset + # may alter it. + if changeset.nil? + raise OSM::APIChangesetMissingError.new + elsif user.id != changeset.user_id + raise OSM::APIUserChangesetMismatchError.new + elsif not changeset.is_open? + raise OSM::APIChangesetAlreadyClosedError.new(changeset) end end end