X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/291f43c7e21832182df2d2eeb86ea8b5b7461f08..70d6880e10881dfd4b68f51cf16609a9f8aaff24:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 984529135..7232d199b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,95 +1,114 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2016-09-07 11:03:27 +0100 using RuboCop version 0.41.2. +# on 2018-09-19 14:24:02 +0100 using RuboCop version 0.58.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 34 -Lint/AmbiguousOperator: - Exclude: - - 'test/controllers/amf_controller_test.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - - 'test/lib/country_test.rb' - -# Offense count: 117 -Lint/AmbiguousRegexpLiteral: - Enabled: false - -# Offense count: 30 +# Offense count: 32 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - - 'app/controllers/trace_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_preference_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/controllers/user_preferences_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_helper.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' + - 'app/mailers/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 5 +# Offense count: 4 Lint/HandleExceptions: Exclude: - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' - - 'config/initializers/session.rb' + - 'app/controllers/users_controller.rb' -# Offense count: 2 -Lint/ShadowingOuterLocalVariable: - Exclude: - - 'app/views/changeset/list.atom.builder' - -# Offense count: 626 +# Offense count: 692 Metrics/AbcSize: - Max: 277 + Max: 283 + +# Offense count: 40 +# Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine +Metrics/BlockLength: + Max: 262 -# Offense count: 12 +# Offense count: 11 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 62 +# Offense count: 63 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1652 + Max: 1627 -# Offense count: 68 +# Offense count: 72 Metrics/CyclomaticComplexity: Max: 20 -# Offense count: 2561 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes. -# URISchemes: http, https -Metrics/LineLength: - Max: 962 - -# Offense count: 604 +# Offense count: 691 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 179 -# Offense count: 1 +# Offense count: 2 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 139 + Max: 135 # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 70 +# Offense count: 72 Metrics/PerceivedComplexity: Max: 23 +# Offense count: 6 +Naming/AccessorMethodName: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/title_helper.rb' + - 'app/models/old_way.rb' + - 'lib/osm.rb' + - 'lib/potlatch.rb' + +# Offense count: 8 +# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# NamePrefixBlacklist: is_, has_, have_ +# NameWhitelist: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'spec/**/*' + - 'app/models/changeset.rb' + - 'app/models/old_node.rb' + - 'app/models/old_relation.rb' + - 'app/models/old_way.rb' + - 'app/models/user.rb' + - 'lib/classic_pagination/pagination.rb' + +# Offense count: 6 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql, postgresql +# Include: db/migrate/*.rb +Rails/BulkChangeTable: + Exclude: + - 'db/migrate/20111116184519_update_oauth.rb' + - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' + - 'db/migrate/20120208194454_add_domain_to_acl.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' + # Offense count: 2 # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb @@ -106,10 +125,21 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 17 +# Offense count: 5 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' + +# Offense count: 20 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/changeset_helper.rb' - 'app/helpers/geocoder_helper.rb' @@ -120,74 +150,43 @@ Rails/OutputSafety: - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 65 -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Offense count: 86 +# Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 5 -Style/AccessorMethodName: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - - 'lib/osm.rb' - - 'lib/potlatch.rb' - # Offense count: 1 +# Configuration parameters: AllowedChars. Style/AsciiComments: Exclude: - 'test/models/message_test.rb' -# Offense count: 218 +# Offense count: 230 Style/Documentation: Enabled: false -# Offense count: 60 +# Offense count: 462 # Cop supports --auto-correct. -Style/LineEndConcatenation: - Exclude: - - 'db/migrate/008_remove_segments.rb' - - 'db/migrate/020_populate_node_tags_and_remove.rb' - - 'db/migrate/023_add_changesets.rb' - - 'lib/bounding_box.rb' - - 'lib/diff_reader.rb' - - 'lib/osm.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/controllers/node_controller_test.rb' - - 'test/controllers/relation_controller_test.rb' - - 'test/controllers/way_controller_test.rb' +# Configuration parameters: EnforcedStyle. +# SupportedStyles: when_needed, always, never +Style/FrozenStringLiteralComment: + Enabled: false -# Offense count: 69 +# Offense count: 2 # Cop supports --auto-correct. -Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. -# NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? -Style/PredicateName: +Style/IfUnlessModifier: Exclude: - - 'spec/**/*' - - 'app/models/changeset.rb' - - 'app/models/old_node.rb' - - 'app/models/old_relation.rb' - - 'app/models/old_way.rb' - - 'app/models/user.rb' - - 'lib/classic_pagination/pagination.rb' + - 'app/controllers/ways_controller.rb' -# Offense count: 97 +# Offense count: 70 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: compact, exploded -Style/RaiseArgs: - Enabled: false +# Configuration parameters: Strict. +Style/NumericLiterals: + MinDigits: 11 -# Offense count: 2 -# Cop supports --auto-correct. -Style/RescueModifier: - Exclude: - - 'app/helpers/browse_helper.rb' +# Offense count: 3080 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Metrics/LineLength: + Max: 1073