X-Git-Url: https://git.openstreetmap.org/rails.git/blobdiff_plain/3244635aa11878135a014cf2c9ec9177f8e9d0ba..314b734aa59ac762de09daacd08bbb952c94783d:/app/controllers/trace_controller.rb diff --git a/app/controllers/trace_controller.rb b/app/controllers/trace_controller.rb index 84026e8cd..99f11d546 100644 --- a/app/controllers/trace_controller.rb +++ b/app/controllers/trace_controller.rb @@ -11,6 +11,8 @@ class TraceController < ApplicationController before_filter :check_api_writable, :only => [:api_create] before_filter :require_allow_read_gpx, :only => [:api_details, :api_data] before_filter :require_allow_write_gpx, :only => [:api_create] + before_filter :offline_warning, :only => [:mine, :view] + before_filter :offline_redirect, :only => [:create, :edit, :delete, :data, :api_data, :api_create] around_filter :api_call_handle_error, :only => [:api_details, :api_data, :api_create] # Counts and selects pages of GPX traces for various criteria (by user, tags, public etc.). @@ -42,7 +44,7 @@ class TraceController < ApplicationController # four main cases: # 1 - all traces, logged in = all public traces + all user's (i.e + all mine) # 2 - all traces, not logged in = all public traces - # 3 - user's traces, logged in as same user = all user's traces + # 3 - user's traces, logged in as same user = all user's traces # 4 - user's traces, not logged in as that user = all user's public traces if target_user.nil? # all traces if @user @@ -57,7 +59,7 @@ class TraceController < ApplicationController conditions = ["gpx_files.visibility in ('public', 'identifiable') AND gpx_files.user_id = ?", target_user.id] #4 end end - + if params[:tag] @tag = params[:tag] @@ -69,7 +71,7 @@ class TraceController < ApplicationController conditions[0] += " AND 0 = 1" end end - + conditions[0] += " AND gpx_files.visible = ?" conditions << true @@ -89,7 +91,7 @@ class TraceController < ApplicationController end end end - + # final helper vars for view @action = action @display_name = target_user.display_name if target_user @@ -104,7 +106,7 @@ class TraceController < ApplicationController @trace.visibility = visibility.v elsif @user.preferences.find(:first, :conditions => {:k => "gps.trace.public", :v => "default"}).nil? @trace.visibility = "private" - else + else @trace.visibility = "public" end list(@user, "mine") @@ -117,11 +119,11 @@ class TraceController < ApplicationController (@trace.public? or @trace.user == @user) @title = t 'trace.view.title', :name => @trace.name else - flash[:notice] = t 'trace.view.trace_not_found' + flash[:error] = t 'trace.view.trace_not_found' redirect_to :controller => 'trace', :action => 'list' end rescue ActiveRecord::RecordNotFound - flash[:notice] = t 'trace.view.trace_not_found' + flash[:error] = t 'trace.view.trace_not_found' redirect_to :controller => 'trace', :action => 'list' end @@ -132,7 +134,8 @@ class TraceController < ApplicationController begin do_create(params[:trace][:gpx_file], params[:trace][:tagstring], params[:trace][:description], params[:trace][:visibility]) - rescue + rescue => ex + logger.debug ex end if @trace.id @@ -182,7 +185,7 @@ class TraceController < ApplicationController @trace.visibility = params[:trace][:visibility] if @trace.save redirect_to :action => 'view' - end + end end else render :nothing => true, :status => :forbidden @@ -223,7 +226,7 @@ class TraceController < ApplicationController conditions << params[:tag] end - traces = Trace.find(:all, :include => :user, :conditions => conditions, + traces = Trace.find(:all, :include => :user, :conditions => conditions, :order => "timestamp DESC", :limit => 20) rss = OSM::GeoRSS.new @@ -384,7 +387,15 @@ private else @user.preferences.create(:k => "gps.trace.visibility", :v => visibility) end - + + end + + def offline_warning + flash.now[:warning] = t 'trace.offline_warning.message' if OSM_STATUS == :gpx_offline + end + + def offline_redirect + redirect_to :action => :offline if OSM_STATUS == :gpx_offline end end